From: Petr Mladek <pmladek@suse.com>
To: Song Liu <song@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org,
live-patching@vger.kernel.org, indu.bhagat@oracle.com,
puranjay@kernel.org, wnliu@google.com, irogers@google.com,
joe.lawrence@redhat.com, jpoimboe@kernel.org,
mark.rutland@arm.com, peterz@infradead.org,
roman.gushchin@linux.dev, rostedt@goodmis.org, will@kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v3 0/2] arm64: livepatch: Enable livepatch without sframe
Date: Tue, 25 Mar 2025 13:53:09 +0100 [thread overview]
Message-ID: <Z-KnNU2A_kwwYdXU@pathway.suse.cz> (raw)
In-Reply-To: <20250320171559.3423224-1-song@kernel.org>
On Thu 2025-03-20 10:15:57, Song Liu wrote:
> There are recent efforts to enable livepatch for arm64, with sframe [1] or
> without sframe [2]. This set tries to enable livepatch without sframe. Some
> of the code, however, are from [1].
>
> Although the sframe implementation is more promising in longer term, it
> suffers from the following issues:
>
> 1. sframe is not yet supported in llvm;
> 2. There is still bug in binutil [3], so that we cannot yet use sframe
> with gcc;
> 3. sframe unwinder hasn't been fully verified in the kernel.
>
> On the other hand, arm64 processors have become more and more important in
> the data center world. Therefore, it is getting critical to support
> livepatching of arm64 kernels.
>
> With recent change in arm64 unwinder [4], it is possible to reliably
> livepatch arm64 kernels without sframe. This is because we do not need
> arch_stack_walk_reliable() to get reliable stack trace in all scenarios.
> Instead, we only need arch_stack_walk_reliable() to detect when the
> stack trace is not reliable, then the livepatch logic can retry the patch
> transition at a later time.
>
> Given the increasing need of livepatching, and relatively long time before
> sframe is fully ready (for both gcc and clang), we would like to enable
> livepatch without sframe.
>
> Thanks!
>
> [1] https://lore.kernel.org/live-patching/20250127213310.2496133-1-wnliu@google.com/
> [2] https://lore.kernel.org/live-patching/20250129232936.1795412-1-song@kernel.org/
> [3] https://sourceware.org/bugzilla/show_bug.cgi?id=32589
> [4] https://lore.kernel.org/linux-arm-kernel/20241017092538.1859841-1-mark.rutland@arm.com/
Hi, I am sorry but I haven't found time to look at this in time before
the merge window. Is it acceptable to postpone this change to 6.16,
please?
Best Regards,
Petr
next prev parent reply other threads:[~2025-03-25 12:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 17:15 [PATCH v3 0/2] arm64: livepatch: Enable livepatch without sframe Song Liu
2025-03-20 17:15 ` [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable Song Liu
2025-03-20 17:46 ` Weinan Liu
2025-03-20 17:54 ` Song Liu
2025-03-21 7:11 ` Josh Poimboeuf
2025-03-26 13:48 ` Miroslav Benes
2025-03-31 9:06 ` Andrea della Porta
2025-05-19 13:41 ` Mark Rutland
2025-05-19 16:57 ` Song Liu
2025-05-20 14:28 ` Will Deacon
2025-05-20 16:59 ` Mark Rutland
2025-03-20 17:15 ` [PATCH v3 2/2] arm64: Implement HAVE_LIVEPATCH Song Liu
2025-03-31 9:07 ` Andrea della Porta
2025-03-25 12:53 ` Petr Mladek [this message]
2025-03-25 13:37 ` [PATCH v3 0/2] arm64: livepatch: Enable livepatch without sframe Song Liu
2025-04-10 15:17 ` Petr Mladek
2025-05-16 16:53 ` Song Liu
2025-05-19 12:57 ` Mark Rutland
2025-05-19 14:22 ` Will Deacon
2025-05-19 16:40 ` Mark Rutland
2025-05-19 17:11 ` Dylan Hatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-KnNU2A_kwwYdXU@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=indu.bhagat@oracle.com \
--cc=irogers@google.com \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=puranjay@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=will@kernel.org \
--cc=wnliu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).