From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1348F38F80 for ; Mon, 31 Mar 2025 09:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743411938; cv=none; b=mM5FwFIDFy0q7vlLkoaxwKO5YE2/jYQN37Z8LBZ6TlipTScNlfMUehRptMKWWOF49HNuTSibXQR50H1h9rttLS92uLRVgZSoHIiKDPNIf126noZnYmvsSc5FVrCZg30B9vMgD8hrjZOqhrehsQ+z1Ot2P39DkJOHbGzfLI19akw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743411938; c=relaxed/simple; bh=F5TgRC9bCtufyBzH3WXoUaVVpRPo87NkKtuzFw9Wjfg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u9dl/EI79AKytBjHUrYa8zJ69C0DJxAiywLJhfDrPfCNLWxcuiHW29cL0BJngl2mEqQfIuC2mrFiEtvRVPRkLBQYKo8nuVVOxK7G3VNjSJiBzRy11AQrtdCtDJr8QgBi1FJRWxpnH+HO6H+wgMNMSxbeb5czwaXRYgu0VnyLh+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=buVywRIu; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="buVywRIu" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac2ab99e16eso851692666b.0 for ; Mon, 31 Mar 2025 02:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743411934; x=1744016734; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1G/2f/kzgQrI6H05GnwJcV5s7P3UOsc3wy1MZhe8JsE=; b=buVywRIul3twAU9cUMua9HYuyAGevUYOhh3071M21/yd4l7r6mcPXmYtdKURH3AwyE kVaEAACUDOvJAXfEo4k3/DB60qTsw74qRLy3kmuQa/OnZWEq4ysxQVoQDRzJSbQxA3/R TGbuhy9lpxjyWoN0vP0sExGC4VgnJAmYAOVrkZ0PxJxEIPnUBQtpa6sM3bmRtDQQ84XQ YgoTmHgIDNUeplKk+zO3TkSFCTmesrg/2v9Aqx+EgwoXQtrgqp3gkEvUDVY6zHnQoe+0 h8CTVFFpo4YtTfN9L/JQ6CoW4MqQZ3xD2Yg7Re47ExG5fTvEOTXpA3LuBQLflcKcjczg t7HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743411934; x=1744016734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1G/2f/kzgQrI6H05GnwJcV5s7P3UOsc3wy1MZhe8JsE=; b=sXG4t9Dj+2mArqahQuXDd1DTn/UjWxufhP8lspd0e0DbtjhkiVMjbm1gknIrZOccsT mzqBoQIhxTR/Mb8+Xysw0PUxJyxhtN1Nuzon1hPAq0bclYvzhcl2QAGaoSynYCbakEvH VmYi/99vAoKZdHh+HpG+bCupuydB6Vh31IwKO+xf8ua8EvWC+x9Kw0metNBwDWinkqbS DkI6SMSKjp/bySYdCiMrBe1AM5Yd24i3K+x/bcFMTcCJLYkX84aWyuHPO2aEKappyt9R A7rX7s5O4RFUpsLGo7VmNf4MoHbZIVdPJa5YPZQch25PsPjqdYvcS46B/etEZHg0cMns GJVw== X-Forwarded-Encrypted: i=1; AJvYcCVMVSqA3D75+UoQiM+SlGvY0j009HEMUO4ug2k/dpgBBekyWIwCc9VKngHC1d1C23PiIp3f9GzayA7PFCik@vger.kernel.org X-Gm-Message-State: AOJu0Yxcm0yLgCv0Jr8dzFflUBbshZSnHj0ZWm2bCwABAdCovXkZ1TKi geFKrs4pI5D3PQCFbXSU92rzQVw275nbAZFsRaD2yDfW2LLz6J9tVLO9tanZ1j8= X-Gm-Gg: ASbGncvCT9+Nc8+5Hi/7Wcg8FaoOYx91RUgAyCSLIw5v32D786j0ImtB/teU+CPciDi oCl2EPlLF8AEngYrF8KRfDwdntEc+RXS9UK4CdcHE0B63EgzoGPxKBAarS2VhIp67HLOjLvhJfA G871GZkDqtrDg/bCzOs3XKGFOwy3aAuutqxdREkBHbqEb1sFQMC0ggCiGcrF278IhRwk2wJ114d Rw933f4GojmehP+A+xLUv2xWAlMCo0CcXvedRMcrXQlME76cL8r893VpEzd+m3BS5Un+t7IzMjv vVZoJLlAWjrC4MWQ+Cs8X162QtqsWD1YGZxEAL1JkN2qm0/446JN7453P+H51VzZL6rmclOX7cx qAHaPUBKruyfQ X-Google-Smtp-Source: AGHT+IEZKen+GqDOHtdkyeLLNPETjZemufqDk6C+fKS+SFiLecdoalHH5ETBCA5wdaHh1QGXT8ZLeQ== X-Received: by 2002:a17:906:aacf:b0:ac7:4d45:f13e with SMTP id a640c23a62f3a-ac74d460c41mr385561566b.13.1743411934297; Mon, 31 Mar 2025 02:05:34 -0700 (PDT) Received: from localhost (host-87-5-222-245.retail.telecomitalia.it. [87.5.222.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71927af39sm590257066b.44.2025.03.31.02.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 02:05:33 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 31 Mar 2025 11:06:50 +0200 To: Song Liu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, live-patching@vger.kernel.org, indu.bhagat@oracle.com, puranjay@kernel.org, wnliu@google.com, irogers@google.com, joe.lawrence@redhat.com, jpoimboe@kernel.org, mark.rutland@arm.com, peterz@infradead.org, roman.gushchin@linux.dev, rostedt@goodmis.org, will@kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable Message-ID: References: <20250320171559.3423224-1-song@kernel.org> <20250320171559.3423224-2-song@kernel.org> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320171559.3423224-2-song@kernel.org> Hi song, On 10:15 Thu 20 Mar , Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably detect when the stack > trace is not reliable, which is enough to provide reliable livepatching. > > Signed-off-by: Song Liu > --- > arch/arm64/Kconfig | 2 +- > arch/arm64/kernel/stacktrace.c | 66 +++++++++++++++++++++++++--------- > 2 files changed, 51 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 701d980ea921..31d5e1ee6089 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -276,6 +276,7 @@ config ARM64 > select HAVE_SOFTIRQ_ON_OWN_STACK > select USER_STACKTRACE_SUPPORT > select VDSO_GETRANDOM > + select HAVE_RELIABLE_STACKTRACE > help > ARM 64-bit (AArch64) Linux support. > > @@ -2500,4 +2501,3 @@ endmenu # "CPU Power Management" > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > - > diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > index 1d9d51d7627f..7e07911d8694 100644 > --- a/arch/arm64/kernel/stacktrace.c > +++ b/arch/arm64/kernel/stacktrace.c > @@ -56,6 +56,7 @@ struct kunwind_state { > enum kunwind_source source; > union unwind_flags flags; > struct pt_regs *regs; > + bool end_on_unreliable; > }; > > static __always_inline void > @@ -230,8 +231,26 @@ kunwind_next_frame_record(struct kunwind_state *state) > new_fp = READ_ONCE(record->fp); > new_pc = READ_ONCE(record->lr); > > - if (!new_fp && !new_pc) > - return kunwind_next_frame_record_meta(state); > + if (!new_fp && !new_pc) { > + int ret; > + > + ret = kunwind_next_frame_record_meta(state); > + if (ret < 0) { > + /* > + * This covers two different conditions: > + * 1. ret == -ENOENT, unwinding is done. > + * 2. ret == -EINVAL, unwinding hit error. > + */ > + return ret; > + } > + /* > + * Searching across exception boundaries. The stack is now > + * unreliable. > + */ > + if (state->end_on_unreliable) > + return -EINVAL; > + return 0; > + } > > unwind_consume_stack(&state->common, info, fp, sizeof(*record)); > > @@ -277,21 +296,24 @@ kunwind_next(struct kunwind_state *state) > > typedef bool (*kunwind_consume_fn)(const struct kunwind_state *state, void *cookie); > > -static __always_inline void > +static __always_inline int > do_kunwind(struct kunwind_state *state, kunwind_consume_fn consume_state, > void *cookie) > { > - if (kunwind_recover_return_address(state)) > - return; > + int ret; > > - while (1) { > - int ret; > + ret = kunwind_recover_return_address(state); > + if (ret) > + return ret; > > + while (1) { > if (!consume_state(state, cookie)) > - break; > + return -EINVAL; > ret = kunwind_next(state); > + if (ret == -ENOENT) > + return 0; > if (ret < 0) > - break; > + return ret; > } > } > > @@ -324,10 +346,10 @@ do_kunwind(struct kunwind_state *state, kunwind_consume_fn consume_state, > : stackinfo_get_unknown(); \ > }) > > -static __always_inline void > +static __always_inline int > kunwind_stack_walk(kunwind_consume_fn consume_state, > void *cookie, struct task_struct *task, > - struct pt_regs *regs) > + struct pt_regs *regs, bool end_on_unreliable) > { > struct stack_info stacks[] = { > stackinfo_get_task(task), > @@ -348,11 +370,12 @@ kunwind_stack_walk(kunwind_consume_fn consume_state, > .stacks = stacks, > .nr_stacks = ARRAY_SIZE(stacks), > }, > + .end_on_unreliable = end_on_unreliable, > }; > > if (regs) { > if (task != current) > - return; > + return -EINVAL; > kunwind_init_from_regs(&state, regs); > } else if (task == current) { > kunwind_init_from_caller(&state); > @@ -360,7 +383,7 @@ kunwind_stack_walk(kunwind_consume_fn consume_state, > kunwind_init_from_task(&state, task); > } > > - do_kunwind(&state, consume_state, cookie); > + return do_kunwind(&state, consume_state, cookie); > } > > struct kunwind_consume_entry_data { > @@ -384,7 +407,18 @@ noinline noinstr void arch_stack_walk(stack_trace_consume_fn consume_entry, > .cookie = cookie, > }; > > - kunwind_stack_walk(arch_kunwind_consume_entry, &data, task, regs); > + kunwind_stack_walk(arch_kunwind_consume_entry, &data, task, regs, false); > +} > + > +noinline noinstr int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, > + void *cookie, struct task_struct *task) > +{ > + struct kunwind_consume_entry_data data = { > + .consume_entry = consume_entry, > + .cookie = cookie, > + }; > + > + return kunwind_stack_walk(arch_kunwind_consume_entry, &data, task, NULL, true); > } > > struct bpf_unwind_consume_entry_data { > @@ -409,7 +443,7 @@ noinline noinstr void arch_bpf_stack_walk(bool (*consume_entry)(void *cookie, u6 > .cookie = cookie, > }; > > - kunwind_stack_walk(arch_bpf_unwind_consume_entry, &data, current, NULL); > + kunwind_stack_walk(arch_bpf_unwind_consume_entry, &data, current, NULL, false); > } > > static const char *state_source_string(const struct kunwind_state *state) > @@ -456,7 +490,7 @@ void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, > return; > > printk("%sCall trace:\n", loglvl); > - kunwind_stack_walk(dump_backtrace_entry, (void *)loglvl, tsk, regs); > + kunwind_stack_walk(dump_backtrace_entry, (void *)loglvl, tsk, regs, false); > > put_task_stack(tsk); > } > -- > 2.47.1 > Tested-by: Andrea della Porta Thanks, Andrea