* [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols()
@ 2023-09-14 7:26 Zheng Yejian
2023-09-20 9:17 ` Petr Mladek
2023-09-20 9:29 ` Petr Mladek
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Yejian @ 2023-09-14 7:26 UTC (permalink / raw)
To: jpoimboe, jikos, mbenes, pmladek, joe.lawrence, live-patching,
linux-kernel
Cc: peterz, yeweihua4, zhengyejian1
Without the newline character, the log may not be printed immediately
after the error occurs.
Fixes: ca376a937486 ("livepatch: Prevent module-specific KLP rela sections from referencing vmlinux symbols")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 61328328c474..ecbc9b6aba3a 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -243,7 +243,7 @@ static int klp_resolve_symbols(Elf_Shdr *sechdrs, const char *strtab,
* symbols are exported and normal relas can be used instead.
*/
if (!sec_vmlinux && sym_vmlinux) {
- pr_err("invalid access to vmlinux symbol '%s' from module-specific livepatch relocation section",
+ pr_err("invalid access to vmlinux symbol '%s' from module-specific livepatch relocation section\n",
sym_name);
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols()
2023-09-14 7:26 [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols() Zheng Yejian
@ 2023-09-20 9:17 ` Petr Mladek
2023-09-20 9:29 ` Petr Mladek
1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2023-09-20 9:17 UTC (permalink / raw)
To: Zheng Yejian
Cc: jpoimboe, jikos, mbenes, joe.lawrence, live-patching,
linux-kernel, peterz, yeweihua4
On Thu 2023-09-14 15:26:44, Zheng Yejian wrote:
> Without the newline character, the log may not be printed immediately
> after the error occurs.
>
> Fixes: ca376a937486 ("livepatch: Prevent module-specific KLP rela sections from referencing vmlinux symbols")
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols()
2023-09-14 7:26 [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols() Zheng Yejian
2023-09-20 9:17 ` Petr Mladek
@ 2023-09-20 9:29 ` Petr Mladek
1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2023-09-20 9:29 UTC (permalink / raw)
To: Zheng Yejian
Cc: jpoimboe, jikos, mbenes, joe.lawrence, live-patching,
linux-kernel, peterz, yeweihua4
On Thu 2023-09-14 15:26:44, Zheng Yejian wrote:
> Without the newline character, the log may not be printed immediately
> after the error occurs.
>
> Fixes: ca376a937486 ("livepatch: Prevent module-specific KLP rela sections from referencing vmlinux symbols")
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
JFYI, the patch has been committed into livepatching.git, branch for-6.7.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-20 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 7:26 [PATCH] livepatch: Fix missing newline character in klp_resolve_symbols() Zheng Yejian
2023-09-20 9:17 ` Petr Mladek
2023-09-20 9:29 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).