From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010D816404 for ; Thu, 11 Jan 2024 13:14:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UTZd9lDa" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a2c375d2430so105313466b.1 for ; Thu, 11 Jan 2024 05:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704978863; x=1705583663; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YCNCVeMrlWJxf5qX+E5fJGrbwnZ87NzyDtVjQyYpgQk=; b=UTZd9lDafTlUTQtNY6vQS/PQVO9sDK+3DpFc++J83gZ+R2H515eoPglREqAYxvqTna HkMoIQI3TzyOob/RqNDNsgusv9WFsEjKaR+4jNlGzPvwInOnn2aEMBcFC3uV/PIxlneY A6xzWOHB3oqdDD+pjZrpodZs7L1TJOH4M9NZAy/L89qSESAt24znxuAC31ApRNwF51Wo OYBsc+FVsHWfx973FShGgNR0gRTL4SJ9srabe4bD9MhjAfozu16nDGyo6NwHBVC+UW2F dQODLnXuUOSUhZjelytJNSK+dtVtIeXb9GRBgxRBECReTHLf1XB56mq/j/K7d9e3eTia 1d+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704978863; x=1705583663; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YCNCVeMrlWJxf5qX+E5fJGrbwnZ87NzyDtVjQyYpgQk=; b=d7/rLVOu5p2XWu6uF5jGh3xhiKy8Pf1OaHUqyc6McSH3ZHS62aRr5INxI7W6wrGyL1 unL5cxq7CO6JH3om824V5u16DxuzvmOFFyfYuERmja+TOz9rnQg3cx4tJODZLym5pOra cElKftY5kL4rr1K0bbmJXrL4jAGwRxCo9WwPtMbkiSfLRFNiDlYmXX2h9+fh2Xxq2GQI 8w84yisDyB49DItQ7K7LGtHL+HRUb8ySUOOWl85IzoBiunQ3ras43m9aR9Qe0dD4pNWX fs/QW+bPQnualqpllHD8H3ielH75neXcZGw9BfylECPi2I7KuSb0k9R/WuYgdIBbzb6a qFmg== X-Gm-Message-State: AOJu0Yyqg0ECbCKrWprk1Ig7zOjbwYld+A0UpDZcPzHg5v1f4YhTkcdU 7GNLJluqOAWXFXjAA2c7ySCDyrkT+Diycw== X-Google-Smtp-Source: AGHT+IGBVw22W2OzEoJmEk9Elwj9ma9Il/3v/LVT8XzL3+C0bm8CX5rIyMF55d9KmXgQCByhP0JI3g== X-Received: by 2002:a17:906:6a05:b0:a28:ac84:5d52 with SMTP id qw5-20020a1709066a0500b00a28ac845d52mr782286ejc.2.1704978863223; Thu, 11 Jan 2024 05:14:23 -0800 (PST) Received: from alley ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id u3-20020a1709064ac300b00a269b4692a9sm568895ejt.84.2024.01.11.05.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 05:14:23 -0800 (PST) Date: Thu, 11 Jan 2024 14:14:20 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v5 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable Message-ID: References: <20240109-send-lp-kselftests-v5-0-364d59a69f12@suse.com> <20240109-send-lp-kselftests-v5-1-364d59a69f12@suse.com> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109-send-lp-kselftests-v5-1-364d59a69f12@suse.com> On Tue 2024-01-09 21:24:54, Marcos Paulo de Souza wrote: > Add TEST_GEN_MODS_DIR variable for kselftests. It can point to > a directory containing kernel modules that will be used by > selftest scripts. > > The modules are built as external modules for the running kernel. > As a result they are always binary compatible and the same tests > can be used for older or newer kernels. > > The build requires "kernel-devel" package to be installed. > For example, in the upstream sources, the rpm devel package > is produced by "make rpm-pkg" > > The modules can be built independently by > > make -C tools/testing/selftests/livepatch/ > > or they will be automatically built before running the tests via > > make -C tools/testing/selftests/livepatch/ run_tests > > Note that they are _not_ built when running the standalone > tests by calling, for example, ./test-state.sh. > > Along with TEST_GEN_MODS_DIR, it was necessary to create a new install > rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would > copy the entire TEST_GEN_MODS_DIR directory to the destination, even > the files created by Kbuild to compile the modules. The new install > rule copies only the .ko files, as we would expect the gen_tar to work. > > Reviewed-by: Joe Lawrence > Signed-off-by: Marcos Paulo de Souza I am not export on kbuild. But it looks reasonable and works for me. Reviewed-by: Petr Mladek Best Regards, Petr