From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D50F2D78C for ; Fri, 5 Jan 2024 14:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="XhCvbfkz" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a28d25253d2so172663766b.0 for ; Fri, 05 Jan 2024 06:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704463419; x=1705068219; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3bnN4quUJEriHwirvyf/MlXpTwHAU6a4DSC6ByIGJA=; b=XhCvbfkz4xkGtCVUYS6P6SCTByNC1xWYpzXGFzGFRpBiJY+Pxp01VrJsLZE8+u2TA0 a+9t4jcJXk9DgGBOAcU1a6H3v1y8vkPgQLcOKCZ7JAclZ6ukU2VfhNvvyOv6EmMWwmG8 n2gluIJRMq5UvWC9yNMyWHCO3p+j5Bf79pvUhKEjtMgdJCivV+ZNc5uEZqus7UeBZ200 M7716C9exydMONEvTM5F2niNIjfpLDIcR/yFvb6rndu6BG9pJvhoWmhph2Z2CjmWnCrR E8+oopJYNv20evry3TRGQMMwSufSykDNXtQkYSh10LoIUCYOqDth7x3Vd+ooxeL0POzT /rJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704463419; x=1705068219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K3bnN4quUJEriHwirvyf/MlXpTwHAU6a4DSC6ByIGJA=; b=Ndf3aeV6NHzVdqURNINUCauF4wOuaKr/anGf7ZsmWhKtnamcAj/u9OsxbnZnEIbES3 VFHMT9h5NTgUCA50Cj5Xdj3IE8/7hkvjUgmIICvCqMrGV+ZYmRXPV+PkIA/X5Tr7SFa0 oNSX4qPzZfY2rtCqONWJbB/wB2v4wroHRSGIMLB22+NDLVu3LS38BCBBw2+qVDlzNW4n bHpjW8c/OkZXvOchYnbxfSomlds+1OwR/cCtzllvsTBNau+aYTiKqwiBOyczz8KZkexY mfmDBY/RW4OKEEcAlS5pEOBQPjaft1RJ7fVaZZSCgqeSLiDZ130zNBTTxgXm/p9/nUO+ SiSw== X-Gm-Message-State: AOJu0YxhALjVAXGAOwHdZOUL95x0swQ8Dmcz+W/N0iTbLg0diXhDS5A0 ofwhW9DNt1JDGR7jLlDfQDWmwd2a+Kdbvg== X-Google-Smtp-Source: AGHT+IH67SLFJ8C5gG4C5TbvF/XM8nwvZHERmu7ffu0wKuatbRuETiCLz0Cl7892rpSm45VScaekzA== X-Received: by 2002:a17:906:2dcc:b0:a29:18c:8998 with SMTP id h12-20020a1709062dcc00b00a29018c8998mr752587eji.129.1704463418914; Fri, 05 Jan 2024 06:03:38 -0800 (PST) Received: from alley ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id t13-20020a170906178d00b00a28cf49520asm905749eje.203.2024.01.05.06.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 06:03:38 -0800 (PST) Date: Fri, 5 Jan 2024 15:03:36 +0100 From: Petr Mladek To: Lukas Hruska Cc: Miroslav Benes , Josh Poimboeuf , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Marcos Paulo de Souza , Josh Poimboeuf Subject: Re: [PATCH v1 3/5] kbuild/modpost: integrate klp-convert Message-ID: References: <20231106162513.17556-1-lhruska@suse.cz> <20231106162513.17556-4-lhruska@suse.cz> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106162513.17556-4-lhruska@suse.cz> On Mon 2023-11-06 17:25:11, Lukas Hruska wrote: > From: Josh Poimboeuf > > Update the modpost program so that it does not warn about unresolved > symbols matching the expected format which will be then resolved by > klp-convert. This in only one part. The main change is that it klp-convert is called for livepatch modules after the final linking. I would write something like: Call klp-convert for the livepatch modules after the final linking. Also update the modpost tool so that it does not warn about unresolved symbols matching the expected format which will be then resolved by klp-convert. > Signed-off-by: Josh Poimboeuf > Signed-off-by: Lukas Hruska Otherwise the code looks good. With the updated commit message: Reviewed-by: Petr Mladek Best Regards, Petr