From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BCD2DF9C for ; Fri, 5 Jan 2024 15:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QWAzhKpe" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a2814fa68eeso135119366b.1 for ; Fri, 05 Jan 2024 07:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704466910; x=1705071710; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lQR4Fg8cleRVcvnVry6aYWkKu4ehqJLNDHFhxBeysRs=; b=QWAzhKpeKQWUQuQP2MyvTczQkch8FEQwqwIRd5ueyGCbfrmx6YIG23QJYDh1B1RXow qA2XYnrwVVjAJXi53646aRBntfxo2KRx/MC0iQ8c0Saf0ROp7FoFOn3xEffXvkVnsXPM mbj/PJPl7PaaLWiGSGe8LMxABE0Tcu/OgTX9Ymqu2+3asB5m+SbDiq75F8cPs3PT2Tbp Xo0BXAC3CBi6krWg2N5reD1auiONCC77OPejZ5XCoXe/sjpu6DVXoxWBmvKnZI9mY7aw HcVPQGJQJ7UpcFPRLp4o/24m7Em1/f/4BmN+NGFboGaNEqOdukMkbArLTcCuoMOU/uV8 Gx1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704466910; x=1705071710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lQR4Fg8cleRVcvnVry6aYWkKu4ehqJLNDHFhxBeysRs=; b=sEk/yJz9DyGwA/UExYcFY4AP1masJ7us0Jjo0NVrX7ZK/grhyw9AvOpl0rWr+17lGH O5rFxFSAjcmOxZ7UN2MirJRnnmfBNt80ePg9oZ6tveIO6gObbXjfsFsmGBM8cMuDBvTO UoGFqC9wIQimM7lYyNaedMxgdKWx7wLWLyCaScHJbUwPJ1YdVehbdS0XZdNVWOlHdVlz imCHcv1fmM0XQa+TXTi/ZrmokxGd/C/5qG1+orG/eQDHJT9KqNOnzfZz3TXhI2mo5n/V qMvK/xoSi7wySqsc2HFKatMCVZxfJKwX6yX8yXmL7eZM+vm2BCERUVzecZD2ERYK81tC 1boA== X-Gm-Message-State: AOJu0YxtqZZJhUMdGCVS+CWWqpLnoVrJg6Hrj3MAiOYfGcJxLHVwq3E9 O1J9GyjZeUK80UmVcgjhlvmHbdh2b+RtFw== X-Google-Smtp-Source: AGHT+IG4hdWPcou8wDiQkdCfkBpIFfeLKQzUP3/H2ExfW99dzG+PEi22wr0raKPLobI28PfHOrtBBQ== X-Received: by 2002:a17:906:22cd:b0:a27:773b:fcf1 with SMTP id q13-20020a17090622cd00b00a27773bfcf1mr1159545eja.9.1704466910388; Fri, 05 Jan 2024 07:01:50 -0800 (PST) Received: from alley ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id dx10-20020a170906a84a00b00a283185ccd9sm968861ejb.90.2024.01.05.07.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:01:50 -0800 (PST) Date: Fri, 5 Jan 2024 16:01:48 +0100 From: Petr Mladek To: Lukas Hruska Cc: Miroslav Benes , Josh Poimboeuf , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Marcos Paulo de Souza , Josh Poimboeuf Subject: Re: [PATCH v1 2/5] livepatch: Add klp-convert tool Message-ID: References: <20231106162513.17556-1-lhruska@suse.cz> <20231106162513.17556-3-lhruska@suse.cz> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106162513.17556-3-lhruska@suse.cz> On Mon 2023-11-06 17:25:10, Lukas Hruska wrote: > Livepatches need to access external symbols which can't be handled > by the normal relocation mechanism. It is needed for two types > of symbols: > > --- /dev/null > +++ b/scripts/livepatch/klp-convert.c > @@ -0,0 +1,283 @@ [...] > +/* > + * Formats name of klp rela symbol based on another given section (@oldsec) > + * and object (@obj_name) name, then returns it > + */ > +static char *alloc_klp_rela_name(struct section *oldsec, > + char *target_objname, struct elf *klp_elf) > +{ Nit: Please, use @lp_obj_name instead of @target_objname. It would make it consistent with the caller: klp_rela_name = alloc_klp_rela_name(oldsec, lp_obj_name, klp_elf); and also with #define KLP_RELOC_SYMBOL_POS(LP_OBJ_NAME, SYM_OBJ_NAME, SYM_NAME, SYM_POS) > + char *klp_rela_name; > + unsigned int length; > + int err; Just for record. The name "lp_obj_name" came from a discussion between me and Lukas about the KLP_RELOC_SYMBOL_POS() parameter names. The macro has two object name parameters. And LP_OBJ_NAME aka LivePatched_OBJ_NAME looked better than TARGET_OBJ_NAME. The name "TARGET" is too ambiguous to me. Best Regards, Petr