From: Jiri Olsa <olsajiri@gmail.com>
To: Song Liu <songliubraving@meta.com>
Cc: Song Liu <song@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"andrey.grodzovsky@crowdstrike.com"
<andrey.grodzovsky@crowdstrike.com>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
Kernel Team <kernel-team@meta.com>,
"olsajiri@gmail.com" <olsajiri@gmail.com>
Subject: Re: [PATCH v2 bpf 0/3] Fix ftrace for livepatch + BPF fexit programs
Date: Sun, 26 Oct 2025 21:27:34 +0100 [thread overview]
Message-ID: <aP6ENht0hNVcVYbf@krava> (raw)
In-Reply-To: <8412F9AA-FEC6-4EFA-BACD-8B1579B90177@meta.com>
On Fri, Oct 24, 2025 at 08:47:08PM +0000, Song Liu wrote:
>
>
> > On Oct 24, 2025, at 11:28 AM, Song Liu <song@kernel.org> wrote:
> >
> > livepatch and BPF trampoline are two special users of ftrace. livepatch
> > uses ftrace with IPMODIFY flag and BPF trampoline uses ftrace direct
> > functions. When livepatch and BPF trampoline with fexit programs attach to
> > the same kernel function, BPF trampoline needs to call into the patched
> > version of the kernel function.
> >
> > 1/3 and 2/3 of this patchset fix two issues with livepatch + fexit cases,
> > one in the register_ftrace_direct path, the other in the
> > modify_ftrace_direct path.
> >
> > 3/3 adds selftests for both cases.
>
> AI has a good point on this:
>
> https://github.com/kernel-patches/bpf/pull/10088#issuecomment-3444465504
makes sense, I think it'll make the code easier to read
jirka
>
>
> I will wait a bit more for human to chime in before sending v3 with the
> suggestion by AI.
>
> Thanks,
> Song
>
prev parent reply other threads:[~2025-10-26 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 18:28 [PATCH v2 bpf 0/3] Fix ftrace for livepatch + BPF fexit programs Song Liu
2025-10-24 18:28 ` [PATCH v2 bpf 1/3] ftrace: Fix BPF fexit with livepatch Song Liu
2025-10-24 18:29 ` [PATCH v2 bpf 2/3] ftrace: bpf: Fix IPMODIFY + DIRECT in modify_ftrace_direct() Song Liu
2025-10-25 0:11 ` Steven Rostedt
2025-10-25 0:33 ` Song Liu
2025-10-26 9:53 ` kernel test robot
2025-10-24 18:29 ` [PATCH v2 bpf 3/3] selftests/bpf: Add tests for livepatch + bpf trampoline Song Liu
2025-10-24 20:47 ` [PATCH v2 bpf 0/3] Fix ftrace for livepatch + BPF fexit programs Song Liu
2025-10-26 20:27 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aP6ENht0hNVcVYbf@krava \
--to=olsajiri@gmail.com \
--cc=andrey.grodzovsky@crowdstrike.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=songliubraving@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).