Re: [PATCH v2 4/5] livepatch/klp-build: minor short-circuiting tweaks

[Joe Lawrence <joe.lawrence@redhat.com>]

On Wed, Feb 04, 2026 at 10:40:14AM -0800, Josh Poimboeuf wrote:
> On Tue, Feb 03, 2026 at 09:51:39PM -0500, Joe Lawrence wrote:
> > Update SHORT_CIRCUIT behavior to better handle patch validation and
> > argument processing in later klp-build steps.
> > 
> > Perform patch validation for both step 1 (building original kernel)
> > and step 2 (building patched kernel) to ensure patches are verified
> > before any compilation occurs.
> > 
> > Additionally, allow the user to omit input patches when skipping past
> > step 2, while noting that any specified patches will be ignored in that
> > case if they were provided.
> > 
> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> > ---
> >  scripts/livepatch/klp-build | 17 +++++++++++++----
> >  1 file changed, 13 insertions(+), 4 deletions(-)
> > 
> > diff --git a/scripts/livepatch/klp-build b/scripts/livepatch/klp-build
> > index ee43a9caa107..df3a0fa031a6 100755
> > --- a/scripts/livepatch/klp-build
> > +++ b/scripts/livepatch/klp-build
> > @@ -214,12 +214,18 @@ process_args() {
> >  	done
> >  
> >  	if [[ $# -eq 0 ]]; then
> > -		usage
> > -		exit 1
> > +		if (( SHORT_CIRCUIT <= 2 )); then
> > +			usage
> > +			exit 1
> > +		fi
> 
> Ack
> 
> > +	else
> > +		if (( SHORT_CIRCUIT >= 3 )); then
> > +			status "note: patch arguments ignored at step $SHORT_CIRCUIT"
> > +		fi
> 
> Personally I don't care to see this status, but maybe I'm biased from
> writing the --short-circuit feature and not being confused by this :-)
> 

Alrighty, I'll drop this part unless somebody asks for it.

--
Joe