Re: [PATCH v3 13/13] livepatch/klp-build: don't look for changed objects in tools/

[Joe Lawrence <joe.lawrence@redhat.com>]

On Tue, Feb 17, 2026 at 11:29:13AM -0800, Song Liu wrote:
> On Tue, Feb 17, 2026 at 8:07 AM Joe Lawrence <joe.lawrence@redhat.com> wrote:
> 
> I guess we still need a short commit message.
> 

Heh, checkpatch complained, but I didn't think such a trivial change
needed a full body :)

> Could you please share the patch that needs this change?
> 

Sorry I don't have a specific patch or repro for this one.  I hit this
during one of my -T, -T -S 2 short-circuiting testing runs.  I got an
error like this:

  error: klp-build: missing livepatch-cmdline-string.o for tools/testing/selftests/klp-build/artifacts/full-virtme-ng/cmdline-string/livepatch-cmdline-string.ko

to which I wondered why are we even looking for changed kernel objects
in tools/ ?  That directory may be stuffed with other weird stuff, a
combination of user-space and kernel-test .o's, so why bother? 

I can drop this one until it becomes something required.

--
Joe

> Thanks,
> Song
> 
> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> > ---
> >  scripts/livepatch/klp-build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/livepatch/klp-build b/scripts/livepatch/klp-build
> > index 5367d573b94b..9bbce09cfb74 100755
> > --- a/scripts/livepatch/klp-build
> > +++ b/scripts/livepatch/klp-build
> > @@ -564,8 +564,8 @@ find_objects() {
> >         local opts=("$@")
> >
> >         # Find root-level vmlinux.o and non-root-level .ko files,
> > -       # excluding klp-tmp/ and .git/
> > -       find "$OBJ" \( -path "$TMP_DIR" -o -path "$OBJ/.git" -o -regex "$OBJ/[^/][^/]*\.ko" \) -prune -o \
> > +       # excluding klp-tmp/, .git/, and tools/
> > +       find "$OBJ" \( -path "$TMP_DIR" -o -path "$OBJ/.git" -o -path "$OBJ/tools" -o -regex "$OBJ/[^/][^/]*\.ko" \) -prune -o \
> >                     -type f "${opts[@]}"                                \
> >                     \( -name "*.ko" -o -path "$OBJ/vmlinux.o" \)        \
> >                     -printf '%P\n'
> > --
> > 2.53.0
> >
> >
>