From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04FF33BBC4 for ; Wed, 18 Feb 2026 15:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771427911; cv=none; b=dEuARmIn4vICb2TGsA2uIrB1fIuwFRB5tPArWujhGuycYfIyEEIoR982EXlNCsVs95NJ1IxBuXgR5MV53zbc306muZ3+19E+RTb0umzUhAexca9EElNtwDq3CA+UpSv6npCgKwlOtGfNKE7ahiDRyoEQrvU1DPohcRfJmrwQaIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771427911; c=relaxed/simple; bh=BXcyrVR/FM8nPzhuNX7xXstI2yPgpJuQqp+me0+nDE0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ejiu6oseVO70xPESkt9/Xb2ebdugzv9zxWY1ECEVUFdTfcMPuwvfuks09T5k41goYj71VqLbuwHVRXFfZ1cbV1yOcLNwzAIDFHJH7iss9LDrwmA5HU+RmYXgZbM8T0yzB0Tb1W3bWtcRb8if3U2/KL2k6XWPJIIOo2eWG957CI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y13xR8T/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y13xR8T/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771427908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fp2xrC9bKGNFLrida/fnPjkY6pS1rb4Hfl9xpx4Cr3k=; b=Y13xR8T/eUnH55ooAhQjuOXMcX7INZEdJWXjUBCgb23napIwu8zzX0DQ2Shn/Sa6ZNCc3M A+zPB/vAh4e4N40L1FtrdA7Qnc/7Viji6DJZ0aTGFCKXPvcC2iPyaRwMtAKlARUYQbLoYK YuiOBfj86MzEkDedVd8fD3GC7r2BkwA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-ik0U0Tr4M0m8Upoq-UHajg-1; Wed, 18 Feb 2026 10:18:25 -0500 X-MC-Unique: ik0U0Tr4M0m8Upoq-UHajg-1 X-Mimecast-MFC-AGG-ID: ik0U0Tr4M0m8Upoq-UHajg_1771427904 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C0771956054; Wed, 18 Feb 2026 15:18:24 +0000 (UTC) Received: from redhat.com (unknown [10.22.80.197]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B51D130001A5; Wed, 18 Feb 2026 15:18:22 +0000 (UTC) Date: Wed, 18 Feb 2026 10:18:19 -0500 From: Joe Lawrence To: Song Liu Cc: live-patching@vger.kernel.org, Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek Subject: Re: [PATCH v3 13/13] livepatch/klp-build: don't look for changed objects in tools/ Message-ID: References: <20260217160645.3434685-1-joe.lawrence@redhat.com> <20260217160645.3434685-14-joe.lawrence@redhat.com> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Tue, Feb 17, 2026 at 11:29:13AM -0800, Song Liu wrote: > On Tue, Feb 17, 2026 at 8:07 AM Joe Lawrence wrote: > > I guess we still need a short commit message. > Heh, checkpatch complained, but I didn't think such a trivial change needed a full body :) > Could you please share the patch that needs this change? > Sorry I don't have a specific patch or repro for this one. I hit this during one of my -T, -T -S 2 short-circuiting testing runs. I got an error like this: error: klp-build: missing livepatch-cmdline-string.o for tools/testing/selftests/klp-build/artifacts/full-virtme-ng/cmdline-string/livepatch-cmdline-string.ko to which I wondered why are we even looking for changed kernel objects in tools/ ? That directory may be stuffed with other weird stuff, a combination of user-space and kernel-test .o's, so why bother? I can drop this one until it becomes something required. -- Joe > Thanks, > Song > > > Signed-off-by: Joe Lawrence > > --- > > scripts/livepatch/klp-build | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/livepatch/klp-build b/scripts/livepatch/klp-build > > index 5367d573b94b..9bbce09cfb74 100755 > > --- a/scripts/livepatch/klp-build > > +++ b/scripts/livepatch/klp-build > > @@ -564,8 +564,8 @@ find_objects() { > > local opts=("$@") > > > > # Find root-level vmlinux.o and non-root-level .ko files, > > - # excluding klp-tmp/ and .git/ > > - find "$OBJ" \( -path "$TMP_DIR" -o -path "$OBJ/.git" -o -regex "$OBJ/[^/][^/]*\.ko" \) -prune -o \ > > + # excluding klp-tmp/, .git/, and tools/ > > + find "$OBJ" \( -path "$TMP_DIR" -o -path "$OBJ/.git" -o -path "$OBJ/tools" -o -regex "$OBJ/[^/][^/]*\.ko" \) -prune -o \ > > -type f "${opts[@]}" \ > > \( -name "*.ko" -o -path "$OBJ/vmlinux.o" \) \ > > -printf '%P\n' > > -- > > 2.53.0 > > > > >