public inbox for live-patching@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Pablo Hugen <phugen@redhat.com>,
	live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, jpoimboe@kernel.org,
	jikos@kernel.org, mbenes@suse.cz, shuah@kernel.org
Subject: Re: [PATCH] selftests/livepatch: add test for module function patching
Date: Mon, 30 Mar 2026 15:43:57 +0200	[thread overview]
Message-ID: <acp-HYTmlaWYhS-h@pathway.suse.cz> (raw)
In-Reply-To: <acWZ3r2CoSDy_NLf@redhat.com>

On Thu 2026-03-26 16:41:02, Joe Lawrence wrote:
> On Thu, Mar 26, 2026 at 03:34:36PM +0100, Petr Mladek wrote:
> > On Fri 2026-03-20 17:11:17, Pablo Hugen wrote:
> > > From: Pablo Alessandro Santos Hugen <phugen@redhat.com>
> > > 
> > > Add a target module and livepatch pair that verify module function
> > > patching via a proc entry. Two test cases cover both the
> > > klp_enable_patch path (target loaded before livepatch) and the
> > > klp_module_coming path (livepatch loaded before target).
> > 
> > Summary:
> > 
> > IMHO, this patch is perfectly fine as is if we accept that it will get
> > eventually obsoleted by my patchset (hopefully in a year or two).
> > 
> > On the other hand, this patch would deserve some clean up,
> > (helper functions, don't die in the middle of the test) if
> > you planned to work on more tests. It would help to maintain
> > the tests.
> > 
> 
> Right, I think this was a good intro patch for Pablo and that the
> revised execution flow would be a great follow on series, if he is
> interested.  How about that?

JFYI, I have committed the patch into livepatching.git,
branch for-7.1/module-function-test.

Best Regards,
Petr

  parent reply	other threads:[~2026-03-30 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 20:11 [PATCH] selftests/livepatch: add test for module function patching Pablo Hugen
2026-03-24 14:22 ` Miroslav Benes
2026-03-24 14:45   ` Joe Lawrence
2026-03-25  8:45     ` Miroslav Benes
2026-03-31 20:52       ` Pablo Hugen
2026-03-26 14:34 ` Petr Mladek
2026-03-26 20:41   ` Joe Lawrence
2026-03-27 10:46     ` Miroslav Benes
2026-03-31 21:10       ` Pablo Hugen
2026-03-30 13:43     ` Petr Mladek [this message]
2026-03-30 13:48     ` speaker-test-module: " Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acp-HYTmlaWYhS-h@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=phugen@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox