From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
<linux-modules@vger.kernel.org>
Subject: Re: [PATCH] livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication
Date: Fri, 9 Dec 2022 19:29:56 +0800 [thread overview]
Message-ID: <aed3ca41-0f27-b44e-b95c-f7ed0a8ef468@huawei.com> (raw)
In-Reply-To: <Y5L75x+W1NrWCOcm@alley>
On 2022/12/9 17:12, Petr Mladek wrote:
> On Wed 2022-12-07 11:23:04, Zhen Lei wrote:
>> The implementation of function klp_match_callback() is identical to the
>> partial implementation of function klp_find_callback(). So call function
>> klp_match_callback() in function klp_find_callback() instead of the
>> duplicated code.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Thanks for cleaning this.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
Oh, sorry, I realized that I had forgotten to add:
Suggested-by: Petr Mladek <pmladek@suse.com>
Hi Luis:
Can you help me add it?
>
> Best Regards,
> Petr
> .
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2022-12-09 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 3:23 [PATCH] livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication Zhen Lei
2022-12-09 0:11 ` Song Liu
2022-12-09 0:22 ` Luis Chamberlain
2022-12-09 9:12 ` Petr Mladek
2022-12-09 11:29 ` Leizhen (ThunderTown) [this message]
2022-12-09 14:36 ` Petr Mladek
2022-12-10 1:09 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed3ca41-0f27-b44e-b95c-f7ed0a8ef468@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox