From: Petr Mladek <pmladek@suse.com>
To: Rui Qi <qirui.001@bytedance.com>
Cc: mbenes@suse.cz, jpoimboe@kernel.org, jikos@kernel.org,
joe.lawrence@redhat.com, shuah@kernel.org,
live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/livepatch: fix resource leak in test_klp_syscall init error path
Date: Thu, 4 Jun 2026 15:12:07 +0200 [thread overview]
Message-ID: <aiF5pxL7T7wa0S0b@pathway.suse.cz> (raw)
In-Reply-To: <20260604083208.1071428-1-qirui.001@bytedance.com>
On Thu 2026-06-04 16:32:08, Rui Qi wrote:
> In livepatch_init(), if klp_enable_patch() fails, the previously
> created kobject and sysfs file are never cleaned up, causing a
> resource leak. Capture the return value and add proper cleanup
> on the error path.
>
> Signed-off-by: Rui Qi <qirui.001@bytedance.com>
The patch looks good to me. I would ignore the proble reported by
Sashiko. so:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
PS: I am going to push this patch early next week if nobody complained
in the meantime.
next prev parent reply other threads:[~2026-06-04 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 12:45 [PATCH] selftests/livepatch: fix resource leak in test_klp_syscall init error path Rui Qi
2026-06-03 13:09 ` Miroslav Benes
2026-06-04 8:10 ` Rui Qi
2026-06-04 8:32 ` [PATCH v2] " Rui Qi
2026-06-04 8:42 ` sashiko-bot
2026-06-04 13:09 ` Petr Mladek
2026-06-04 13:12 ` Petr Mladek [this message]
2026-06-05 6:51 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiF5pxL7T7wa0S0b@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=qirui.001@bytedance.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox