From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675D537756F for ; Thu, 4 Jun 2026 13:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578732; cv=none; b=RjK8v1gOQnk3HswN+o7RC7jIP4ccllTKpC5znFFRmF9h7vOgurytNNPEDPcwf1OEx7WuDKeIgXPbwQcZYA/6X4uBG2HjDeF1dQ7YZlcCDGyTDm0G3bFRMXUAD2kXRYD5/skDgNq87N/w0OCw2AskIyu60ZRmkkQboN/LrhNnqVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578732; c=relaxed/simple; bh=OBm1VVRLV9hTK6acHhaWSaLn8uBTeuKKPYlhF6rnx/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E/6OEKSjPz43kCxVgmJq899gib/YVLRRx7fGwKtQ7qi3YFs0jgAPujkwYLF+8yg3+SQNoEWLYHmTMcP6iAliQSBt0TrTgcGb4VUmQmBa99BuKxhcbCsu7hRNMkVXSKs71jZWzwxc6SGJH4/uq8qLSMmZ68hIhCPOlB9jzSeVt5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QlwGeDI+; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QlwGeDI+" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b8a97b11so8319735e9.0 for ; Thu, 04 Jun 2026 06:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780578730; x=1781183530; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PeztH7p5NnQQR0rqBoGB3AILnqpwzKey0VzI8U/0hC0=; b=QlwGeDI+vQBttrkUv4bB8A3QG6OeQkMqL8NOlGSO3/vB0mS5OVBTpIdv9xy95jEt4A JqRpzjN6TKjSKxgVOtDMfvRYKJcRzDohCPiW4udtZAz4lYFc4v+hdjTSsXnnV9zbuYsK sFa4KQuhmRuZXDFCaf21UbFwHoZRmCZQoRji/99A5YFs3eg8hxN23eP4whgkY5i0agQt l0u+5i8a6ZIbvtlHlk8FJcoW26AJRCJGvujr6sAJAsfgzLTu3k8c92HKJVad6TRCrU2C jqWWXD/MWMOk208FIOZXj8/mGJ/QvRqq8gvHZbjpmIu0pKXQFAb8JT5wKStQDPkPPd4b edzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780578730; x=1781183530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PeztH7p5NnQQR0rqBoGB3AILnqpwzKey0VzI8U/0hC0=; b=FuCEWPdgvpC9zRMkrptRKJF/j0jIaLMEAgsEbdmsq4pGu4q/TncBgwd3o3go2YX0kP O7siKXyBsFYbulYIkiXDgQMIwu8jGw2mPO/z6KTA+zjh81mV/y1noiTSo7K/6H6Gci3e XuruhFr2PHKXzF8vT43yAdEhaEDRLc/6PsVz6TvWyTf0LmRO4oZbxryJUETHcG2C1uCj 4oDD5kGKQs1fg06Jz/tzV/JuakQTuuaWSiYeanq6s7fnQDLABa95d5nweKw9IninmzJa 7SPBRAmKwzqelN/MVovdf3ilJ+bVKzbVL4nGc1MLmDTZVS9dKnO3SYb/xBHYVcnjmF4e PStg== X-Forwarded-Encrypted: i=1; AFNElJ93df6H8E39iVk+w+GovdGlBlDCA5ZJH1viI0RNsGC86HvGsqR48QbD7heHuZYmMITL+PK0vQFdlPGs+XSh@vger.kernel.org X-Gm-Message-State: AOJu0YwC/pQeVSmh3cPgc9sggh5xq7svF9+Zkju7TB6OdZiwKHjyOeFJ brBXFRwNBZnTHMAudohRVKJnBXmWL3v/FuwH8Ef2/lvQaKQmZD/ZYMtYxHU32hROfzo= X-Gm-Gg: Acq92OFuZTWHkXqpSbOI7saRg92PlWCrIZAAE4X22dDV591HzIdcovlwuJwHLQmTIp/ 5i5OPh7J0l423/AT6dyD7OOVedbnF32ZVtWWDzA4/fimq0t9s6UFK7rrq662AGmZShGnW5c0v5w pRqIyMMf2n+8wH140Yz4cuUAHDZuSJBQjUF1mvcbIXsOsF+h8eabY98nIF8hXbjerRydWJi73IK O3INZFShA7/pULTnKkXAWSOWezFzYcpXnEGc9/KptJyxyxf1s8DFhWp6RpPOwAErrow7gfcmHx7 0asPQbhVpnw3UOtC5ZCjES7dlUSCnOAgs3PqfI48Envg/OyPPetLNt1WEyvqe/NyL4wehqYMDlr tF26cnYe0EESDNVxcQ/sltu8yRIJQW01t4yqyAoe6RtNKuLv/hDwcRjFxJ6cb08DnoqUIvOueZN KJtWDdK5sPUx7FTklJAma8Mxb/HEk7JAbc52EA X-Received: by 2002:a05:600c:46ce:b0:490:b4e5:ce7e with SMTP id 5b1f17b1804b1-490b5edcbe3mr118541755e9.25.1780578729826; Thu, 04 Jun 2026 06:12:09 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc413adbsm72658335e9.15.2026.06.04.06.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 06:12:09 -0700 (PDT) Date: Thu, 4 Jun 2026 15:12:07 +0200 From: Petr Mladek To: Rui Qi Cc: mbenes@suse.cz, jpoimboe@kernel.org, jikos@kernel.org, joe.lawrence@redhat.com, shuah@kernel.org, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/livepatch: fix resource leak in test_klp_syscall init error path Message-ID: References: <20260602124509.365996-1-qirui.001@bytedance.com> <20260604083208.1071428-1-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604083208.1071428-1-qirui.001@bytedance.com> On Thu 2026-06-04 16:32:08, Rui Qi wrote: > In livepatch_init(), if klp_enable_patch() fails, the previously > created kobject and sysfs file are never cleaned up, causing a > resource leak. Capture the return value and add proper cleanup > on the error path. > > Signed-off-by: Rui Qi The patch looks good to me. I would ignore the proble reported by Sashiko. so: Reviewed-by: Petr Mladek Best Regards, Petr PS: I am going to push this patch early next week if nobody complained in the meantime.