From: Joe Lawrence <joe.lawrence@redhat.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
song@kernel.org, live-patching@vger.kernel.org,
Wardenjohn <zhangwarden@gmail.com>
Subject: Re: [PATCH v3 4/7] livepatch: Deprecate stack_order
Date: Tue, 16 Jun 2026 14:44:11 -0400 [thread overview]
Message-ID: <ajGZexm8Q6MbtA2r@redhat.com> (raw)
In-Reply-To: <CALOAHbDgW_4fPktGHNnY-eqYRqg+d76EPTLgH-=twYOtwqA0vQ@mail.gmail.com>
On Thu, Jun 11, 2026 at 11:21:09AM +0800, Yafang Shao wrote:
> On Wed, Jun 10, 2026 at 11:11 PM Petr Mladek <pmladek@suse.com> wrote:
> >
> > On Sun 2026-06-07 21:16:56, Yafang Shao wrote:
> > > stack_order is no longer needed for atomic-replace livepatches, as a
> > > single function can only be modified by a unique replace_set.
> > > To maintain backward compatibility, print a dummy value, as suggested by
> > > sashiko-bot.
> >
> > I would personally remove it completely. I believe that there are
> > only few users around the world. And they will need to update
> > the tooling/strategy for the new "replace_set" anyway.
>
> I will remove it completely in the next version.
>
The kpatch-utility uses it (thanks for adding zhangwarden@gmail.com to
CC), but as I understand this patchset should effectively eliminate the
need for it (as per Wardenjohn's original use-case). So I'd be in favor
of removing it from sysfs as Petr suggested.
--
Joe
next prev parent reply other threads:[~2026-06-16 18:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 13:16 [PATCH v3 0/7] livepatch: Introduce replace set support Yafang Shao
2026-06-07 13:16 ` [PATCH v3 1/7] livepatch: Fix NULL pointer dereference in klp_find_func() Yafang Shao
2026-06-09 13:27 ` Petr Mladek
2026-06-10 3:00 ` Yafang Shao
2026-06-07 13:16 ` [PATCH v3 2/7] livepatch: Move klp_find_func() into core.h Yafang Shao
2026-06-09 15:28 ` Petr Mladek
2026-06-10 3:01 ` Yafang Shao
2026-06-07 13:16 ` [PATCH v3 3/7] livepatch: Support scoped atomic replace using replace_set Yafang Shao
2026-06-07 13:33 ` sashiko-bot
2026-06-07 14:00 ` Yafang Shao
2026-06-09 16:00 ` Petr Mladek
2026-06-10 3:24 ` Yafang Shao
2026-06-10 9:48 ` Petr Mladek
2026-06-11 12:58 ` Petr Mladek
2026-06-15 12:30 ` Yafang Shao
2026-06-16 2:41 ` Yafang Shao
2026-06-16 20:15 ` Joe Lawrence
2026-06-10 14:45 ` code review: was: " Petr Mladek
2026-06-11 3:06 ` Yafang Shao
2026-06-16 18:20 ` Joe Lawrence
2026-06-07 13:16 ` [PATCH v3 4/7] livepatch: Deprecate stack_order Yafang Shao
2026-06-07 13:31 ` sashiko-bot
2026-06-10 15:11 ` Petr Mladek
2026-06-11 3:21 ` Yafang Shao
2026-06-16 18:44 ` Joe Lawrence [this message]
2026-06-07 13:16 ` [PATCH v3 5/7] selftests/livepatch: Update tests for replace_set Yafang Shao
2026-06-07 13:29 ` sashiko-bot
2026-06-07 13:16 ` [PATCH v3 6/7] selftests/livepatch: Add test for state ID conflict across replace_sets Yafang Shao
2026-06-12 8:55 ` Petr Mladek
2026-06-15 11:59 ` Yafang Shao
2026-06-07 13:16 ` [PATCH v3 7/7] selftests/livepatch: Add test for function " Yafang Shao
2026-06-16 20:25 ` [PATCH v3 0/7] livepatch: Introduce replace set support Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajGZexm8Q6MbtA2r@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
--cc=zhangwarden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox