Live Patching
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: Chengming Zhou <zhouchengming@bytedance.com>,
	jpoimboe@redhat.com, jikos@kernel.org, joe.lawrence@redhat.com,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	songmuchun@bytedance.com, qirui.001@bytedance.com
Subject: Re: [PATCH v3] livepatch: Don't block removal of patches that are safe to unload
Date: Wed, 16 Mar 2022 16:03:54 +0100 (CET)	[thread overview]
Message-ID: <alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz> (raw)
In-Reply-To: <YjH7rniD4rBO6JIP@alley>

> > > + /*
> > > +	 * Only need to set forced flag for the transition patch
> > > +	 * when force transition to KLP_UNPATCHED state, but
> > > +	 * have to set forced flag for all replaced patches
> > > +	 * when force atomic replace transition.
> > > +	 */
> > 
> > How about something like
> > 
> > /*
> >  * Set forced flag for patches being removed, which is the transition
> >  * patch in KLP_UNPATCHED state or all replaced patches when forcing
> >  * the atomic replace transition.
> >  */
> 
> Or just the first sentence:
> 
> 	/* Set forced flag for patches being removed */
> 
> The rest is visible from the code.

True. This would work for me as well.

Miroslav

  reply	other threads:[~2022-03-16 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12 15:22 [PATCH v3] livepatch: Don't block removal of patches that are safe to unload Chengming Zhou
2022-03-16 14:48 ` Miroslav Benes
2022-03-16 15:01   ` Petr Mladek
2022-03-16 15:03     ` Miroslav Benes [this message]
2022-03-17  1:43       ` Joe Lawrence
2022-03-17  1:15     ` [External] " Chengming Zhou
2022-03-16 14:55 ` Petr Mladek
2022-03-17 18:38 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=qirui.001@bytedance.com \
    --cc=songmuchun@bytedance.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox