From: Miroslav Benes <mbenes@suse.cz>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Xi Zhang <zhangxi@kylinos.cn>,
live-patching@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] livepatch: Add config LIVEPATCH_DEBUG to get debug information
Date: Fri, 12 Sep 2025 09:14:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2509120912510.26788@pobox.suse.cz> (raw)
In-Reply-To: <8dcdba05-4d8c-83ff-f337-b6e71546e1a0@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Fri, 12 Sep 2025, Tiezhu Yang wrote:
> On 2025/9/11 下午9:50, Miroslav Benes wrote:
> > Hi,
> >
> > On Tue, 9 Sep 2025, Tiezhu Yang wrote:
> >
> >> Add config LIVEPATCH_DEBUG and define DEBUG if CONFIG_LIVEPATCH_DEBUG
> >> is set, then pr_debug() can print a debug level message, it is a easy
> >> way to get debug information without dynamic debugging.
> >
> > I do not have a strong opinion but is it really worth it? Configuring
>
> This is an alternative way, there are some similar usages:
>
> drivers/iommu/exynos-iommu.c:
> #ifdef CONFIG_EXYNOS_IOMMU_DEBUG
> #define DEBUG
> #endif
>
> drivers/mtd/nand/raw/s3c2410.c:
> #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG
> #define DEBUG
> #endif
>
> drivers/usb/storage/usb.c:
> #ifdef CONFIG_USB_STORAGE_DEBUG
> #define DEBUG
> #endif
>
> > dynamic debug is not difficult, it is more targetted (you can enable it
> > just for a subset of functions in livepatch subsystem) and it can also be
> > done on the command line.
>
> Yes, this is true. It is up to the maintainers to apply this patch
> or not.
Right and I do not see the point to have it in the tree for the reasons
above.
Miroslav
next prev parent reply other threads:[~2025-09-12 7:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 11:31 [PATCH v1 0/2] Debug and fix livepatch issues on LoongArch Tiezhu Yang
2025-09-09 11:31 ` [PATCH v1 1/2] livepatch: Add config LIVEPATCH_DEBUG to get debug information Tiezhu Yang
2025-09-11 13:50 ` Miroslav Benes
2025-09-12 2:26 ` Tiezhu Yang
2025-09-12 7:14 ` Miroslav Benes [this message]
2025-09-09 11:31 ` [PATCH v1 2/2] LoongArch: Return 0 for user tasks in arch_stack_walk_reliable() Tiezhu Yang
2025-09-10 1:11 ` Jinyang He
2025-09-11 11:49 ` Tiezhu Yang
2025-09-12 1:55 ` Jinyang He
2025-09-15 8:54 ` Tiezhu Yang
2025-09-11 13:44 ` Miroslav Benes
2025-09-15 8:48 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2509120912510.26788@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=chenhuacai@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
--cc=zhangxi@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox