From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D958131714F for ; Wed, 15 Apr 2026 12:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776254469; cv=none; b=rFV9w7EQ/Lql4K0swe9/HSJidiKle8L50soNVrWHu5YS4kvKQQd+Uy1nGKXvjQJ27/drAJuIBSSoRhrzQPIngQQ/+yPM2nF5vpqK0cLXRuZ5sClpUQTCDqRE6qMuHM+o6FGGa4g8Qq/ve8TSPgKTb8gRLD8jVJSrnrXkbgsepDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776254469; c=relaxed/simple; bh=xgiWfqlfVoW6Zct2Lcg7QhAziiHLNMkpAynFW7SzHNM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=oc9gRY5swwfeXw4oKqJ3NnIyFcJf3WA6KMsJ8lTd1UGldm2JLyEksA+XIMHtlZAyji2MkrVze70I7tNS5sVGbwmupjCsHdbIdd8jKVRP9hBMeyA2q222Y7Vc9MCfxrdiH5tZcYZQydOwBH4GJ01K5NIp9cfji+WGCee9U8NwyXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=W9VjdPKV; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=4oO2hk5a; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=W9VjdPKV; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=4oO2hk5a; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="W9VjdPKV"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="4oO2hk5a"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="W9VjdPKV"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="4oO2hk5a" Received: from pobox.suse.cz (unknown [10.128.32.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 23E2D6A7E2; Wed, 15 Apr 2026 12:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776254465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9wn17j2lK5IY0VmUpHhYcvC1wsTA3Kz/lTmapaTTmHc=; b=W9VjdPKVUTOMLhijX6fhezlFXPKaORW+jo63CdZo5slrfR5PMDCRDYePiIF+8apUE6R71T rQHCMsPooxbPo0vuW+/1FWzvJrIAJpKgjiH65V+JfyMUyAzxMgUZMf6z36trUMPes8vkS2 EG6rshk7Sf77jhdjA/BlS+Sv50aDWlQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776254465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9wn17j2lK5IY0VmUpHhYcvC1wsTA3Kz/lTmapaTTmHc=; b=4oO2hk5aU7gbjU27xxWkj6j9aO+SqRyTxODRSJxh9g+iC6Vga+q4mgNJZixNSNJVXgk5xc fOORunMtdGRIxaDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776254465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9wn17j2lK5IY0VmUpHhYcvC1wsTA3Kz/lTmapaTTmHc=; b=W9VjdPKVUTOMLhijX6fhezlFXPKaORW+jo63CdZo5slrfR5PMDCRDYePiIF+8apUE6R71T rQHCMsPooxbPo0vuW+/1FWzvJrIAJpKgjiH65V+JfyMUyAzxMgUZMf6z36trUMPes8vkS2 EG6rshk7Sf77jhdjA/BlS+Sv50aDWlQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776254465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9wn17j2lK5IY0VmUpHhYcvC1wsTA3Kz/lTmapaTTmHc=; b=4oO2hk5aU7gbjU27xxWkj6j9aO+SqRyTxODRSJxh9g+iC6Vga+q4mgNJZixNSNJVXgk5xc fOORunMtdGRIxaDw== Date: Wed, 15 Apr 2026 14:01:05 +0200 (CEST) From: Miroslav Benes To: Marcos Paulo de Souza cc: Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , Shuah Khan , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] kselftests: livepatch: Adapt tests to be executed on 4.12 kernels In-Reply-To: <20260413-lp-tests-old-fixes-v2-0-367c7cb5006f@suse.com> Message-ID: References: <20260413-lp-tests-old-fixes-v2-0-367c7cb5006f@suse.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-4.24 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.14)[-0.717]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email] X-Spam-Flag: NO X-Spam-Score: -4.24 X-Spam-Level: On Mon, 13 Apr 2026, Marcos Paulo de Souza wrote: > A new version of the patchset, with fewer patches now. Please take a look! > > Original cover-letter: > These patches don't really change how the patches are run, just skip > some tests on kernels that don't support a feature (like kprobe and > livepatched living together) or when a livepatch sysfs attribute is > missing. > > The last patch slightly adjusts check_result function to skip dmesg > messages on SLE kernels when a livepatch is removed. > > These patches are based on printk/for-next branch. > > Please review! Thanks! > > Signed-off-by: Marcos Paulo de Souza Besides my comment for 1/6 and what Sashiko discovered, it looks good to me. However, please also take a look at brand new test_modules/test_klp_mod_target.c. It does not build on old kernels since they lack proc_create_single(). I think it should be covered in this patch set too. Regards Miroslav