Re: [PATCH v2 0/6] kselftests: livepatch: Adapt tests to be executed on 4.12 kernels

Marcos Paulo de Souza
2026-04-15T12:37:38Z

On Wed, 2026-04-15 at 14:01 +0200, Miroslav Benes wrote:
> On Mon, 13 Apr 2026, Marcos Paulo de Souza wrote:
>
> > A new version of the patchset, with fewer patches now. Please take
> > a look!
> >
> > Original cover-letter:
> > These patches don't really change how the patches are run, just
> > skip
> > some tests on kernels that don't support a feature (like kprobe and
> > livepatched living together) or when a livepatch sysfs attribute is
> > missing.
> >
> > The last patch slightly adjusts check_result function to skip dmesg
> > messages on SLE kernels when a livepatch is removed.
> >
> > These patches are based on printk/for-next branch.
> >
> > Please review! Thanks!
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Besides my comment for 1/6 and what Sashiko discovered, it looks good
> to
> me.
>
> However, please also take a look at brand new
> test_modules/test_klp_mod_target.c. It does not build on old kernels
> since
> they lack proc_create_single(). I think it should be covered in this
> patch
> set too.

I saw that yesterday as well, but I wanted to merge this series first.
I have plans to create a way to unregister the livepatches if something
fails, so we can continue to run the other tests. I was planning to fix
the test_klp_mod_target.c in the same patchset.

>
> Regards
> Miroslav