From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013453AEF28 for ; Fri, 24 Apr 2026 11:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777029976; cv=none; b=s7b1XQ+xXWgup07K/mLOmI8dkzdu1CQktvbqwv3etNCaRoXFxsTNTagOSZlYA5ugug6yaiBfvHurmcTI06jcG4SWJWFB1xJp0Phk/VZDFQnuUQvmk9s2by6lZyZ84mzhH2EpOEbS4wIuruYz9PdP/eMiCKy3HY9srNdR/lvZA2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777029976; c=relaxed/simple; bh=X1RzfpWR3lhLI4fkc8ugUMaDV5zheKpf6xTvHhjKdYw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=jMnvWYRpuXFWb+1oTmw2NybCMSAOwTNTx3Jf+I7jLh3+1nXUCCYFFo3e6Wwla3bOOGkp1XWpupZ/2brihMm1WYEEZiZmAouDK9ZZiJiREoDUCoe07YoudG/laZ5L6/LVOTB4m7Vx7+x3DvSxwG+AnJd+tSEoT/DpAZ3wjuZH320= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hz+L8RJd; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=bgmd/BxP; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hz+L8RJd; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=bgmd/BxP; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hz+L8RJd"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="bgmd/BxP"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hz+L8RJd"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="bgmd/BxP" Received: from pobox.suse.cz (unknown [10.128.32.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 483C36A807; Fri, 24 Apr 2026 11:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1777029973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ijwsl8uYdJWK1YrmizQQeKEPnVtORJtdNR8MbPrWWLI=; b=hz+L8RJdIncF0Y/KS1uxfQFxtLLC2NKMYXR9s/3xi5d4EPjbndW3ox9MW4FtgM78WseytQ LtViEEOaFLUXTCjF8u3gyLLvFyJH7goGbHUJUwGY5LH1OF2TwQkJNmVxMzf64zphrnqvWe lF8v7WSfp9WdB/VwX1/G54NjsnhKg1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1777029973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ijwsl8uYdJWK1YrmizQQeKEPnVtORJtdNR8MbPrWWLI=; b=bgmd/BxPYHIoYza8AB1db94YI0duVpfFb4coPfmv/y0gIncrJFEm7Tz8Od6r/mL7imLEL0 Q8mS78mhdRcbh1DA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1777029973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ijwsl8uYdJWK1YrmizQQeKEPnVtORJtdNR8MbPrWWLI=; b=hz+L8RJdIncF0Y/KS1uxfQFxtLLC2NKMYXR9s/3xi5d4EPjbndW3ox9MW4FtgM78WseytQ LtViEEOaFLUXTCjF8u3gyLLvFyJH7goGbHUJUwGY5LH1OF2TwQkJNmVxMzf64zphrnqvWe lF8v7WSfp9WdB/VwX1/G54NjsnhKg1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1777029973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ijwsl8uYdJWK1YrmizQQeKEPnVtORJtdNR8MbPrWWLI=; b=bgmd/BxPYHIoYza8AB1db94YI0duVpfFb4coPfmv/y0gIncrJFEm7Tz8Od6r/mL7imLEL0 Q8mS78mhdRcbh1DA== Date: Fri, 24 Apr 2026 13:26:13 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: Song Liu , x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Peter Zijlstra , Joe Lawrence , Petr Mladek Subject: Re: [PATCH 04/48] objtool/klp: Ignore __UNIQUE_ID_*() PCI stub functions In-Reply-To: Message-ID: References: <93c7c80130375edd22874a57cdea132b0edbb0e4.1776916871.git.jpoimboe@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-2146828000-2109205470-1777029973=:25696" X-Spam-Score: -3.30 X-Spam-Level: X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; CTYPE_MIXED_BOGUS(1.00)[]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[8]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email] X-Spam-Flag: NO This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---2146828000-2109205470-1777029973=:25696 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 23 Apr 2026, Josh Poimboeuf wrote: > On Thu, Apr 23, 2026 at 02:33:00PM -0700, Song Liu wrote: > > On Thu, Apr 23, 2026 at 12:31 PM Josh Poimboeuf wrote: > > > > > > On Thu, Apr 23, 2026 at 12:05:03PM -0700, Song Liu wrote: > > > > On Wed, Apr 22, 2026 at 9:04 PM Josh Poimboeuf wrote: > > > > > > > > > > With Clang LTO enabled, DECLARE_PCI_FIXUP_SECTION() uses __UNIQUE_ID() > > > > > to generate uniquely named wrapper functions, which are being reported > > > > > as new functions and unnecessarily included in the patch module: > > > > > > > > > > vmlinux.o: new function: __UNIQUE_ID_quirk_f0_vpd_link_661 > > > > > > > > > > These stub functions only exist to make the compiler happy. Just ignore > > > > > them along with any other dont_correlate() symbols. Note that > > > > > dont_correlate() already includes prefix functions. > > > > > > > > > > Signed-off-by: Josh Poimboeuf > > > > > > > > The actual change appears to be much bigger than the subject line. > > > > Maybe rephrase it a bit? > > > > > > Hm, in fact this is a relic from a previous iteration of the patches: it > > > longer fixes what it claims to fix, as __UNIQUE_ID_ (other than > > > __ADDRESSABLE()) are now correlated. The claimed issue actually gets > > > fixed later by the rewriting of the correlation algorithm. > > > > > > That said, I still think the below is needed, I just need to rewrite the > > > commit log. > > > > Agreed. > > From: Josh Poimboeuf > Subject: [PATCH] objtool/klp: Don't report uncorrelated functions as new > > Clang LTO uses __UNIQUE_ID() to generate some uniquely named wrapper > functions, like initstubs. If they're uncorrelated, prevent them from > being reported as new functions and included unnecessarily. > > Note that dont_correlate() already includes prefix functions, so prefix > functions are still being ignored here. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Miroslav Benes M ---2146828000-2109205470-1777029973=:25696--