Re: [PATCH 0/2] livepatch: Move tests from lib/livepatch to selftests/livepatch

[Shuah Khan <skhan@linuxfoundation.org>]

On 6/3/22 8:32 AM, Marcos Paulo de Souza wrote:
> Hi there,
> 
> The first patch moves the current livepatch tests to selftests, allowing it
> be better suited to contain more complex tests, like using userspace C code
> to use the livepatched kernel code. As a bonus it allows to use
> "gen_tar" to export the livepatch selftests, rebuild the modules by
> running make in selftests/livepatch directory and simplifies the process
> of creating and debugging new selftests.
> 

In general selftests don't include modules. We keep test modules under lib.
One of the reasons is that modules have dependencies on the kernel and should
be built when kernel is built.

I don't fully buy the argument that moving modules under selftest would simplify
the process.

> It keeps the ability to execute the tests by running the shell scripts,
> like "test-livepatch.sh", but beware that the kernel modules
> might not be up-to-date.
> 

I am not what you mean by this.

> The second patch includes a new test to exercise the functionality to livepatch
> a heavy hammered function. The test uses getpid in this case.
> 
> I tested the changes by running the tests within the kernel source tree and running
> from the gen_tar extracted directory.
> 

I would like to understand the negatives of continuing to keep modules under lib?

thanks,
-- Shuah