From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AEDC761A6 for ; Fri, 31 Mar 2023 15:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233023AbjCaP7T (ORCPT ); Fri, 31 Mar 2023 11:59:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232887AbjCaP7Q (ORCPT ); Fri, 31 Mar 2023 11:59:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53D8FB44B for ; Fri, 31 Mar 2023 08:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680278305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJdWf+C1H4WFOkVELieC/JAW8cI4Ny85dWN0l46/HX8=; b=hWeQpEj50iV+pECC5S1s32mMcyw0T4iZ3GEiO2qmEgoj2PpsCEM2m7mJf3h+Dh7X0dLaPO YymtmXHoL6l4iZ+9M6Zo3qv46vfAN3Dz3WvNLP7NhJlyDL8lh2PxzDLwGwRVMrc7/BhlW7 voT9W502jCTGVbgsdwefeHiaSdL2ztQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-m2-OF_QdN9erLFYb94s9TA-1; Fri, 31 Mar 2023 11:58:23 -0400 X-MC-Unique: m2-OF_QdN9erLFYb94s9TA-1 Received: by mail-qv1-f71.google.com with SMTP id w2-20020a0cc242000000b00583d8e55181so9922956qvh.23 for ; Fri, 31 Mar 2023 08:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680278303; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IJdWf+C1H4WFOkVELieC/JAW8cI4Ny85dWN0l46/HX8=; b=6VZaiHAs/PEUl57h/GHSeTB9vq/Avv/w93kuqJ1bWT1a4K4nppzCyU9Gl1KExtVPKm UtbDplOer4S8m10zoke9SeIJBIB7X7Ms6TCROJPT+298sM1+aLMx8W0QBoq0DPxgyMhQ XIzFWUhjYsjALtIl8iMHQ6/ShjRRm6P/A/IQeKjrIOBXPK7GqgDgGRYZm88Myqrxue2e nlz+IvsOF3D70HkZ4YjVWvIjqksvvVD32x+dnrsJzIAu9QDEkdv3VY8AY/uYFINgOsU3 2ocpVlI5rrti2Gd/4W+7/QUQs93wkMEmR2p94XCQG/UwVy1fniqJg8bgby6Va7Jkx4bD DZoQ== X-Gm-Message-State: AO0yUKWmBxjtddU5UsrZ9hmlAd0Ob4ILCjdP1ihQdN21alnIu3F2KKDM DARumGwUh7bJUR327yvAo3D92pknY3zvgSGwp6RcksFa4ZFWaDoQUFOw+CDcDV0MNlYhy5WVt64 w79kd8pXuU2OA19JJ1cjNKZMZhg== X-Received: by 2002:ac8:5884:0:b0:3c0:3d0b:e433 with SMTP id t4-20020ac85884000000b003c03d0be433mr35596928qta.10.1680278303533; Fri, 31 Mar 2023 08:58:23 -0700 (PDT) X-Google-Smtp-Source: AK7set9lAS57G/fztM3/8Ml5aym5cxLEs4YQ07OF5pcXIbIHI2+f3a2ZqY6QsbGQpXVR1E5SZKyiZw== X-Received: by 2002:ac8:5884:0:b0:3c0:3d0b:e433 with SMTP id t4-20020ac85884000000b003c03d0be433mr35596904qta.10.1680278303274; Fri, 31 Mar 2023 08:58:23 -0700 (PDT) Received: from [192.168.1.12] (pool-68-160-135-240.bstnma.fios.verizon.net. [68.160.135.240]) by smtp.gmail.com with ESMTPSA id h6-20020ac85686000000b003d29e23e214sm692447qta.82.2023.03.31.08.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 08:58:22 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 11:58:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Alexey Dobriyan Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Josh Poimboeuf , Miroslav Benes , Petr Mladek , Marcos Paulo de Souza References: <4ce29654-4e1e-4680-9c25-715823ff5e02@p183> From: Joe Lawrence Subject: Re: [PATCH v7 00/10] livepatch: klp-convert tool In-Reply-To: <4ce29654-4e1e-4680-9c25-715823ff5e02@p183> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On 3/30/23 08:10, Alexey Dobriyan wrote: > Joe Lawrence wrote: >> +static int update_strtab(struct elf *elf) >> +{ >> >> + buf = malloc(new_size); >> + if (!buf) { >> + WARN("malloc failed"); >> + return -1; >> + } >> + memcpy(buf, (void *)strtab->data, orig_size); > > This code is called realloc(). :-) > >> +static int write_file(struct elf *elf, const char *file) >> +{ >> >> + fd = creat(file, 0664); >> + e = elf_begin(fd, ELF_C_WRITE, NULL); > > elf_end() doesn't close descriptor, so there is potentially corrupted > data. There is no unlink() call if writes fail as well. > >> +void elf_close(struct elf *elf) >> +{ >> + >> + if (elf->fd > 0) >> + close(elf->fd); > > Techically, it is "fd >= 0". > >> +filechk_klp_map = \ >> + echo "klp-convert-symbol-data.0.1"; \ >> + echo "*vmlinux"; \ >> + $(NM) -f posix vmlinux | cut -d\ -f1; \ >> + sort $(MODORDER) $(MODULES_LIVEPATCH) | \ > > This probably should be "LC_ALL=C sort" for speed and reproducibility (?). > Thanks, will incorporate these into the next version. -- Joe