From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791D8C433DF for ; Tue, 30 Jun 2020 13:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5503720672 for ; Tue, 30 Jun 2020 13:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387936AbgF3NEy (ORCPT ); Tue, 30 Jun 2020 09:04:54 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:45370 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387492AbgF3NEx (ORCPT ); Tue, 30 Jun 2020 09:04:53 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ABBDE157EE50F893074F; Tue, 30 Jun 2020 21:04:27 +0800 (CST) Received: from [127.0.0.1] (10.174.179.63) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 30 Jun 2020 21:04:20 +0800 Subject: Re: Question: livepatch failed for new fork() task stack unreliable To: Josh Poimboeuf CC: , , , , , , , , , , References: <20200529174433.wpkknhypx2bmjika@treble> <20200601180538.o5agg5trbdssqken@treble> <20200602131450.oydrydelpdaval4h@treble> <1353648b-f3f7-5b8d-f0bb-28bdb1a66f0f@huawei.com> <20200603153358.2ezz2pgxxxld7mj7@treble> <2225bc83-95f2-bf3d-7651-fdd10a3ddd00@huawei.com> <20200604024051.6ovbr6tbrowwg6jr@treble> <20200605015142.w65uu5wxfmrun2ro@treble> From: "Wangshaobo (bobo)" Message-ID: Date: Tue, 30 Jun 2020 21:04:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20200605015142.w65uu5wxfmrun2ro@treble> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.63] X-CFilter-Loop: Reflected Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org 在 2020/6/5 9:51, Josh Poimboeuf 写道: > On Fri, Jun 05, 2020 at 09:26:42AM +0800, Wangshaobo (bobo) wrote: >>>> So, I want to ask is there any side effects if i modify like this ? this >>>> modification is based on >>>> >>>> your fix. It looks like ok with proper test. >>>> >>>> diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c >>>> index e9cc182aa97e..ecce5051e8fd 100644 >>>> --- a/arch/x86/kernel/unwind_orc.c >>>> +++ b/arch/x86/kernel/unwind_orc.c >>>> @@ -620,6 +620,7 @@ void __unwind_start(struct unwind_state *state, struct >>>> task_struct *task, >>>>                 state->sp = task->thread.sp; >>>>                 state->bp = READ_ONCE_NOCHECK(frame->bp); >>>>                 state->ip = READ_ONCE_NOCHECK(frame->ret_addr); >>>> +              state->signal = ((void *)state->ip == ret_from_fork); >>>>         } >>>> >>>> diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c >>>> index 7f969b2d240f..d7396431261a 100644 >>>> --- a/arch/x86/kernel/unwind_orc.c >>>> +++ b/arch/x86/kernel/unwind_orc.c >>>> @@ -540,7 +540,7 @@ bool unwind_next_frame(struct unwind_state *state) >>>>          state->sp = sp; >>>>          state->regs = NULL; >>>>          state->prev_regs = NULL; >>>> -        state->signal = ((void *)state->ip == ret_from_fork); >>>> +        state->signal = false; >>>>          break; >>> Yes that's correct. >> Hi, josh >> >> Could i ask when are you free to send the patch, all the tests are passed >> by. > I want to run some regression tests, so it will probably be next week. Hi, josh did you send this patch, I haven't received it up to now, so i ask u to confirm again. thanks, Wang ShaoBo