From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ACDAF9EC for ; Fri, 6 Jun 2025 13:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749215166; cv=none; b=JZfAZRWnbVSN2rdTkGJvT4xAY9dycjw4mJCKL0WGQTmWE/hmlql4Fw23j4koAZRZN8K6sRKClSU2d1ivVaHCzBrU7SWCDNBDbgIQv6ZZ7X46KqvgQcZRdgXnP3Q+uhmpLtB3gut/vs1RXnRakgl1WbUv3UiKnGM8XUnV91nMOiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749215166; c=relaxed/simple; bh=C1GT0Omhkh4mzSLsciQfyAKel4MDNktx3SepqIEgJtk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p39AqtGM8RU1JxJmgSaprY4M/Hwud66m+a9DcOKM7rFR3W55VsMJ5lB9hGcX48M/Sfq1eLf3CVH4bximPA8fLfMk3gDbqp4ktFf6YxyMMUIZVmsYY8Rgew+ft0KChK/ykfaX/Y+Q4UezGh3ev2K4TbouP+WpY1XkTHDVblMAwlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=emz2BkkX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="emz2BkkX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749215163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5BSoPKdS5u7WoJFLwbKI61wUvIj0zk/QD32Y3X5nyxg=; b=emz2BkkXn+qNs48IaVaFVPG6NTukDXtVBM7sqMJOXAHlFt7B6AmynuwOg2TO7Nf7xweWaw 4FyCfPJQXfaNrz/t6NuxhQFawpPy8rSNgzPKJ5PB1WGIEIe0P9U9D1AiIU9q1gB/yKPEZh O4Em+pTnqRKqB0dK7ik6b0aQpI1z7zk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-YxwsjUJMMMiYOb4g23lKuw-1; Fri, 06 Jun 2025 09:06:02 -0400 X-MC-Unique: YxwsjUJMMMiYOb4g23lKuw-1 X-Mimecast-MFC-AGG-ID: YxwsjUJMMMiYOb4g23lKuw_1749215161 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d097fd7b32so457821185a.2 for ; Fri, 06 Jun 2025 06:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749215161; x=1749819961; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5BSoPKdS5u7WoJFLwbKI61wUvIj0zk/QD32Y3X5nyxg=; b=igcbdR0olHu3rmOhlLUogncG+gbSPzunBcWijubwnfzEcAiouDp9L/u7CocKg6a4HO BF+V1wJTLdjv3yCuasBJxcFSJmZWybl/7nc6j/Q3aKJyHPtSkXEMoykDwVEqfYxyBhCd RWg0opcBsPSN0h3/ryMZGAWnBWnqR/K6CwUjCG/UnaFBnvG8YtNI/s6PBfgT4uqfdn3x M244djqHJcjLVE/X3Hb14FGp57jLtM1Qv2pvrPb3mTmnTPwT2uFWzIu9ATbSKxlnuV5V ulzVSZrFJZf1M86ZZjj+hMiLPd1uuCXvq5HlQ8wuhKz/KG/LG/PGSwyT+7UCpEQ9jePb lRiQ== X-Forwarded-Encrypted: i=1; AJvYcCV5XDfw8WcM0xETmGkzEf8F4u7wPCq0bBZsqk+oe5xT8BDyNM7NLwb99HjHiIIDTk1cL7SUInvw8vSbM2bE@vger.kernel.org X-Gm-Message-State: AOJu0Yx5vSwmc94F5eX7Yg4wqLKxvJL33hYh+qeu55/KQ0VcOEFraNBv wH/19h6uJAljvoRWwmdVdc3vu7MWiX6NMYRLc6P93I7mdEYgxIpXRvdkVhAQdBj3FeK9BOfCcOL KWNp8GbMlVI4wncU8fzlI/y0EnRPTZKvE34uSVbkupsrpeA3JARonsnVgVKdnxh1yvLE= X-Gm-Gg: ASbGncub5NcNiMJTuBlHVM67/8znqAcVVtziZQYvCvDTe0g02lyC/8ZK/ntSHvIsjYD jG79c8sxAzYAidi9GD+KoesTfFoNQDqPgal2jFr7tL8z5x6CRelrRvwMiptsKT1/btqksvTutqr kQA81t6B1N6qRtK0niqk/8lvRBzY4H8aJZsnoWKszLye6u3Bo7QqFLYW32wRxyX+Rj2BRRNW2CR cKrsm2+1FaddqXBsDlhZJtzZHJ9CEIvR+EOlBGZM1xdjyhRlA62PFH7Z1/3W+nGJ8YGlSLQL6Si iF9/2UBdQFid90rUIY6SsFjHpRwP3Ss/htV8tdhOs6tkHlODyzi3Cg/wxkH5gdWlwh8= X-Received: by 2002:a05:620a:3955:b0:7c5:a2de:71d3 with SMTP id af79cd13be357-7d22987fd96mr489759785a.20.1749215161517; Fri, 06 Jun 2025 06:06:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUdVvO738H51zx3RkpFD2tOGdJQjBekLK/xn3jpyoVqPrtFayMU3gCbklQpppj/190tyxMbg== X-Received: by 2002:a05:620a:3955:b0:7c5:a2de:71d3 with SMTP id af79cd13be357-7d22987fd96mr489754185a.20.1749215161067; Fri, 06 Jun 2025 06:06:01 -0700 (PDT) Received: from [192.168.1.17] (pool-68-160-160-85.bstnma.fios.verizon.net. [68.160.160.85]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d250e70898sm126377285a.20.2025.06.06.06.05.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 06:06:00 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 09:05:59 -0400 Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules To: Josh Poimboeuf , x86@kernel.org Cc: linux-kernel@vger.kernel.org, Petr Mladek , Miroslav Benes , live-patching@vger.kernel.org, Song Liu , laokz , Jiri Kosina , Marcos Paulo de Souza , Weinan Liu , Fazla Mehrab , Chen Zhongjin , Puranjay Mohan References: <10ccbeb0f4bcd7d0a10cc9b9bd12fdc4894f83ee.1746821544.git.jpoimboe@kernel.org> Content-Language: en-US From: Joe Lawrence Autocrypt: addr=joe.lawrence@redhat.com; keydata= xsFNBFgTlmsBEADfrZirrMsj9Z9umoJ5p1rgOitLBABITvPO2x5eGBRfXbT306zr226bhfPj +SDlaeIRwKoQvY9ydB3Exq8bKObYZ+6/OAVIDPHBVlnZbysutSHsgdaGqTH9fgYhoJlUIApz suQL0MIRkPi0y+gABbH472f2dUceGpEuudIcGvpnNVTYxqwbWqsSsfT1DaAz9iBCeN+T/f/J 5qOXyZT7lC6vLy07eGg0uBh9jQznhbfXPIev0losNe7HxvgaPaVQ+BS9Q8NF8qpvbgpO+vWQ ZD5+tRJ5t85InNiWR3bv01GcGXEjEVTnExYypajVuHxumqJeqGNeWvx26cfNRQJQxVQNV7Gz iyAmJO7UulyWQiJqHZPcXAfoWyeKKAJ37YIYfE3k+rm6ekIwSgc9Lacf+KBfESNooU1LnwoQ ok9Q6R5r7wqnhCziqXHfyN2YGhm0Wx4s7s6xIVrx3C5K0LjXBisjAthG/hbPhJvsCz5rTOmP jkr+GSwBy2XUdOmtgq1IheBFwvWf08vrzNRCqz3iI1CvRpz0ZYBazmkz924u4ul6W7JuCdgy qW3UDLA77XlzFrA7nJ6rb77aZF7LJlkahX7lMaKZUzH+K4aVKTdvZ3szm9K+v0iixsM0TEnz oWsZgrkAA0OX2lpLfXvskoujQ84lY989IF+nUwy0wRMJPeqNxwARAQABzSZKb2UgTGF3cmVu Y2UgPGpvZS5sYXdyZW5jZUByZWRoYXQuY29tPsLBlgQTAQgAQAIbAwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAFiEEXzkJ3py1AClxRoHJx96nQticmuUFAmF2uf8FCRLJJRQACgkQx96n QticmuU69A/9FB5eF5kc392ifa/G6/m8q5BKVUXBMWy/RcRaEVUwl9lulJd99tkZT5KwwdIU eYSpmT4SXrMzHj3mWe8RcFT9S39RvmZA6UKQkt9mJ+dvUVyDW1pqAB+S6+AEJyzw9AoVPSIG WcHTCHdJZfZOMmFjDyduww7n94qXLO0oRMhjvR9vUqfBgEBSLzRSK96HI38brAcj33Q3lCkf 8uNLEAHVxN57bsNXxMYKo/i7ojFNCOyFEdPCWUMSF+M0D9ScXZRZCwbx0369yPSoNDgSIS8k iC/hbP2YMqaqYjxuoBzTTFuIS60glJu61RNealNjzvdlVz3RnNvD4yKz2JUsEsNGEGi4dRy7 tvULj0njbwdvxV/gRnKboWhXVmlvB1qSfimSNkkoCJHXCApOdW0Og5Wyi+Ia6Qym3h0hwG0r r+w8USCn4Mj5tBcRqJKITm92IbJ73RiJ76TVJksC0yEfbLd6x1u6ifNQh5Q7xMYk0t4VF6bR 56GG+3v1ci1bwwY5g1qfr7COU7in2ZOxhEpHtdt08MDSDFB3But4ko8zYqywP4sxxrJFzIdq 7Kv8a2FsLElJ3xG7jM260sWJfgZNI5fD0anbrzn9Pe1hShZY+4LXVJR/k3H01FkU9jWan0G/ 8vF04bVKng8ZUBBT/6OYoNQHzQ9z++h5ywgMTITy5EK+HhnOwU0EWBOWawEQALxzFFomZI1s 4i0a6ZUn4eQ6Eh2vBTZnMR2vmgGGPZNZdd1Ww62VnpZamDKFddMAQySNuBG1ApgjlFcpX0kV zm8PCi8XvUo0O7LHPKUkOpPM1NJKE1E3n5KqVbcTIftdTu3E/87lwBfEWBHIC+2K6K4GwSLX AMZvFnwqkdyxm9v0UiMSg87Xtf2kXYnqkR5duFudMrY1Wb56UU22mpZmPZ3IUzjV7YTC9Oul DYjkWI+2IN+NS8DXvLW8Dv4ursCiP7TywkxaslVT8z1kqtTUFPjH10aThjsXB5y/uISlj7av EJEmj2Cbt14ps6YOdCT8QOzXcrrBbH2YtKp2PwA3G3hyEsCFdyal8/9h0IBgvRFNilcCxxzq 3gVtrYljN1IcXmx87fbkV8uqNuk+FxR/dK1zgjsGPtuWg1Dj/TrcLst7S+5VdEq87MXahQAE O5qqPjsh3oqW2LtqfXGSQwp7+HRQxRyNdZBTOvhG0sys4GLlyKkqAR+5c6K3Qxh3YGuA77Qb 1vGLwQPfGaUo3soUWVWRfBw8Ugn1ffFbZQnhAs2jwQy3CILhSkBgLSWtNEn80BL/PMAzsh27 msvNMMwVj/M1R9qdk+PcuEJXvjqQA4x/F9ly/eLeiIvspILXQ5LodsITI1lBN2hQSbFFYECy a4KuPkYHPZ3uhcfB0+KroLRxABEBAAHCwXwEGAEIACYCGwwWIQRfOQnenLUAKXFGgcnH3qdC 2Jya5QUCYXa52AUJEskk7QAKCRDH3qdC2Jya5awND/9d9YntR015FVdn910u++9v64fchT+m LqD+WL24hTUMOKUzAVxq+3MLN4XRIcig4vnLmZ2sZ7VXstsukBCNGdm8y7Y8V1tXqeor82IY aPzfFhcTtMWOvrb3/CbwxHWM0VRHWEjR7UXG0tKt2Sen0e9CviScU/mbPHAYsQDkkbkNFmaV KJjtiVlTaIwq/agLZUOTzvcdTYD5QujvfnrcqSaBdSn1+LH3af5T7lANU6L6kYMBKO+40vvk r5w5pyr1AmFU0LCckT2sNeXQwZ7jR8k/7n0OkK3/bNQMlLx3lukVZ1fjKrB79b6CJUpvTUfg 9uxxRFUmO+cWAjd9vOHT1Y9pgTIAELucjmlmoiMSGpbhdE8HNesdtuTEgZotpT1Q2qY7KV5y 46tK1tjphUw8Ln5dEJpNv6wFYFKpnKsiiHgWAaOuWkpHWScKfNHwdbXOw7kvIOrHV0euKhFa 0j0S2Arb+WjjMSJQ7WpC9rzkq1kcpUtdWnKUC24WyZdZ1ZUX2dW2AAmTI1hFtHw42skGRCXO zOpdA5nOdOrGzIu0D9IQD4+npnpSIL5IW9pwZMkkgoD47pdeekzG/xmnvU7CF6iDBzwuG3CC FPtyZxmwRVoS/YeBgzoyEDTwUJDzNGrkkNKnaUbDpg4TLRSCUUhmDUguj0QCa4n8kYoaAw9S pNzsRQ== In-Reply-To: <10ccbeb0f4bcd7d0a10cc9b9bd12fdc4894f83ee.1746821544.git.jpoimboe@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > +# Build and post-process livepatch module in $KMOD_DIR > +build_patch_module() { > + local makefile="$KMOD_DIR/Kbuild" > + local log="$KMOD_DIR/build.log" > + local cflags=() > + local files=() > + local cmd=() > + > + rm -rf "$KMOD_DIR" > + mkdir -p "$KMOD_DIR" > + > + cp -f "$SRC/scripts/livepatch/init.c" "$KMOD_DIR" > + > + echo "obj-m := $NAME.o" > "$makefile" > + echo -n "$NAME-y := init.o" >> "$makefile" > + > + find "$DIFF_DIR" -type f -name "*.o" | mapfile -t files > + [[ ${#files[@]} -eq 0 ]] && die "no changes detected" > + > + for file in "${files[@]}"; do > + local rel_file="${file#"$DIFF_DIR"/}" > + local kmod_file="$KMOD_DIR/$rel_file" > + local cmd_file > + > + mkdir -p "$(dirname "$kmod_file")" > + cp -f "$file" "$kmod_file" > + > + # Tell kbuild this is a prebuilt object > + cp -f "$file" "${kmod_file}_shipped" > + > + echo -n " $rel_file" >> "$makefile" > + > + cmd_file="$ORIG_DIR/$(dirname "$rel_file")/.$(basename "$rel_file").cmd" > + [[ -e "$cmd_file" ]] && cp -f "$cmd_file" "$(dirname "$kmod_file")" Hi Josh, Should the .cmd file copy come from the reference SRC and not original ORIG directory? cmd_file="$SRC/$(dirname "$rel_file")/.$(basename "$rel_file").cmd" because I don't see any .cmd files in klp-tmp/orig/ FWIW, I only noticed this after backporting the series to centos-stream-10. There, I got this build error: Building original kernel Copying original object files Fixing patches Building patched kernel Copying patched object files Diffing objects vmlinux.o: changed function: cmdline_proc_show Building patch module: livepatch-test.ko <...>/klp-tmp/kmod/.vmlinux.o.cmd: No such file or directory make[2]: *** [scripts/Makefile.modpost:145: <...>/klp-tmp/kmod/Module.symvers] Error 1 make[1]: *** [<...>/Makefile:1936: modpost] Error 2 make: *** [Makefile:236: __sub-make] Error 2 The above edit worked for both your upstream branch and my downstream backport. -- Joe