Re: [PATCH v2] crypto: DRBG - always try to free Jitter RNG instance

Stephan Müller
2020-06-07T13:10:40Z

Am Freitag, 5. Juni 2020, 18:21:49 CEST schrieb Eric Biggers:

Hi Eric,

> To be concrete, I'm suggesting:
>
> if (!IS_ERR_OR_NULL(drbg->jent))
> crypto_free_rng(drbg->jent);
> drbg->jent = NULL;

I currently do not see that this could lead to an issue. But you are right, we
should use defensive programming everywhere.

I will send a v3 shortly.

Thanks.

Ciao
Stephan