WARNING in perf_group_attach

WARNING in perf_group_attach

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit:    0072a0c14d5b Merge tag 'media/v4.20-4' of git://git.kernel..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10e6d12b400000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b9cc5a440391cbfd
dashboard link: https://syzkaller.appspot.com/bug?extid=23fe48cbe532abffa52e
compiler:       gcc (GCC) 8.0.1 20180413 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=135e93eb400000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13189415400000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+23fe48cbe532abffa52e@syzkaller.appspotmail.com

WARNING: CPU: 0 PID: 6607 at kernel/events/core.c:1833  
perf_group_attach+0x4c1/0x5a0 kernel/events/core.c:1833
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 6607 Comm: syz-executor062 Not tainted 4.20.0-rc5+ #141
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:77 [inline]
  dump_stack+0x244/0x39d lib/dump_stack.c:113
  panic+0x2ad/0x55c kernel/panic.c:188
  __warn.cold.8+0x20/0x45 kernel/panic.c:540
  report_bug+0x254/0x2d0 lib/bug.c:186
  fixup_bug arch/x86/kernel/traps.c:178 [inline]
  do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:271
  do_invalid_op+0x36/0x40 arch/x86/kernel/traps.c:290
  invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:969
RIP: 0010:perf_group_attach+0x4c1/0x5a0 kernel/events/core.c:1833
Code: 8d 7c 24 10 48 89 f8 48 c1 e8 03 42 80 3c 30 00 75 51 4d 8b 64 24 10  
49 83 ec 10 4c 39 e3 75 d2 e9 f8 fe ff ff e8 7f ad e9 ff <0f> 0b e9 e0 fc  
ff ff e8 73 06 2d 00 e9 ea fb ff ff e8 69 06 2d 00
RSP: 0018:ffff8881cbf8f5f8 EFLAGS: 00010093
RAX: ffff8881bb87c440 RBX: ffff8881bb6db240 RCX: ffffffff8195eaa6
RDX: 0000000000000000 RSI: ffffffff8195ee41 RDI: ffff8881bb10e398
RBP: ffff8881cbf8f690 R08: ffff8881bb87c440 R09: 0000000000000006
R10: fffffbfff14a7201 R11: 0000000000000001 R12: ffff8881bb10e180
R13: 1ffff110397f1ec1 R14: ffffe8ffffc13098 R15: 0000000000000000
  add_event_to_ctx kernel/events/core.c:2390 [inline]
  __perf_install_in_context+0x5bd/0xb70 kernel/events/core.c:2531
  remote_function+0x12b/0x1a0 kernel/events/core.c:87
  generic_exec_single+0x379/0x5f0 kernel/smp.c:153
  smp_call_function_single+0x25a/0x660 kernel/smp.c:299
  cpu_function_call kernel/events/core.c:141 [inline]
  perf_install_in_context+0x46c/0x510 kernel/events/core.c:2567
  __do_sys_perf_event_open+0x1fa5/0x3020 kernel/events/core.c:10791
  __se_sys_perf_event_open kernel/events/core.c:10420 [inline]
  __x64_sys_perf_event_open+0xbe/0x150 kernel/events/core.c:10420
  do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
  entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x446619
Code: e8 0c e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7  
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff  
ff 0f 83 7b 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fef7efd3db8 EFLAGS: 00000246 ORIG_RAX: 000000000000012a
RAX: ffffffffffffffda RBX: 00000000006dbc28 RCX: 0000000000446619
RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 0000000020000000
RBP: 00000000006dbc20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000003 R11: 0000000000000246 R12: 00000000006dbc2c
R13: 00007ffca90267df R14: 00007fef7efd49c0 R15: 00000000006dbc20
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with  
syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: WARNING in perf_group_attach

[syzbot]

syzbot has bisected this bug to:

commit 33ea4b24277b06dbc55d7f5772a46f029600255e
Author: Song Liu <songliubraving@fb.com>
Date:   Wed Dec 6 22:45:16 2017 +0000

     perf/core: Implement the 'perf_uprobe' PMU

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1038fecae00000
start commit:   0072a0c1 Merge tag 'media/v4.20-4' of git://git.kernel.org..
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=1238fecae00000
console output: https://syzkaller.appspot.com/x/log.txt?x=1438fecae00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b9cc5a440391cbfd
dashboard link: https://syzkaller.appspot.com/bug?extid=23fe48cbe532abffa52e
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=135e93eb400000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13189415400000

Reported-by: syzbot+23fe48cbe532abffa52e@syzkaller.appspotmail.com
Fixes: 33ea4b24277b ("perf/core: Implement the 'perf_uprobe' PMU")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: WARNING in perf_group_attach

[Song Liu]

> On Nov 22, 2019, at 8:29 AM, syzbot <syzbot+23fe48cbe532abffa52e@syzkaller.appspotmail.com> wrote:
> 
> syzbot has bisected this bug to:
> 
> commit 33ea4b24277b06dbc55d7f5772a46f029600255e
> Author: Song Liu <songliubraving@fb.com>
> Date:   Wed Dec 6 22:45:16 2017 +0000
> 
>    perf/core: Implement the 'perf_uprobe' PMU
> 
> bisection log:  https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_bisect.txt-3Fx-3D1038fecae00000&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=3ABayY9CyfQkmQs0KgB2fcFws0p7utMNa7tcrLE0b4Y&e=start commit:   0072a0c1 Merge tag 'media/v4.20-4' of git://git.kernel.org..
> git tree:       upstream
> final crash:    https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_report.txt-3Fx-3D1238fecae00000&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=CZ1NX6DT4kikiKc9qfHrpHrBGrPBNOzUUwcp-avrDlo&e=console output: https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_log.txt-3Fx-3D1438fecae00000&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=Gbwfq2mU_2xkXjM2LVOht4iV94BqNlAVlldmf99YE2o&e=kernel config:  https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_.config-3Fx-3Db9cc5a440391cbfd&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=80FYgyg5lxOA80Ae-t5h5madX7fI4JOulTaVL6A5OIE&e=dashboard link: https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_bug-3Fextid-3D23fe48cbe532abffa52e&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=CLG4xu3n98RYL4iBP5vb_BVLur-IxZkzQf5KMgJKEBQ&e=syz repro:      https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_repro.syz-3Fx-3D135e93eb400000&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=rE9GDnbBf2V3RMoW8TmNFJxPVfG2W27IzFAQ4534Yok&e=C reproducer:   https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_repro.c-3Fx-3D13189415400000&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=zu43yb0MPn0VZeQKwG-EDUHqYYgHgJhJrRcYp6dl-dE&e=
> Reported-by: syzbot+23fe48cbe532abffa52e@syzkaller.appspotmail.com
> Fixes: 33ea4b24277b ("perf/core: Implement the 'perf_uprobe' PMU")
> 
> For information about bisection process see: https://urldefense.proofpoint.com/v2/url?u=https-3A__goo.gl_tpsmEJ-23bisection&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=twva4o7mjqFOvS4tIPaO-5jjo-XAwT9qjmMqY7gRsLM&s=YWXIJgdau0PZoF8t4mWq-2xQY88lKIzCF0JnR-ZM4Ao&e=


Thanks for the report. I will look into the fix. 

Song

Re: WARNING in perf_group_attach

[syzbot]

syzbot suspects this bug was fixed by commit:

commit 311633b604063a8a5d3fbc74d0565b42df721f68
Author: Cong Wang <xiyou.wangcong@gmail.com>
Date:   Wed Jul 10 06:24:54 2019 +0000

     hsr: switch ->dellink() to ->ndo_uninit()

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1639a42ae00000
start commit:   6fbc7275 Linux 5.2-rc7
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=f6451f0da3d42d53
dashboard link: https://syzkaller.appspot.com/bug?extid=23fe48cbe532abffa52e
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1758795da00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11d2fa1ba00000

If the result looks correct, please mark the bug fixed by replying with:

#syz fix: hsr: switch ->dellink() to ->ndo_uninit()

For information about bisection process see: https://goo.gl/tpsmEJ#bisection