Re: [syzbot] [netfilter?] KASAN: slab-use-after-free Read in ip_skb_dst_mtu

syzbot
2024-03-09T01:32:02Z

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

sbcore: registered new interface driver dln2
[ 8.758756][ T1] usbcore: registered new interface driver pn533_usb
[ 8.766300][ T1] nfcsim 0.2 initialized
[ 8.767501][ T1] usbcore: registered new interface driver port100
[ 8.769021][ T1] usbcore: registered new interface driver nfcmrvl
[ 8.777559][ T1] Loading iSCSI transport class v2.0-870.
[ 8.798614][ T1] virtio_scsi virtio0: 1/0/0 default/read/poll queues
[ 8.809823][ T1] ------------[ cut here ]------------
[ 8.810772][ T1] refcount_t: decrement hit 0; leaking memory.
[ 8.812057][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:31 refcount_warn_saturate+0xfa/0x1d0
[ 8.813796][ T1] Modules linked in:
[ 8.814366][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc7-next-20240308-syzkaller-g8ffc8b1bbd50-dirty #0
[ 8.816583][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 8.821133][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 8.822500][ T1] Code: b2 00 00 00 e8 a7 e3 ec fc 5b 5d c3 cc cc cc cc e8 9b e3 ec fc c6 05 16 be ea 0a 01 90 48 c7 c7 60 ab 1e 8c e8 17 b9 af fc 90 <0f> 0b 90 90 eb d9 e8 7b e3 ec fc c6 05 f3 bd ea 0a 01 90 48 c7 c7
[ 8.825856][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 8.826703][ T1] RAX: f37710c6fdfb4400 RBX: ffff8881472e256c RCX: ffff8880166d8000
[ 8.828285][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 8.829591][ T1] RBP: 0000000000000004 R08: ffffffff8157d172 R09: fffffbfff1c39614
[ 8.831826][ T1] R10: dffffc0000000000 R11: fffffbfff1c39614 R12: ffffea0000851dc0
[ 8.833304][ T1] R13: ffffea0000851dc8 R14: 1ffffd400010a3b9 R15: 0000000000000000
[ 8.834541][ T1] FS: 0000000000000000(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
[ 8.836062][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 8.837282][ T1] CR2: ffff88823ffff000 CR3: 000000000e132000 CR4: 00000000003506f0
[ 8.839016][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 8.840940][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 8.842607][ T1] Call Trace:
[ 8.843365][ T1] <TASK>
[ 8.843855][ T1] ? __warn+0x163/0x4b0
[ 8.844635][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.846182][ T1] ? report_bug+0x2b3/0x500
[ 8.847620][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.848738][ T1] ? handle_bug+0x3e/0x70
[ 8.849656][ T1] ? exc_invalid_op+0x1a/0x50
[ 8.851094][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 8.852147][ T1] ? __warn_printk+0x292/0x360
[ 8.853031][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.853917][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 8.854722][ T1] __free_pages_ok+0xc42/0xd70
[ 8.855417][ T1] make_alloc_exact+0xa3/0xf0
[ 8.856076][ T1] vring_alloc_queue_split+0x20a/0x600
[ 8.856911][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 8.857795][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 8.858505][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 8.859456][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 8.860939][ T1] ? really_probe+0x29e/0xc50
[ 8.862246][ T1] ? driver_probe_device+0x50/0x430
[ 8.863277][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 8.864213][ T1] ? ret_from_fork+0x4b/0x80
[ 8.864929][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 8.865989][ T1] vring_create_virtqueue+0xca/0x110
[ 8.867234][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.868277][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.869236][ T1] setup_vq+0xe9/0x2d0
[ 8.869960][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.870658][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.871551][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.872622][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.873697][ T1] vp_setup_vq+0xbf/0x330
[ 8.874450][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 8.875667][ T1] ? ioread16+0x2f/0x90
[ 8.876346][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.877234][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 8.878105][ T1] vp_find_vqs+0x4c/0x4e0
[ 8.879082][ T1] virtscsi_init+0x8db/0xd00
[ 8.880685][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 8.882808][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 8.883806][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 8.885078][ T1] ? vp_get+0xfd/0x140
[ 8.886204][ T1] virtscsi_probe+0x3ea/0xf60
[ 8.887594][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 8.888451][ T1] ? kernfs_add_one+0x156/0x8b0
[ 8.889293][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 8.890605][ T1] ? virtio_features_ok+0x10c/0x270
[ 8.891781][ T1] virtio_dev_probe+0x991/0xaf0
[ 8.893220][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.894284][ T1] really_probe+0x29e/0xc50
[ 8.895013][ T1] __driver_probe_device+0x1a2/0x3e0
[ 8.896119][ T1] driver_probe_device+0x50/0x430
[ 8.897148][ T1] __driver_attach+0x45f/0x710
[ 8.898234][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.899310][ T1] bus_for_each_dev+0x239/0x2b0
[ 8.900535][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.902736][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.903955][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 8.905323][ T1] bus_add_driver+0x347/0x620
[ 8.906778][ T1] driver_register+0x23a/0x320
[ 8.907994][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.909607][ T1] virtio_scsi_init+0x65/0xe0
[ 8.910777][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.912214][ T1] do_one_initcall+0x238/0x830
[ 8.913543][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.914984][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.916819][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.917969][ T1] ? __pfx_parse_args+0x10/0x10
[ 8.919098][ T1] ? do_initcalls+0x1c/0x80
[ 8.919909][ T1] ? rcu_is_watching+0x15/0xb0
[ 8.920983][ T1] do_initcall_level+0x157/0x210
[ 8.922112][ T1] do_initcalls+0x3f/0x80
[ 8.923091][ T1] kernel_init_freeable+0x435/0x5d0
[ 8.924601][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 8.926232][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.928164][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.929328][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.930562][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.931742][ T1] kernel_init+0x1d/0x2b0
[ 8.932479][ T1] ret_from_fork+0x4b/0x80
[ 8.933443][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.934667][ T1] ret_from_fork_asm+0x1a/0x30
[ 8.936510][ T1] </TASK>
[ 8.937427][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 8.939173][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc7-next-20240308-syzkaller-g8ffc8b1bbd50-dirty #0
[ 8.942655][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 8.945439][ T1] Call Trace:
[ 8.946072][ T1] <TASK>
[ 8.946896][ T1] dump_stack_lvl+0x241/0x360
[ 8.947396][ T1] ? __pfx_dump_stack_lvl+0x10/0x10
[ 8.947396][ T1] ? __pfx__printk+0x10/0x10
[ 8.947396][ T1] ? _printk+0xd5/0x120
[ 8.947396][ T1] ? vscnprintf+0x5d/0x90
[ 8.947396][ T1] panic+0x349/0x860
[ 8.947396][ T1] ? __warn+0x172/0x4b0
[ 8.947396][ T1] ? __pfx_panic+0x10/0x10
[ 8.957077][ T1] ? show_trace_log_lvl+0x4e6/0x520
[ 8.957077][ T1] ? ret_from_fork_asm+0x1a/0x30
[ 8.957077][ T1] __warn+0x31e/0x4b0
[ 8.957077][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.957077][ T1] report_bug+0x2b3/0x500
[ 8.957077][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.957077][ T1] handle_bug+0x3e/0x70
[ 8.967207][ T1] exc_invalid_op+0x1a/0x50
[ 8.967207][ T1] asm_exc_invalid_op+0x1a/0x20
[ 8.967207][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 8.967207][ T1] Code: b2 00 00 00 e8 a7 e3 ec fc 5b 5d c3 cc cc cc cc e8 9b e3 ec fc c6 05 16 be ea 0a 01 90 48 c7 c7 60 ab 1e 8c e8 17 b9 af fc 90 <0f> 0b 90 90 eb d9 e8 7b e3 ec fc c6 05 f3 bd ea 0a 01 90 48 c7 c7
[ 8.977080][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 8.977080][ T1] RAX: f37710c6fdfb4400 RBX: ffff8881472e256c RCX: ffff8880166d8000
[ 8.977080][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 8.977080][ T1] RBP: 0000000000000004 R08: ffffffff8157d172 R09: fffffbfff1c39614
[ 8.977080][ T1] R10: dffffc0000000000 R11: fffffbfff1c39614 R12: ffffea0000851dc0
[ 8.977080][ T1] R13: ffffea0000851dc8 R14: 1ffffd400010a3b9 R15: 0000000000000000
[ 8.987200][ T1] ? __warn_printk+0x292/0x360
[ 8.987200][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 8.987200][ T1] __free_pages_ok+0xc42/0xd70
[ 8.987200][ T1] make_alloc_exact+0xa3/0xf0
[ 8.987200][ T1] vring_alloc_queue_split+0x20a/0x600
[ 8.987200][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 8.987200][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 8.987200][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 8.987200][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 8.997075][ T1] ? really_probe+0x29e/0xc50
[ 8.997075][ T1] ? driver_probe_device+0x50/0x430
[ 8.997075][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 8.997075][ T1] ? ret_from_fork+0x4b/0x80
[ 8.997075][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 8.997075][ T1] vring_create_virtqueue+0xca/0x110
[ 8.997075][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.997075][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.997075][ T1] setup_vq+0xe9/0x2d0
[ 8.997075][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.007200][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.007200][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.007200][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.007200][ T1] vp_setup_vq+0xbf/0x330
[ 9.007200][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 9.007200][ T1] ? ioread16+0x2f/0x90
[ 9.007200][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.007200][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 9.007200][ T1] vp_find_vqs+0x4c/0x4e0
[ 9.017081][ T1] virtscsi_init+0x8db/0xd00
[ 9.017081][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 9.017081][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 9.017081][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 9.017081][ T1] ? vp_get+0xfd/0x140
[ 9.017081][ T1] virtscsi_probe+0x3ea/0xf60
[ 9.017081][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 9.027229][ T1] ? kernfs_add_one+0x156/0x8b0
[ 9.027229][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 9.027229][ T1] ? virtio_features_ok+0x10c/0x270
[ 9.027229][ T1] virtio_dev_probe+0x991/0xaf0
[ 9.027229][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 9.027229][ T1] really_probe+0x29e/0xc50
[ 9.027229][ T1] __driver_probe_device+0x1a2/0x3e0
[ 9.037078][ T1] driver_probe_device+0x50/0x430
[ 9.037078][ T1] __driver_attach+0x45f/0x710
[ 9.037078][ T1] ? __pfx___driver_attach+0x10/0x10
[ 9.037078][ T1] bus_for_each_dev+0x239/0x2b0
[ 9.037078][ T1] ? __pfx___driver_attach+0x10/0x10
[ 9.037078][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 9.037078][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 9.037078][ T1] bus_add_driver+0x347/0x620
[ 9.037078][ T1] driver_register+0x23a/0x320
[ 9.047213][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 9.047213][ T1] virtio_scsi_init+0x65/0xe0
[ 9.047213][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 9.047213][ T1] do_one_initcall+0x238/0x830
[ 9.047213][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 9.047213][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 9.047213][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 9.047213][ T1] ? __pfx_parse_args+0x10/0x10
[ 9.057088][ T1] ? do_initcalls+0x1c/0x80
[ 9.057088][ T1] ? rcu_is_watching+0x15/0xb0
[ 9.057088][ T1] do_initcall_level+0x157/0x210
[ 9.057088][ T1] do_initcalls+0x3f/0x80
[ 9.057088][ T1] kernel_init_freeable+0x435/0x5d0
[ 9.057088][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 9.057088][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 9.057088][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.067209][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.067209][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.067209][ T1] kernel_init+0x1d/0x2b0
[ 9.067209][ T1] ret_from_fork+0x4b/0x80
[ 9.067209][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.067209][ T1] ret_from_fork_asm+0x1a/0x30
[ 9.067209][ T1] </TASK>
[ 9.067209][ T1] Kernel Offset: disabled
[ 9.067209][ T1] Rebooting in 86400 seconds..

syzkaller build log:
go env (err=<nil>)
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/syzkaller/.cache/go-build'
GOENV='/syzkaller/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/syzkaller/jobs-2/linux/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/syzkaller/jobs-2/linux/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/syzkaller/jobs-2/linux/gopath/src/github.com/google/syzkaller/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3507553695=/tmp/go-build -gno-record-gcc-switches'

git status (err=<nil>)
HEAD detached at 352ab9047
nothing to commit, working tree clean

tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=352ab9047be19ed1d8367b9113b7bde280c90124 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240228-135607'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=352ab9047be19ed1d8367b9113b7bde280c90124 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240228-135607'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=352ab9047be19ed1d8367b9113b7bde280c90124 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240228-135607'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -Wno-unused-but-set-variable -Wno-unused-command-line-argument -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"352ab9047be19ed1d8367b9113b7bde280c90124\"

Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=142c94da180000

Tested on:

commit: 8ffc8b1b Add linux-next specific files for 20240308
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
kernel config: https://syzkaller.appspot.com/x/.config?x=9f21b6530bb238b3
dashboard link: https://syzkaller.appspot.com/bug?extid=e5167d7144a62715044c
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=148a3de1180000