From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1362C4332F for ; Mon, 13 Nov 2023 12:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjKMMrM (ORCPT ); Mon, 13 Nov 2023 07:47:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjKMMrL (ORCPT ); Mon, 13 Nov 2023 07:47:11 -0500 Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C5BD79 for ; Mon, 13 Nov 2023 04:47:07 -0800 (PST) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-6c334d2fd40so5825417b3a.2 for ; Mon, 13 Nov 2023 04:47:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699879627; x=1700484427; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2YhNtK4hSUkgQRF+Wp7nwvqD4QStVbTqJ2Vq4CWalls=; b=jOwLpWXnDljHAkP6pZOyDBJWFElAh2nTFIxajEx2qRwn/E8+WmIjc6dkc1jnu7RvdD ovhXElJgCYVaTie9J3SWhlzB1P+Y0ME9MB8wowOQmOEZRrT+rPVwUtQ0EI89lOWcRWjy lxkkh8Lvxlf/fDTbgXf3TwWecVdmu4UxqSoK/7wqrgKgajpL/Phwwgtqh0yd8bFDkicd n7Syid0VQ2rFlb0hmdyo+efNygyg11HvBe61jcvxPXDNLG8Lnupk4DHox0mCYznYy5Aq 52OtC0fEA9x/pDqfWKHXg0shnC4GelE5WiP83Fp4/4Tuyuo19LIH4489lkaeSZ7PLkkT u0Og== X-Gm-Message-State: AOJu0YwT0hpdxuv6kuwP1haok5J1Wbd2xddnEvB8aQLF9mUS7j9R1H9Z A2OreJ14kJLCd3zuDzEfWD5M90OmL0Me1y/jaeqKo5LlRy7w X-Google-Smtp-Source: AGHT+IFn5yKFuYVKCCQBfL5SwOoQ3Ms+yXx/weJ8ebkrpmUlNl9SZX6/SO7ftS4BkoXodndc7bAP2MYpEsdhwLSsxTR8MhtDY7GA MIME-Version: 1.0 X-Received: by 2002:a05:6a00:2809:b0:68f:f868:a4fb with SMTP id bl9-20020a056a00280900b0068ff868a4fbmr1602088pfb.5.1699879627221; Mon, 13 Nov 2023 04:47:07 -0800 (PST) Date: Mon, 13 Nov 2023 04:47:07 -0800 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000005770ed060a081130@google.com> Subject: Re: [syzbot] [btrfs?] memory leak in add_tree_block From: syzbot To: jose.pekkarinen@foxhound.fi, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: memory leak in add_tree_block BUG: memory leak unreferenced object 0xffff88811b83f780 (size 64): comm "syz-executor.0", pid 5490, jiffies 4294945002 (age 8.100s) hex dump (first 32 bytes): 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098 [] kmalloc include/linux/slab.h:600 [inline] [] add_tree_block+0x39/0x240 fs/btrfs/ref-verify.c:319 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:524 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:576 [inline] [] btrfs_build_ref_tree+0x566/0x8c0 fs/btrfs/ref-verify.c:1009 [] open_ctree+0x18c5/0x2370 fs/btrfs/disk-io.c:3523 [] btrfs_fill_super fs/btrfs/super.c:1117 [inline] [] btrfs_mount_root+0x5a1/0x750 fs/btrfs/super.c:1478 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] fc_mount fs/namespace.c:1114 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1144 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1131 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1538 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] do_new_mount fs/namespace.c:3337 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3664 [] do_mount fs/namespace.c:3677 [inline] [] __do_sys_mount fs/namespace.c:3886 [inline] [] __se_sys_mount fs/namespace.c:3863 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3863 [] do_syscall_x64 arch/x86/entry/common.c:51 [inline] [] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 [] entry_SYSCALL_64_after_hwframe+0x63/0x6b BUG: memory leak unreferenced object 0xffff88811b83fe40 (size 64): comm "syz-executor.0", pid 5490, jiffies 4294945002 (age 8.100s) hex dump (first 32 bytes): 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................ 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098 [] kmalloc include/linux/slab.h:600 [inline] [] kzalloc include/linux/slab.h:721 [inline] [] add_block_entry+0x35/0x320 fs/btrfs/ref-verify.c:270 [] add_tree_block+0x96/0x240 fs/btrfs/ref-verify.c:332 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:524 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:576 [inline] [] btrfs_build_ref_tree+0x566/0x8c0 fs/btrfs/ref-verify.c:1009 [] open_ctree+0x18c5/0x2370 fs/btrfs/disk-io.c:3523 [] btrfs_fill_super fs/btrfs/super.c:1117 [inline] [] btrfs_mount_root+0x5a1/0x750 fs/btrfs/super.c:1478 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] fc_mount fs/namespace.c:1114 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1144 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1131 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1538 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] do_new_mount fs/namespace.c:3337 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3664 [] do_mount fs/namespace.c:3677 [inline] [] __do_sys_mount fs/namespace.c:3886 [inline] [] __se_sys_mount fs/namespace.c:3863 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3863 [] do_syscall_x64 arch/x86/entry/common.c:51 [inline] [] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 BUG: memory leak unreferenced object 0xffff88811acefb40 (size 96): comm "syz-executor.0", pid 5490, jiffies 4294945002 (age 8.100s) hex dump (first 32 bytes): 00 10 10 00 00 00 00 00 00 10 00 00 00 00 00 00 ................ 01 00 00 00 00 00 00 00 01 00 00 00 01 00 00 00 ................ backtrace: [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098 [] kmalloc include/linux/slab.h:600 [inline] [] kzalloc include/linux/slab.h:721 [inline] [] add_block_entry+0x4e/0x320 fs/btrfs/ref-verify.c:271 [] add_tree_block+0x96/0x240 fs/btrfs/ref-verify.c:332 [] process_extent_item fs/btrfs/ref-verify.c:474 [inline] [] process_leaf fs/btrfs/ref-verify.c:524 [inline] [] walk_down_tree fs/btrfs/ref-verify.c:576 [inline] [] btrfs_build_ref_tree+0x566/0x8c0 fs/btrfs/ref-verify.c:1009 [] open_ctree+0x18c5/0x2370 fs/btrfs/disk-io.c:3523 [] btrfs_fill_super fs/btrfs/super.c:1117 [inline] [] btrfs_mount_root+0x5a1/0x750 fs/btrfs/super.c:1478 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] fc_mount fs/namespace.c:1114 [inline] [] vfs_kern_mount.part.0+0xcb/0x110 fs/namespace.c:1144 [] vfs_kern_mount+0x3f/0x60 fs/namespace.c:1131 [] btrfs_mount+0x1e2/0x660 fs/btrfs/super.c:1538 [] legacy_get_tree+0x29/0x80 fs/fs_context.c:662 [] vfs_get_tree+0x2a/0x130 fs/super.c:1768 [] do_new_mount fs/namespace.c:3337 [inline] [] path_mount+0xc8f/0x10d0 fs/namespace.c:3664 [] do_mount fs/namespace.c:3677 [inline] [] __do_sys_mount fs/namespace.c:3886 [inline] [] __se_sys_mount fs/namespace.c:3863 [inline] [] __x64_sys_mount+0x1a1/0x1f0 fs/namespace.c:3863 [] do_syscall_x64 arch/x86/entry/common.c:51 [inline] [] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 Tested on: commit: 5a6a09e9 Merge tag 'cgroup-for-6.7' of git://git.kerne.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git console output: https://syzkaller.appspot.com/x/log.txt?x=161484b8e80000 kernel config: https://syzkaller.appspot.com/x/.config?x=492c9379bc08e464 dashboard link: https://syzkaller.appspot.com/bug?extid=be14ed7728594dc8bd42 compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 Note: no patches were applied.