public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+34ad5fab48f7bf510349@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [syzbot] Re: [PATCH] net: Fix kernel-infoleak in __skb_datagram_iter (2)
Date: Sat, 17 Feb 2024 04:40:49 -0800	[thread overview]
Message-ID: <00000000000090fef10611932b01@google.com> (raw)
In-Reply-To: <0000000000002cf4690610660f71@google.com>

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.

***

Subject: Re: [PATCH] net: Fix kernel-infoleak in __skb_datagram_iter (2)
Author: ryasuoka@redhat.com

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 2dde34c29203..540df9a6a9b3 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2542,6 +2542,11 @@ static inline unsigned char
*skb_tail_pointer(const struct sk_buff *skb)
        return skb->head + skb->tail;
 }

+static inline unsigned int skb_tail_offset(const struct sk_buff *skb)
+{
+       return skb->tail;
+}
+
 static inline void skb_reset_tail_pointer(struct sk_buff *skb)
 {
        skb->tail = skb->data - skb->head;
@@ -2559,6 +2564,11 @@ static inline unsigned char
*skb_tail_pointer(const struct sk_buff *skb)
        return skb->tail;
 }

+static inline unsigned int skb_tail_offset(const struct sk_buff *skb)
+{
+       return skb->tail - skb->head;
+}
+
 static inline void skb_reset_tail_pointer(struct sk_buff *skb)
 {
        skb->tail = skb->data;
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 9c962347cf85..d1b8e02c7e44 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -167,7 +167,7 @@ static inline u32 netlink_group_mask(u32 group)
 static struct sk_buff *netlink_to_full_skb(const struct sk_buff *skb,
                                           gfp_t gfp_mask)
 {
-       unsigned int len = skb_end_offset(skb);
+       unsigned int len = skb_tail_offset(skb);
        struct sk_buff *new;

        new = alloc_skb(len, gfp_mask);


  parent reply	other threads:[~2024-02-17 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 13:26 [syzbot] [net?] KMSAN: kernel-infoleak in __skb_datagram_iter (2) syzbot
2024-02-15  9:27 ` [syzbot] [PATCH] net: Fix " syzbot
2024-02-17 12:40 ` syzbot [this message]
2024-02-17 14:51 ` [syzbot] " syzbot
2024-02-20  2:42 ` [syzbot] [PATCH net] netlink: Fix kernel-infoleak in __skb_datagram_iter() syzbot
2024-02-20  4:49 ` syzbot
2024-02-20  7:16 ` [syzbot] Test for 34ad5fab48f7bf510349 syzbot
2024-02-20 12:00 ` [syzbot] [PATCH net] netlink: Fix kernel-infoleak in __skb_datagram_iter() syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00000000000090fef10611932b01@google.com \
    --to=syzbot+34ad5fab48f7bf510349@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox