From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C116AC0 for ; Mon, 15 Jul 2024 09:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721035384; cv=none; b=Fu3CWV4JS9+Ibf07DMdDjdnqI7NcVhWa2DcqznPG9l//h3DahfVgX2/uHaFkIiurjiO2qMg5ck0SG5MVH6DJDlpnWeAAYugsRP15PUMGA37W/Q6I8HZ5vBUCwi1ucZPvN/OYJUsLF3PEe6manAZTAiV35ovDmvhvOZL6xuo748o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721035384; c=relaxed/simple; bh=TD0TIy4QY9exIdCwE+bxKz3effnGVaZz+yTQpflIScU=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=Q8XieErndsJTYo07LMzEtft2vhwXq2fgSmoW1eR9czyrxbzM4SLca491uJHRduojt6agbGDctspxpff7hfqaFaglf2lh5xcCpl7RGrbJr44/XI+xnz5983IJTuetBLDtvWQSetN8GwKgZEN8Tb3RMd6zqiAJrtFe21vwisSvG9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-81257dec573so120040339f.0 for ; Mon, 15 Jul 2024 02:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721035382; x=1721640182; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0zvI+ZqpnbL8L2ENSBv/O2b+JVKlsLr1hT/P9T8Bw0U=; b=QXBvsKxZN+TvjaYncHflQJo2HAc+LFI4Z21B24qBG0cC8uPCB2gw4wcK3EMCjXRDPD MlydQ7Hcv3CdwL+1qJbaDFKihn+3gVmMzDa6VldrmkWr4MJp/1tItOGyBmYdWjA3jh/A KQ6cH1gtNC+cIsi7QcawhT1sHB8ZRCL1yH4BcFSP32ttq58ITHrzcD2NAu8zrMAM9phm a+ZkcF9UxQnEn/lMV4u/Ch30W6O81LiV087efA1AZ7I6o5Kk5hTGvcmNKh5Rtj7fHDPB mrRx4B03+bZAGuUgvFXGnKme0wSerAkGKPARyfTf81Uma/cp+3VS3kD8cw7W1mE102DA LQjg== X-Forwarded-Encrypted: i=1; AJvYcCVRxzucys2WNfj4Sypf6YqgNwKJqau2PokA6BG/ySiz/T36B4Gq0YrbXsznAjjlKpf9fn5Uly44V12hcIlK3CXzv7k3nWPWx46n/K// X-Gm-Message-State: AOJu0YyKcDPOhmi8t0NV74ZdF/NEhpMA11aKTpHAQCFLWUf/L5OwCdBo dnzho70RNjpgnuWsWjYorKzrkD9rFgjz6cdCBqt4VWinbV1ZetGT984+7dI1birU1wOhAoJIxT6 +NZ/WuJcA8dXr5UV5GT3vYCygw6BlSKWl1fj6YbCVt6A/fJrbZNKbxI8= X-Google-Smtp-Source: AGHT+IE7AR+RvofXMZckCZNXkolJmNl3Zp1YzfzbpZBM65MG3nCxAiCjR/8X+y56c99R12XYQQ+yBox98oTVl60gceW39sz+rzpZ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6638:8621:b0:4c0:9a3e:c260 with SMTP id 8926c6da1cb9f-4c0b24a8ac7mr1416371173.0.1721035382301; Mon, 15 Jul 2024 02:23:02 -0700 (PDT) Date: Mon, 15 Jul 2024 02:23:02 -0700 In-Reply-To: <6da7776f-51a3-4d3c-83e9-e3b710eef541@paragon-software.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000009bb16d061d45c693@google.com> Subject: Re: [syzbot] [ntfs3?] general protection fault in run_is_mapped_full From: syzbot To: almaz.alexandrovich@paragon-software.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: general protection fault in run_is_mapped_full loop0: detected capacity change from 0 to 4096 ntfs3: loop0: Different NTFS sector size (1024) and media sector size (512). Oops: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 0 PID: 5940 Comm: syz.0.15 Not tainted 6.10.0-rc1-syzkaller-00033-g2cbbd9682025 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 RIP: 0010:run_lookup fs/ntfs3/run.c:39 [inline] RIP: 0010:run_is_mapped_full+0x35/0x480 fs/ntfs3/run.c:173 Code: 41 54 53 48 83 ec 30 41 89 d4 41 89 f6 49 89 fd 49 bf 00 00 00 00 00 fc ff df e8 a6 e5 a7 fe 49 8d 5d 08 48 89 d8 48 c1 e8 03 <42> 80 3c 38 00 74 08 48 89 df e8 dc 9c 0d ff 48 8b 1b 31 ff 48 89 RSP: 0018:ffffc90003717758 EFLAGS: 00010202 RAX: 0000000000000001 RBX: 0000000000000008 RCX: ffff88802d59da00 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffffc90003717b18 R08: ffffffff82e4ba01 R09: ffffffff82ee0929 R10: 0000000000000002 R11: ffff88802d59da00 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: dffffc0000000000 FS: 00007f2c635ab6c0(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f2c629000a0 CR3: 00000000295ba000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: attr_load_runs fs/ntfs3/attrib.c:69 [inline] attr_set_size+0xfd6/0x4290 fs/ntfs3/attrib.c:502 ntfs_create_inode+0x252d/0x37f0 fs/ntfs3/inode.c:1719 ntfs_symlink+0xde/0x110 fs/ntfs3/namei.c:199 vfs_symlink+0x137/0x2e0 fs/namei.c:4489 do_symlinkat+0x222/0x3a0 fs/namei.c:4515 __do_sys_symlinkat fs/namei.c:4531 [inline] __se_sys_symlinkat fs/namei.c:4528 [inline] __x64_sys_symlinkat+0x99/0xb0 fs/namei.c:4528 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f2c62775bd9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2c635ab048 EFLAGS: 00000246 ORIG_RAX: 000000000000010a RAX: ffffffffffffffda RBX: 00007f2c62903f60 RCX: 00007f2c62775bd9 RDX: 0000000020000440 RSI: 0000000000000006 RDI: 0000000020000340 RBP: 00007f2c627e4e60 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f2c62903f60 R15: 00007fffd6281a78 Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:run_lookup fs/ntfs3/run.c:39 [inline] RIP: 0010:run_is_mapped_full+0x35/0x480 fs/ntfs3/run.c:173 Code: 41 54 53 48 83 ec 30 41 89 d4 41 89 f6 49 89 fd 49 bf 00 00 00 00 00 fc ff df e8 a6 e5 a7 fe 49 8d 5d 08 48 89 d8 48 c1 e8 03 <42> 80 3c 38 00 74 08 48 89 df e8 dc 9c 0d ff 48 8b 1b 31 ff 48 89 RSP: 0018:ffffc90003717758 EFLAGS: 00010202 RAX: 0000000000000001 RBX: 0000000000000008 RCX: ffff88802d59da00 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffffc90003717b18 R08: ffffffff82e4ba01 R09: ffffffff82ee0929 R10: 0000000000000002 R11: ffff88802d59da00 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: dffffc0000000000 FS: 00007f2c635ab6c0(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fc3e51faff8 CR3: 00000000295ba000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 ---------------- Code disassembly (best guess): 0: 41 54 push %r12 2: 53 push %rbx 3: 48 83 ec 30 sub $0x30,%rsp 7: 41 89 d4 mov %edx,%r12d a: 41 89 f6 mov %esi,%r14d d: 49 89 fd mov %rdi,%r13 10: 49 bf 00 00 00 00 00 movabs $0xdffffc0000000000,%r15 17: fc ff df 1a: e8 a6 e5 a7 fe call 0xfea7e5c5 1f: 49 8d 5d 08 lea 0x8(%r13),%rbx 23: 48 89 d8 mov %rbx,%rax 26: 48 c1 e8 03 shr $0x3,%rax * 2a: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1) <-- trapping instruction 2f: 74 08 je 0x39 31: 48 89 df mov %rbx,%rdi 34: e8 dc 9c 0d ff call 0xff0d9d15 39: 48 8b 1b mov (%rbx),%rbx 3c: 31 ff xor %edi,%edi 3e: 48 rex.W 3f: 89 .byte 0x89 Tested on: commit: 2cbbd968 fs/ntfs3: Missed error return git tree: https://github.com/Paragon-Software-Group/linux-ntfs3.git console output: https://syzkaller.appspot.com/x/log.txt?x=146eab85980000 kernel config: https://syzkaller.appspot.com/x/.config?x=2f1c94a15f7c9744 dashboard link: https://syzkaller.appspot.com/bug?extid=9af29acd8f27fbce94bc compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 Note: no patches were applied.