* Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
@ 2024-07-26 18:36 ` syzbot
2024-07-30 11:23 ` [syzbot] " syzbot
` (8 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-26 18:36 UTC (permalink / raw)
To: davem, edumazet, jiri, kuba, linux-kernel, netdev, pabeni,
syzkaller-bugs
syzbot has found a reproducer for the following issue on:
HEAD commit: 1722389b0d86 Merge tag 'net-6.11-rc1' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11a8dabd980000
kernel config: https://syzkaller.appspot.com/x/.config?x=381b8eb3d35e3ad9
dashboard link: https://syzkaller.appspot.com/bug?extid=b668da2bc4cb9670bf58
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10e99275980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137c299d980000
Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-1722389b.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3ad0b42d0812/vmlinux-1722389b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/67a851e0e5f8/bzImage-1722389b.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b668da2bc4cb9670bf58@syzkaller.appspotmail.com
netlink: 'syz-executor122': attribute type 10 has an invalid length.
dummy0: left promiscuous mode
dummy0: entered promiscuous mode
============================================
WARNING: possible recursive locking detected
6.10.0-syzkaller-12562-g1722389b0d86 #0 Not tainted
--------------------------------------------
syz-executor122/5360 is trying to acquire lock:
ffff88802c258d40 (team->team_lock_key){+.+.}-{3:3}, at: team_port_change_check drivers/net/team/team_core.c:2950 [inline]
ffff88802c258d40 (team->team_lock_key){+.+.}-{3:3}, at: team_device_event+0x2c7/0x770 drivers/net/team/team_core.c:2973
but task is already holding lock:
ffff88802c258d40 (team->team_lock_key){+.+.}-{3:3}, at: team_add_slave+0x9c/0x20e0 drivers/net/team/team_core.c:1975
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(team->team_lock_key);
lock(team->team_lock_key);
*** DEADLOCK ***
May be due to missing lock nesting notation
2 locks held by syz-executor122/5360:
#0: ffffffff8fa1e9a8 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:79 [inline]
#0: ffffffff8fa1e9a8 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x372/0xea0 net/core/rtnetlink.c:6644
#1: ffff88802c258d40 (team->team_lock_key){+.+.}-{3:3}, at: team_add_slave+0x9c/0x20e0 drivers/net/team/team_core.c:1975
stack backtrace:
CPU: 0 UID: 0 PID: 5360 Comm: syz-executor122 Not tainted 6.10.0-syzkaller-12562-g1722389b0d86 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:93 [inline]
dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:119
check_deadlock kernel/locking/lockdep.c:3061 [inline]
validate_chain kernel/locking/lockdep.c:3855 [inline]
__lock_acquire+0x2167/0x3cb0 kernel/locking/lockdep.c:5142
lock_acquire kernel/locking/lockdep.c:5759 [inline]
lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5724
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
team_port_change_check drivers/net/team/team_core.c:2950 [inline]
team_device_event+0x2c7/0x770 drivers/net/team/team_core.c:2973
notifier_call_chain+0xb9/0x410 kernel/notifier.c:93
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1994
call_netdevice_notifiers_extack net/core/dev.c:2032 [inline]
call_netdevice_notifiers net/core/dev.c:2046 [inline]
__dev_notify_flags+0x12d/0x2e0 net/core/dev.c:8876
dev_change_flags+0x10c/0x160 net/core/dev.c:8914
vlan_device_event+0xdfc/0x2120 net/8021q/vlan.c:468
notifier_call_chain+0xb9/0x410 kernel/notifier.c:93
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1994
call_netdevice_notifiers_extack net/core/dev.c:2032 [inline]
call_netdevice_notifiers net/core/dev.c:2046 [inline]
dev_open net/core/dev.c:1515 [inline]
dev_open+0x144/0x160 net/core/dev.c:1503
team_port_add drivers/net/team/team_core.c:1216 [inline]
team_add_slave+0xacd/0x20e0 drivers/net/team/team_core.c:1976
do_set_master+0x1bc/0x230 net/core/rtnetlink.c:2701
do_setlink+0xcaf/0x3ff0 net/core/rtnetlink.c:2907
__rtnl_newlink+0xc35/0x1960 net/core/rtnetlink.c:3696
rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3743
rtnetlink_rcv_msg+0x3c7/0xea0 net/core/rtnetlink.c:6647
netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2550
netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
netlink_unicast+0x544/0x830 net/netlink/af_netlink.c:1357
netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1901
sock_sendmsg_nosec net/socket.c:730 [inline]
__sock_sendmsg net/socket.c:745 [inline]
____sys_sendmsg+0xab5/0xc90 net/socket.c:2597
___sys_sendmsg+0x135/0x1e0 net/socket.c:2651
__sys_sendmsg+0x117/0x1f0 net/socket.c:2680
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f424ca7e7b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 31 1a 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd8c496978 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f424ca7e7b9
RDX: 0000000000000000 RSI: 0000000020000600 RDI: 0000000000000012
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000001
R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 00007ffd8c4969a0
</TASK>
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
2024-07-26 18:36 ` syzbot
@ 2024-07-30 11:23 ` syzbot
2024-07-30 12:02 ` syzbot
` (7 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-30 11:23 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
2024-07-26 18:36 ` syzbot
2024-07-30 11:23 ` [syzbot] " syzbot
@ 2024-07-30 12:02 ` syzbot
2024-07-30 12:41 ` syzbot
` (6 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-30 12:02 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/team/team_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index ab1935a4aa2c..056889eff6b1 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -2947,7 +2947,7 @@ static void team_port_change_check(struct team_port *port, bool linkup)
{
struct team *team = port->team;
- mutex_lock(&team->lock);
+ mutex_lock_nested(&team->lock, 1);
__team_port_change_check(port, linkup);
mutex_unlock(&team->lock);
}
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (2 preceding siblings ...)
2024-07-30 12:02 ` syzbot
@ 2024-07-30 12:41 ` syzbot
2024-07-31 12:18 ` syzbot
` (5 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-30 12:41 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
net/core/rtnetlink.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 87e67194f240..178f5b85fd87 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2896,13 +2896,6 @@ static int do_setlink(const struct sk_buff *skb,
call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
}
- if (ifm->ifi_flags || ifm->ifi_change) {
- err = dev_change_flags(dev, rtnl_dev_combine_flags(dev, ifm),
- extack);
- if (err < 0)
- goto errout;
- }
-
if (tb[IFLA_MASTER]) {
err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]), extack);
if (err)
@@ -2910,6 +2903,13 @@ static int do_setlink(const struct sk_buff *skb,
status |= DO_SETLINK_MODIFIED;
}
+ if (ifm->ifi_flags || ifm->ifi_change) {
+ err = dev_change_flags(dev, rtnl_dev_combine_flags(dev, ifm),
+ extack);
+ if (err < 0)
+ goto errout;
+ }
+
if (tb[IFLA_CARRIER]) {
err = dev_change_carrier(dev, nla_get_u8(tb[IFLA_CARRIER]));
if (err)
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (3 preceding siblings ...)
2024-07-30 12:41 ` syzbot
@ 2024-07-31 12:18 ` syzbot
2024-07-31 13:20 ` syzbot
` (4 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-31 12:18 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/team/team_core.c | 5 ++++-
include/linux/if_team.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index ab1935a4aa2c..963c8311694f 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -1621,6 +1621,7 @@ static int team_init(struct net_device *dev)
team->dev = dev;
team_set_no_mode(team);
team->notifier_ctx = false;
+ team->nested_depth = 1;
team->pcpu_stats = netdev_alloc_pcpu_stats(struct team_pcpu_stats);
if (!team->pcpu_stats)
@@ -2947,8 +2948,10 @@ static void team_port_change_check(struct team_port *port, bool linkup)
{
struct team *team = port->team;
- mutex_lock(&team->lock);
+ mutex_lock_nested(&team->lock, team->nested_depth);
+ team->nested_depth++;
__team_port_change_check(port, linkup);
+ team->nested_depth--;
mutex_unlock(&team->lock);
}
diff --git a/include/linux/if_team.h b/include/linux/if_team.h
index cdc684e04a2f..f8b4e3ed4b44 100644
--- a/include/linux/if_team.h
+++ b/include/linux/if_team.h
@@ -225,6 +225,7 @@ struct team {
} mcast_rejoin;
struct lock_class_key team_lock_key;
long mode_priv[TEAM_MODE_PRIV_LONGS];
+ unsigned int nested_depth;
};
static inline int team_dev_queue_xmit(struct team *team, struct team_port *port,
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (4 preceding siblings ...)
2024-07-31 12:18 ` syzbot
@ 2024-07-31 13:20 ` syzbot
2024-07-31 14:16 ` syzbot
` (3 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-31 13:20 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 87e67194f240..dc9f9c4dcb49 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2903,7 +2903,7 @@ static int do_setlink(const struct sk_buff *skb,
goto errout;
}
- if (tb[IFLA_MASTER]) {
+ if (tb[IFLA_MASTER] && !(dev->flags & IFF_UP)) {
err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]), extack);
if (err)
goto errout;
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (5 preceding siblings ...)
2024-07-31 13:20 ` syzbot
@ 2024-07-31 14:16 ` syzbot
2024-08-01 9:57 ` syzbot
` (2 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-07-31 14:16 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/team/team_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index ab1935a4aa2c..ee595c3c6624 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -1212,8 +1212,9 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
portname);
goto err_port_enter;
}
-
+ mutex_unlock(&team->lock);
err = dev_open(port_dev, extack);
+ mutex_lock(&team->lock);
if (err) {
netdev_dbg(dev, "Device %s opening failed\n",
portname);
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (6 preceding siblings ...)
2024-07-31 14:16 ` syzbot
@ 2024-08-01 9:57 ` syzbot
2024-08-02 14:20 ` syzbot
2025-06-27 13:23 ` Tetsuo Handa
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-08-01 9:57 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/team/team_core.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index ab1935a4aa2c..44c709015007 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -2946,10 +2946,22 @@ static void __team_port_change_port_removed(struct team_port *port)
static void team_port_change_check(struct team_port *port, bool linkup)
{
struct team *team = port->team;
+ bool flag = true;
- mutex_lock(&team->lock);
+ if (mutex_is_locked(&team->lock)){
+ unsigned owner, curr = (unsigned long)current;
+ owner = atomic_long_read(&team->lock.owner);
+ if (owner != curr)
+ mutex_lock(&team->lock);
+ else
+ flag = false;
+ }
+ else{
+ mutex_lock(&team->lock);
+ }
__team_port_change_check(port, linkup);
- mutex_unlock(&team->lock);
+ if (flag)
+ mutex_unlock(&team->lock);
}
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (7 preceding siblings ...)
2024-08-01 9:57 ` syzbot
@ 2024-08-02 14:20 ` syzbot
2025-06-27 13:23 ` Tetsuo Handa
9 siblings, 0 replies; 13+ messages in thread
From: syzbot @ 2024-08-02 14:20 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@gmail.com
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/team/team_core.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index ab1935a4aa2c..f7bab2d2a281 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -1668,7 +1668,6 @@ static void team_uninit(struct net_device *dev)
struct team_port *port;
struct team_port *tmp;
- mutex_lock(&team->lock);
list_for_each_entry_safe(port, tmp, &team->port_list, list)
team_port_del(team, port->dev);
@@ -1677,7 +1676,6 @@ static void team_uninit(struct net_device *dev)
team_mcast_rejoin_fini(team);
team_notify_peers_fini(team);
team_queue_override_fini(team);
- mutex_unlock(&team->lock);
netdev_change_features(dev);
lockdep_unregister_key(&team->team_lock_key);
}
@@ -1818,7 +1816,6 @@ static int team_change_mtu(struct net_device *dev, int new_mtu)
* Alhough this is reader, it's guarded by team lock. It's not possible
* to traverse list in reverse under rcu_read_lock
*/
- mutex_lock(&team->lock);
team->port_mtu_change_allowed = true;
list_for_each_entry(port, &team->port_list, list) {
err = dev_set_mtu(port->dev, new_mtu);
@@ -1829,7 +1826,6 @@ static int team_change_mtu(struct net_device *dev, int new_mtu)
}
}
team->port_mtu_change_allowed = false;
- mutex_unlock(&team->lock);
WRITE_ONCE(dev->mtu, new_mtu);
@@ -1839,7 +1835,6 @@ static int team_change_mtu(struct net_device *dev, int new_mtu)
list_for_each_entry_continue_reverse(port, &team->port_list, list)
dev_set_mtu(port->dev, dev->mtu);
team->port_mtu_change_allowed = false;
- mutex_unlock(&team->lock);
return err;
}
@@ -1893,20 +1888,17 @@ static int team_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)
* Alhough this is reader, it's guarded by team lock. It's not possible
* to traverse list in reverse under rcu_read_lock
*/
- mutex_lock(&team->lock);
list_for_each_entry(port, &team->port_list, list) {
err = vlan_vid_add(port->dev, proto, vid);
if (err)
goto unwind;
}
- mutex_unlock(&team->lock);
return 0;
unwind:
list_for_each_entry_continue_reverse(port, &team->port_list, list)
vlan_vid_del(port->dev, proto, vid);
- mutex_unlock(&team->lock);
return err;
}
@@ -1916,10 +1908,8 @@ static int team_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
struct team *team = netdev_priv(dev);
struct team_port *port;
- mutex_lock(&team->lock);
list_for_each_entry(port, &team->port_list, list)
vlan_vid_del(port->dev, proto, vid);
- mutex_unlock(&team->lock);
return 0;
}
@@ -1941,9 +1931,7 @@ static void team_netpoll_cleanup(struct net_device *dev)
{
struct team *team = netdev_priv(dev);
- mutex_lock(&team->lock);
__team_netpoll_cleanup(team);
- mutex_unlock(&team->lock);
}
static int team_netpoll_setup(struct net_device *dev,
@@ -1953,7 +1941,6 @@ static int team_netpoll_setup(struct net_device *dev,
struct team_port *port;
int err = 0;
- mutex_lock(&team->lock);
list_for_each_entry(port, &team->port_list, list) {
err = __team_port_enable_netpoll(port);
if (err) {
@@ -1961,7 +1948,6 @@ static int team_netpoll_setup(struct net_device *dev,
break;
}
}
- mutex_unlock(&team->lock);
return err;
}
#endif
@@ -1972,9 +1958,7 @@ static int team_add_slave(struct net_device *dev, struct net_device *port_dev,
struct team *team = netdev_priv(dev);
int err;
- mutex_lock(&team->lock);
err = team_port_add(team, port_dev, extack);
- mutex_unlock(&team->lock);
if (!err)
netdev_change_features(dev);
@@ -1987,9 +1971,7 @@ static int team_del_slave(struct net_device *dev, struct net_device *port_dev)
struct team *team = netdev_priv(dev);
int err;
- mutex_lock(&team->lock);
err = team_port_del(team, port_dev);
- mutex_unlock(&team->lock);
if (err)
return err;
@@ -2945,11 +2927,7 @@ static void __team_port_change_port_removed(struct team_port *port)
static void team_port_change_check(struct team_port *port, bool linkup)
{
- struct team *team = port->team;
-
- mutex_lock(&team->lock);
__team_port_change_check(port, linkup);
- mutex_unlock(&team->lock);
}
--
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [syzbot] [net?] possible deadlock in team_device_event (3)
2024-05-09 16:54 [syzbot] [net?] possible deadlock in team_device_event (3) syzbot
` (8 preceding siblings ...)
2024-08-02 14:20 ` syzbot
@ 2025-06-27 13:23 ` Tetsuo Handa
2025-06-27 13:43 ` syzbot
9 siblings, 1 reply; 13+ messages in thread
From: Tetsuo Handa @ 2025-06-27 13:23 UTC (permalink / raw)
To: syzbot, LKML
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
^ permalink raw reply [flat|nested] 13+ messages in thread