public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+8c652f14a0fde76ff11d@syzkaller.appspotmail.com>
To: almaz.alexandrovich@paragon-software.com
Cc: almaz.alexandrovich@paragon-software.com,
	linux-kernel@vger.kernel.org,  syzkaller-bugs@googlegroups.com
Subject: Re: possible fix (linux-ntfs3)
Date: Mon, 09 Sep 2024 23:52:22 -0700	[thread overview]
Message-ID: <000000000000bafce70621be5041@google.com> (raw)
In-Reply-To: <20240910065209.5664-1-almaz.alexandrovich@paragon-software.com>

> #syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master

This crash does not have a reproducer. I cannot test it.

>
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 4fdcb5177ea1..eb935d4180c0 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -1314,7 +1314,14 @@ static int ntfs_file_release(struct inode *inode, struct file *file)
>  	/* If we are last writer on the inode, drop the block reservation. */
>  	if (sbi->options->prealloc &&
>  	    ((file->f_mode & FMODE_WRITE) &&
> -	     atomic_read(&inode->i_writecount) == 1)) {
> +	     atomic_read(&inode->i_writecount) == 1)
> +	   /*
> +	    * The only file when inode->i_fop = &ntfs_file_operations and
> +	    * init_rwsem(&ni->file.run_lock) is not called explicitly is MFT.
> +	    *
> +	    * Add additional check here.
> +	    */
> +	    && inode->i_ino != MFT_REC_MFT) {
>  		ni_lock(ni);
>  		down_write(&ni->file.run_lock);
>  

       reply	other threads:[~2024-09-10  6:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240910065209.5664-1-almaz.alexandrovich@paragon-software.com>
2024-09-10  6:52 ` syzbot [this message]
     [not found] <b9136b92-fdeb-4a51-887d-4648560756ba@paragon-software.com>
2024-09-02 12:22 ` possible fix (linux-ntfs3) syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000bafce70621be5041@google.com \
    --to=syzbot+8c652f14a0fde76ff11d@syzkaller.appspotmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox