public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+34ad5fab48f7bf510349@syzkaller.appspotmail.com>
To: ryasuoka@redhat.com
Cc: ryasuoka@redhat.com, syzkaller-bugs@googlegroups.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Fix kernel-infoleak in __skb_datagram_iter (2)
Date: Sat, 17 Feb 2024 06:43:20 -0800	[thread overview]
Message-ID: <000000000000bf86ff061194e1ba@google.com> (raw)
In-Reply-To: <CAHpthZojFipy1QVY=61vbBD6s6QdJdoNmQdTo90a=JixHA-V5g@mail.gmail.com>

> #syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

want either no args or 2 args (repo, branch), got 1

> 9f8413c4a66f
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 27998f73183e..c7bf1c38b292 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -2532,6 +2532,11 @@ static inline unsigned char
> *skb_tail_pointer(const struct sk_buff *skb)
>   return skb->head + skb->tail;
>  }
>
> +static inline unsigned int skb_tail_offset(const struct sk_buff *skb)
> +{
> + return skb->tail;
> +}
> +
>  static inline void skb_reset_tail_pointer(struct sk_buff *skb)
>  {
>   skb->tail = skb->data - skb->head;
> @@ -2549,6 +2554,11 @@ static inline unsigned char
> *skb_tail_pointer(const struct sk_buff *skb)
>   return skb->tail;
>  }
>
> +static inline unsigned int skb_tail_offset(const struct sk_buff *skb)
> +{
> + return skb->tail - skb->head;
> +}
> +
>  static inline void skb_reset_tail_pointer(struct sk_buff *skb)
>  {
>   skb->tail = skb->data;
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index eb086b06d60d..f11bb308f1ed 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -167,7 +167,7 @@ static inline u32 netlink_group_mask(u32 group)
>  static struct sk_buff *netlink_to_full_skb(const struct sk_buff *skb,
>      gfp_t gfp_mask)
>  {
> - unsigned int len = skb_end_offset(skb);
> + unsigned int len = skb_tail_offset(skb);
>   struct sk_buff *new;
>
>   new = alloc_skb(len, gfp_mask);
>

           reply	other threads:[~2024-02-17 14:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CAHpthZojFipy1QVY=61vbBD6s6QdJdoNmQdTo90a=JixHA-V5g@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000bf86ff061194e1ba@google.com \
    --to=syzbot+34ad5fab48f7bf510349@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryasuoka@redhat.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox