From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1C1CA0FFC for ; Tue, 5 Sep 2023 17:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350216AbjIEREy (ORCPT ); Tue, 5 Sep 2023 13:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354408AbjIEL0b (ORCPT ); Tue, 5 Sep 2023 07:26:31 -0400 Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B731AB for ; Tue, 5 Sep 2023 04:26:28 -0700 (PDT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-26d269dc983so2377628a91.2 for ; Tue, 05 Sep 2023 04:26:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693913188; x=1694517988; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kQPJMHSAtzWXG2gW3deKh6579jIDQUBLJdslJvkNDNo=; b=XMI9t1/wkGCJ5+wWPPM94xiWP4TROfomIGIKt+qLvi4a5WA3fQIdeOtzXaRXHnjOQ2 FlOFwR9PvLbiwoYZd5NDt+3V2qW+cQy9nIvyR7pKM0+DJN7EVyvZjWFRnnYsl6oYRToz yEURLkAZIqdLQDCY+6L8PUmolYIIKMaTepzJAdw/UpFx4UhMYRS7zOj/6+hBfp0jck/5 lzc4eXOZHY9tLMeG5PN4T/P8mxbRI8jAZMqheEgTwDmgSlyPUI2iNOLPqepewYcHS8Xk tBPdvLMuvtmkidyK65oCqY74vfTFrR6HnAwDbFUCtvlSQGDUvZ0gAtZrnx4Ir/67pTdQ to3Q== X-Gm-Message-State: AOJu0Ywn/0F07d1aNBZBx6BQ7QmlNLUNuqSGJYqk5zB9xOvCmMnJQi+A 7zvBRrGPPrj1WHpluEKXgn24r6N+c3mTrpHg3D2qQ+1xIO26 X-Google-Smtp-Source: AGHT+IH0FNjePIQA0qaE8PcpIxxptgs5CL2dHIaS4rzQXfPnmxwLJY+asAJbs437D54ej2lVpLRV2KgagwtNQVXI0e2ynp5R7RJY MIME-Version: 1.0 X-Received: by 2002:a17:90b:1104:b0:26b:62d9:d32 with SMTP id gi4-20020a17090b110400b0026b62d90d32mr2878845pjb.8.1693913187710; Tue, 05 Sep 2023 04:26:27 -0700 (PDT) Date: Tue, 05 Sep 2023 04:26:27 -0700 In-Reply-To: <20230905104933.5567-1-hdanton@sina.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000d57ffb06049ae51e@google.com> Subject: Re: [syzbot] [bluetooth?] KASAN: slab-use-after-free Write in sco_conn_del From: syzbot To: hdanton@sina.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: KASAN: slab-use-after-free Write in sco_conn_del Bluetooth: hci0: command 0x0405 tx timeout Bluetooth: hci0: command 0x0405 tx timeout Bluetooth: hci0: command 0x0405 tx timeout ================================================================== BUG: KASAN: slab-use-after-free in instrument_atomic_read_write include/linux/instrumented.h:96 [inline] BUG: KASAN: slab-use-after-free in atomic_fetch_add_relaxed include/linux/atomic/atomic-instrumented.h:252 [inline] BUG: KASAN: slab-use-after-free in __refcount_add include/linux/refcount.h:193 [inline] BUG: KASAN: slab-use-after-free in __refcount_inc include/linux/refcount.h:250 [inline] BUG: KASAN: slab-use-after-free in refcount_inc include/linux/refcount.h:267 [inline] BUG: KASAN: slab-use-after-free in sock_hold include/net/sock.h:777 [inline] BUG: KASAN: slab-use-after-free in sco_conn_del+0xb9/0x2d0 net/bluetooth/sco.c:195 Write of size 4 at addr ffff888068c19080 by task kworker/u5:2/5037 CPU: 0 PID: 5037 Comm: kworker/u5:2 Not tainted 6.5.0-syzkaller-03967-gbd6c11bc43c4-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Workqueue: hci0 hci_cmd_sync_work Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:364 [inline] print_report+0xc4/0x620 mm/kasan/report.c:475 kasan_report+0xda/0x110 mm/kasan/report.c:588 check_region_inline mm/kasan/generic.c:181 [inline] kasan_check_range+0xef/0x190 mm/kasan/generic.c:187 instrument_atomic_read_write include/linux/instrumented.h:96 [inline] atomic_fetch_add_relaxed include/linux/atomic/atomic-instrumented.h:252 [inline] __refcount_add include/linux/refcount.h:193 [inline] __refcount_inc include/linux/refcount.h:250 [inline] refcount_inc include/linux/refcount.h:267 [inline] sock_hold include/net/sock.h:777 [inline] sco_conn_del+0xb9/0x2d0 net/bluetooth/sco.c:195 sco_connect_cfm+0x205/0xb70 net/bluetooth/sco.c:1339 hci_connect_cfm include/net/bluetooth/hci_core.h:1935 [inline] hci_conn_failed+0x196/0x320 net/bluetooth/hci_conn.c:1251 hci_conn_cleanup_child net/bluetooth/hci_conn.c:1065 [inline] hci_conn_unlink+0x6f9/0x9b0 net/bluetooth/hci_conn.c:1092 hci_conn_del+0x59/0xd10 net/bluetooth/hci_conn.c:1118 hci_abort_conn_sync+0xacb/0xe20 net/bluetooth/hci_sync.c:5435 abort_conn_sync+0x18e/0x3a0 net/bluetooth/hci_conn.c:2894 hci_cmd_sync_work+0x1a4/0x3c0 net/bluetooth/hci_sync.c:306 process_one_work+0xaa2/0x16f0 kernel/workqueue.c:2600 worker_thread+0x687/0x1110 kernel/workqueue.c:2751 kthread+0x33a/0x430 kernel/kthread.c:389 ret_from_fork+0x2c/0x70 arch/x86/kernel/process.c:145 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 Allocated by task 5848: kasan_save_stack+0x33/0x50 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 ____kasan_kmalloc mm/kasan/common.c:374 [inline] __kasan_kmalloc+0xa2/0xb0 mm/kasan/common.c:383 kasan_kmalloc include/linux/kasan.h:196 [inline] __do_kmalloc_node mm/slab_common.c:985 [inline] __kmalloc+0x5d/0x100 mm/slab_common.c:998 kmalloc include/linux/slab.h:586 [inline] sk_prot_alloc+0x1a4/0x2a0 net/core/sock.c:2089 sk_alloc+0x3a/0x7f0 net/core/sock.c:2142 bt_sock_alloc+0x3b/0x3e0 net/bluetooth/af_bluetooth.c:148 sco_sock_alloc net/bluetooth/sco.c:473 [inline] sco_sock_create+0xe3/0x3b0 net/bluetooth/sco.c:504 bt_sock_create+0x180/0x340 net/bluetooth/af_bluetooth.c:132 __sock_create+0x334/0x810 net/socket.c:1549 sock_create net/socket.c:1600 [inline] __sys_socket_create net/socket.c:1637 [inline] __sys_socket+0x14c/0x260 net/socket.c:1688 __do_sys_socket net/socket.c:1702 [inline] __se_sys_socket net/socket.c:1700 [inline] __x64_sys_socket+0x72/0xb0 net/socket.c:1700 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Freed by task 5849: kasan_save_stack+0x33/0x50 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 kasan_save_free_info+0x2b/0x40 mm/kasan/generic.c:522 ____kasan_slab_free mm/kasan/common.c:236 [inline] ____kasan_slab_free+0x15e/0x1b0 mm/kasan/common.c:200 kasan_slab_free include/linux/kasan.h:162 [inline] slab_free_hook mm/slub.c:1792 [inline] slab_free_freelist_hook+0x10b/0x1e0 mm/slub.c:1818 slab_free mm/slub.c:3801 [inline] __kmem_cache_free+0xb8/0x2f0 mm/slub.c:3814 sk_prot_free net/core/sock.c:2125 [inline] __sk_destruct+0x5fc/0x770 net/core/sock.c:2217 sk_destruct+0xc2/0xf0 net/core/sock.c:2232 __sk_free+0xc4/0x3a0 net/core/sock.c:2243 sk_free+0x7c/0xa0 net/core/sock.c:2254 sock_put include/net/sock.h:1983 [inline] sco_sock_kill net/bluetooth/sco.c:426 [inline] sco_sock_kill+0x19d/0x1c0 net/bluetooth/sco.c:416 sco_sock_release+0x154/0x2c0 net/bluetooth/sco.c:1234 __sock_release+0xae/0x260 net/socket.c:657 sock_close+0x1c/0x20 net/socket.c:1399 __fput+0x3f7/0xa70 fs/file_table.c:384 task_work_run+0x14d/0x240 kernel/task_work.c:179 get_signal+0x1075/0x2770 kernel/signal.c:2657 arch_do_signal_or_restart+0x89/0x5f0 arch/x86/kernel/signal.c:308 exit_to_user_mode_loop kernel/entry/common.c:168 [inline] exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline] syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:296 do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd The buggy address belongs to the object at ffff888068c19000 which belongs to the cache kmalloc-2k of size 2048 The buggy address is located 128 bytes inside of freed 2048-byte region [ffff888068c19000, ffff888068c19800) The buggy address belongs to the physical page: page:ffffea0001a30600 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x68c18 head:ffffea0001a30600 order:3 entire_mapcount:0 nr_pages_mapped:0 pincount:0 flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) page_type: 0xffffffff() raw: 00fff00000010200 ffff888012842000 ffffea0001a30400 0000000000000002 raw: 0000000000000000 0000000000080008 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 22, tgid 22 (kworker/1:0), ts 96674696674, free_ts 74879599637 set_page_owner include/linux/page_owner.h:31 [inline] post_alloc_hook+0x2d2/0x350 mm/page_alloc.c:1570 prep_new_page mm/page_alloc.c:1577 [inline] get_page_from_freelist+0x10a9/0x31e0 mm/page_alloc.c:3221 __alloc_pages+0x1d0/0x4a0 mm/page_alloc.c:4477 alloc_pages+0x1a9/0x270 mm/mempolicy.c:2298 alloc_slab_page mm/slub.c:1862 [inline] allocate_slab+0x24e/0x380 mm/slub.c:2009 new_slab mm/slub.c:2062 [inline] ___slab_alloc+0x8bc/0x1570 mm/slub.c:3215 __slab_alloc.constprop.0+0x56/0xa0 mm/slub.c:3314 __slab_alloc_node mm/slub.c:3367 [inline] slab_alloc_node mm/slub.c:3460 [inline] __kmem_cache_alloc_node+0x137/0x350 mm/slub.c:3509 __do_kmalloc_node mm/slab_common.c:984 [inline] __kmalloc_node_track_caller+0x4d/0x100 mm/slab_common.c:1005 kmalloc_reserve+0xef/0x270 net/core/skbuff.c:575 __alloc_skb+0x12b/0x330 net/core/skbuff.c:644 alloc_skb include/linux/skbuff.h:1286 [inline] alloc_skb_with_frags+0xe4/0x710 net/core/skbuff.c:6299 sock_alloc_send_pskb+0x7c8/0x950 net/core/sock.c:2794 sock_alloc_send_skb include/net/sock.h:1879 [inline] mld_newpack.isra.0+0x1ee/0x790 net/ipv6/mcast.c:1746 add_grhead+0x295/0x340 net/ipv6/mcast.c:1849 add_grec+0x10bb/0x1680 net/ipv6/mcast.c:1987 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1161 [inline] __free_pages_ok+0x6b3/0xef0 mm/page_alloc.c:1300 kvfree+0x47/0x50 mm/util.c:650 proc_sys_call_handler+0x549/0x6c0 fs/proc/proc_sysctl.c:610 call_read_iter include/linux/fs.h:1979 [inline] new_sync_read fs/read_write.c:389 [inline] vfs_read+0x4e0/0x930 fs/read_write.c:470 ksys_read+0x12f/0x250 fs/read_write.c:613 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Memory state around the buggy address: ffff888068c18f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff888068c19000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >ffff888068c19080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888068c19100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff888068c19180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== Tested on: commit: bd6c11bc Merge tag 'net-next-6.6' of git://git.kernel... git tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git console output: https://syzkaller.appspot.com/x/log.txt?x=1214c5ec680000 kernel config: https://syzkaller.appspot.com/x/.config?x=634e05b4025da9da dashboard link: https://syzkaller.appspot.com/bug?extid=6b9277cad941daf126a2 compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 patch: https://syzkaller.appspot.com/x/patch.diff?x=130fd8afa80000