public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com>
To: ryasuoka@redhat.com
Cc: ryasuoka@redhat.com, syzkaller-bugs@googlegroups.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] nfc: nci: Fix uninit-value in nci_dev_up
Date: Tue, 12 Mar 2024 07:27:58 -0700	[thread overview]
Message-ID: <000000000000f90e5a06137776f9@google.com> (raw)
In-Reply-To: <ZfBmZmSHjcXgqVly@zeus>

> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

want either no args or 2 args (repo, branch), got 5

>
> diff --git a/net/nfc/nci/ntf.c b/net/nfc/nci/ntf.c
> index 994a0a1efb58..56624387e253 100644
> --- a/net/nfc/nci/ntf.c
> +++ b/net/nfc/nci/ntf.c
> @@ -765,6 +765,9 @@ void nci_ntf_packet(struct nci_dev *ndev, struct sk_buff *skb)
>  		 nci_opcode_oid(ntf_opcode),
>  		 nci_plen(skb->data));
>  
> +	if (!nci_plen(skb->data))
> +		goto end;
> +
>  	/* strip the nci control header */
>  	skb_pull(skb, NCI_CTRL_HDR_SIZE);
>

       reply	other threads:[~2024-03-12 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ZfBmZmSHjcXgqVly@zeus>
2024-03-12 14:27 ` syzbot [this message]
2024-03-12 14:56 [PATCH net] nfc: nci: Fix uninit-value in nci_dev_up Ryosuke Yasuoka
2024-03-13  9:01 ` Krzysztof Kozlowski
2024-03-14  9:59   ` Ryosuke Yasuoka
2024-03-14 11:58     ` Paolo Abeni
2024-03-25 19:19       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000000000000f90e5a06137776f9@google.com \
    --to=syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryasuoka@redhat.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox