* Re: [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
@ 2024-08-27 7:27 ` Edward Adam Davis
2024-08-27 7:50 ` syzbot
2024-09-02 12:27 ` [syzbot] possible fix (linux-ntfs3) syzbot
` (5 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Edward Adam Davis @ 2024-08-27 7:27 UTC (permalink / raw)
To: syzbot+4d2aaeff9eb5a2cfec70; +Cc: linux-kernel, syzkaller-bugs
#syz test: upstream master
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit
2024-08-27 7:27 ` Edward Adam Davis
@ 2024-08-27 7:50 ` syzbot
0 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-08-27 7:50 UTC (permalink / raw)
To: eadavis, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel panic: stack is corrupted in vprintk_emit
ntfs3: loop0: Failed to load $UpCase (-22).
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: vprintk_emit+0x7bd/0x7c0
CPU: 0 UID: 0 PID: 5851 Comm: syz.0.15 Not tainted 6.11.0-rc5-syzkaller-00015-g3e9bff3bbe13 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:93 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
panic+0x349/0x860 kernel/panic.c:354
__stack_chk_fail+0x15/0x20 kernel/panic.c:827
vprintk_emit+0x7bd/0x7c0
_printk+0xd5/0x120 kernel/printk/printk.c:2373
ntfs_printk+0x3ad/0x420 fs/ntfs3/super.c:93
ntfs_fill_super+0x2eb8/0x4730
get_tree_bdev+0x3f7/0x570 fs/super.c:1635
vfs_get_tree+0x90/0x2b0 fs/super.c:1800
do_new_mount+0x2be/0xb40 fs/namespace.c:3472
do_mount fs/namespace.c:3812 [inline]
__do_sys_mount fs/namespace.c:4020 [inline]
__se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3997
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f6e3a57b0ba
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 7e 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6e3b384e68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f6e3b384ef0 RCX: 00007f6e3a57b0ba
RDX: 000000002001f800 RSI: 000000002001f840 RDI: 00007f6e3b384eb0
RBP: 000000002001f800 R08: 00007f6e3b384ef0 R09: 0000000000000801
R10: 0000000000000801 R11: 0000000000000246 R12: 000000002001f840
R13: 00007f6e3b384eb0 R14: 000000000001f829 R15: 0000000020000000
</TASK>
Kernel Offset: disabled
Rebooting in 86400 seconds..
Tested on:
commit: 3e9bff3b Merge tag 'vfs-6.11-rc6.fixes' of gitolite.ke..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1362847b980000
kernel config: https://syzkaller.appspot.com/x/.config?x=8605cd35ddc8ff3c
dashboard link: https://syzkaller.appspot.com/bug?extid=4d2aaeff9eb5a2cfec70
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Note: no patches were applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
2024-08-27 7:27 ` Edward Adam Davis
@ 2024-09-02 12:27 ` syzbot
2024-09-02 12:44 ` [syzbot] possible fix 2 (linux-ntfs3) syzbot
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-02 12:27 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..c08bbacc0030 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -125,8 +125,9 @@ void ntfs_inode_printk(struct inode *inode, const
char *fmt, ...)
if (de) {
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ if (snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name) >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
spin_unlock(&de->d_lock);
} else {
name[0] = 0;
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [syzbot] possible fix 2 (linux-ntfs3)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
2024-08-27 7:27 ` Edward Adam Davis
2024-09-02 12:27 ` [syzbot] possible fix (linux-ntfs3) syzbot
@ 2024-09-02 12:44 ` syzbot
2024-09-02 12:45 ` [syzbot] possible fix 2 (upstream) syzbot
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-02 12:44 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix 2 (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..c08bbacc0030 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -125,8 +125,9 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
if (de) {
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ if (snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name) >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
spin_unlock(&de->d_lock);
} else {
name[0] = 0;
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [syzbot] possible fix 2 (upstream)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
` (2 preceding siblings ...)
2024-09-02 12:44 ` [syzbot] possible fix 2 (linux-ntfs3) syzbot
@ 2024-09-02 12:45 ` syzbot
2024-09-04 14:18 ` [syzbot] check syzbot
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-02 12:45 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix 2 (upstream)
Author: almaz.alexandrovich@paragon-software.com
#syz test: upstream master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..c08bbacc0030 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -125,8 +125,9 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
if (de) {
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ if (snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name) >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
spin_unlock(&de->d_lock);
} else {
name[0] = 0;
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [syzbot] check
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
` (3 preceding siblings ...)
2024-09-02 12:45 ` [syzbot] possible fix 2 (upstream) syzbot
@ 2024-09-04 14:18 ` syzbot
2024-09-04 14:22 ` syzbot
2024-09-10 7:08 ` [syzbot] possible fix (linux-ntfs3) syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-04 14:18 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: check
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..a5df8f4c0150 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1472,7 +1472,7 @@ static int ntfs_fill_super(struct super_block *sb,
struct fs_context *fc)
inode = ntfs_iget5(sb, &ref, &NAME_UPCASE);
if (IS_ERR(inode)) {
err = PTR_ERR(inode);
- ntfs_err(sb, "Failed to load $UpCase (%d).", err);
+ ntfs_err(sb, "Failed to load UpCase (%d).", err);
goto out;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [syzbot] check
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
` (4 preceding siblings ...)
2024-09-04 14:18 ` [syzbot] check syzbot
@ 2024-09-04 14:22 ` syzbot
2024-09-10 7:08 ` [syzbot] possible fix (linux-ntfs3) syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-04 14:22 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: check
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..a5df8f4c0150 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1472,7 +1472,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
inode = ntfs_iget5(sb, &ref, &NAME_UPCASE);
if (IS_ERR(inode)) {
err = PTR_ERR(inode);
- ntfs_err(sb, "Failed to load $UpCase (%d).", err);
+ ntfs_err(sb, "Failed to load UpCase (%d).", err);
goto out;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [syzbot] possible fix (linux-ntfs3)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
` (5 preceding siblings ...)
2024-09-04 14:22 ` syzbot
@ 2024-09-10 7:08 ` syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-09-10 7:08 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..4a2062e481a4 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -124,10 +124,15 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
struct dentry *de = d_find_alias(inode);
if (de) {
+ int len;
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ len = snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name);
spin_unlock(&de->d_lock);
+ if (len <= 0)
+ name[0] = 0;
+ else if (len >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
} else {
name[0] = 0;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread