From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "'Mark Brown'" <broonie@opensource.wolfsonmicro.com>,
"'axel lin'" <axel.lin@gmail.com>
Cc: "'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
lrg@slimlogic.co.uk
Subject: RE: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4
Date: Mon, 15 Mar 2010 07:44:53 +0100 [thread overview]
Message-ID: <000001cac40b$07368ba0$15a3a2e0$%szyprowski@samsung.com> (raw)
In-Reply-To: <20100310170717.GC22626@rakim.wolfsonmicro.main>
Hello,
On Wednesday, March 10, 2010 6:07 PM Mark Brown wrote:
> On Wed, Mar 10, 2010 at 08:29:40AM +0800, axel lin wrote:
> > From: Axel Lin <axel.lin@gmail.com>
> > Date: Tue, 9 Mar 2010 16:53:59 +0800
> > Subject: [PATCH] lp3971: Fix setting val for LDO2 and LDO4
> >
> > In lp3971_ldo_set_voltage function, it requires val to left shift 4
> > bits for LDO2 and LDO4.
> > This patch fix this issue.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but I really would prefer to see one of the Samsung folks comment.
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
This was definitely a bug. Thanks for spotting it.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2010-03-15 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 0:29 [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4 axel lin
2010-03-10 17:07 ` Mark Brown
2010-03-15 6:44 ` Marek Szyprowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 9:14 axel lin
2010-03-09 14:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cac40b$07368ba0$15a3a2e0$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).