* [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250
@ 2013-05-11 8:09 Jingoo Han
2013-05-11 21:40 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2013-05-11 8:09 UTC (permalink / raw)
To: 'Kukjin Kim'
Cc: linux-samsung-soc, Jingoo Han, 'Thomas Abraham',
'Olof Johansson', 'Doug Anderson',
linux-arm-kernel, linux-kernel
Add pin state information for DP HPD support that requires
pin configuration support using pinctrl interface.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5250
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index d1650fb..e9cdee3 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -553,6 +553,13 @@
samsung,pin-pud = <0>;
samaung,pin-drv = <0>;
};
+
+ dp_hpd: dp_hpd {
+ samsung,pins = "gpx0-7";
+ samsung,pin-function = <3>;
+ samsung,pin-pud = <0>;
+ samaung,pin-drv = <0>;
+ };
};
pinctrl@13400000 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 3e0c792..d53ea34 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -224,6 +224,9 @@
samsung,color-depth = <1>;
samsung,link-rate = <0x0a>;
samsung,lane-count = <4>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&dp_hpd>;
};
display-timings {
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250
2013-05-11 8:09 [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250 Jingoo Han
@ 2013-05-11 21:40 ` Doug Anderson
2013-06-10 8:35 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2013-05-11 21:40 UTC (permalink / raw)
To: Jingoo Han
Cc: Kukjin Kim, linux-samsung-soc, Thomas Abraham, Olof Johansson,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sean Paul, Stéphane Marchesin,
Andrew Bresticker
Jingoo,
On Sat, May 11, 2013 at 1:09 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Add pin state information for DP HPD support that requires
> pin configuration support using pinctrl interface.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on Exynos5250
>
> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d1650fb..e9cdee3 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -553,6 +553,13 @@
> samsung,pin-pud = <0>;
> samaung,pin-drv = <0>;
> };
> +
> + dp_hpd: dp_hpd {
> + samsung,pins = "gpx0-7";
> + samsung,pin-function = <3>;
> + samsung,pin-pud = <0>;
> + samaung,pin-drv = <0>;
> + };
> };
>
> pinctrl@13400000 {
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 3e0c792..d53ea34 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -224,6 +224,9 @@
> samsung,color-depth = <1>;
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <4>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&dp_hpd>;
I was going to suggest moving this to exynos5250.dtsi but then
realized that I saw a board recently that used a non-standard HPD pin
recently! ...so keeping it in the board file (like you've done) is
good.
...so looks good to me.
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250
2013-05-11 21:40 ` Doug Anderson
@ 2013-06-10 8:35 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2013-06-10 8:35 UTC (permalink / raw)
To: 'Doug Anderson', 'Jingoo Han'
Cc: 'linux-samsung-soc', 'Thomas Abraham',
'Olof Johansson', linux-arm-kernel, linux-kernel,
'Sean Paul', 'Stéphane Marchesin',
'Andrew Bresticker'
Doug Anderson wrote:
>
> Jingoo,
>
> On Sat, May 11, 2013 at 1:09 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> > Add pin state information for DP HPD support that requires
> > pin configuration support using pinctrl interface.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > Tested on Exynos5250
> >
> > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
> > arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> > 2 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > index d1650fb..e9cdee3 100644
> > --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > @@ -553,6 +553,13 @@
> > samsung,pin-pud = <0>;
> > samaung,pin-drv = <0>;
> > };
> > +
> > + dp_hpd: dp_hpd {
> > + samsung,pins = "gpx0-7";
> > + samsung,pin-function = <3>;
> > + samsung,pin-pud = <0>;
> > + samaung,pin-drv = <0>;
> > + };
> > };
> >
> > pinctrl@13400000 {
> > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > index 3e0c792..d53ea34 100644
> > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > @@ -224,6 +224,9 @@
> > samsung,color-depth = <1>;
> > samsung,link-rate = <0x0a>;
> > samsung,lane-count = <4>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&dp_hpd>;
>
> I was going to suggest moving this to exynos5250.dtsi but then
> realized that I saw a board recently that used a non-standard HPD pin
> recently! ...so keeping it in the board file (like you've done) is
> good.
>
> ...so looks good to me.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Yeah, I agreed with Doug's comment :-)
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 8:09 [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250 Jingoo Han
2013-05-11 21:40 ` Doug Anderson
2013-06-10 8:35 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox