From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Xiangliang Yu'" <Xiangliang.Yu@amd.com>, <jdmason@kudzu.us>,
<dave.jiang@intel.com>, <linux-ntb@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Cc: <SPG_Linux_Kernel@amd.com>
Subject: RE: [PATCH V3 0/2] AMD NTB V3 changes
Date: Thu, 14 Jan 2016 10:55:31 -0500 [thread overview]
Message-ID: <000001d14ee3$ffd532c0$ff7f9840$@emc.com> (raw)
In-Reply-To: <1452771830-16907-1-git-send-email-Xiangliang.Yu@amd.com>
> From: Xiangliang Yu <Xiangliang.Yu@amd.com>
>
> Main changes in V3
> 1. Remove all power managment related code.
Can you send the third patch with the power management code? I think it is important functionality.
Furthermore, a review of the power management patch will help with getting the flush patch accepted. If the power management patch is reviewed and acked as is, the flush patch is probably ok, too, as is. If there are changes to power management that are also applicable to the flush patch, it would be good to keep it all consistent when adding the functionality to the api.
> 2. Put makefile and kconfig changes in first patch.
> 3. Call readl/writel directly, not use macros to hide it.
I think this is almost ready. See comments in NTB: Add AMD PCI-Express NTB driver.
Allen
next prev parent reply other threads:[~2016-01-14 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 11:43 [PATCH V3 0/2] AMD NTB V3 changes Xiangliang Yu
2016-01-14 15:55 ` Allen Hubbe [this message]
2016-01-15 2:23 ` Yu, Xiangliang
2016-01-15 17:12 ` Allen Hubbe
2016-01-18 4:09 ` Jon Mason
2016-01-18 6:49 ` Yu, Xiangliang
2016-01-18 6:21 ` Yu, Xiangliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d14ee3$ffd532c0$ff7f9840$@emc.com' \
--to=allen.hubbe@emc.com \
--cc=SPG_Linux_Kernel@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox