From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966903AbcHBNuc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 09:50:32 -0400
Received: from esa6.dell-outbound.iphmx.com ([68.232.149.229]:28110 "EHLO
	esa6.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S966708AbcHBNt5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 09:49:57 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd01.lss.emc.com u72DkBFZ002182
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd01.lss.emc.com u72DkBFZ002182
From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Baole Ni'" <baolex.ni@intel.com>, <jdmason@kudzu.us>,
        <dave.jiang@intel.com>, <linuxwifi@intel.com>, <kvalo@codeaurora.org>,
        <m.chehab@samsung.com>, <pawel@osciak.com>, <m.szyprowski@samsung.com>,
        <kyungmin.park@samsung.com>, <k.kozlowski@samsung.com>
Cc: <linux-ntb@googlegroups.com>, <linux-kernel@vger.kernel.org>,
        <chuansheng.liu@intel.com>
References: <20160802114821.3765-1-baolex.ni@intel.com>
In-Reply-To: <20160802114821.3765-1-baolex.ni@intel.com>
Subject: RE: [PATCH 0807/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:45:55 -0400
Message-ID: <000001d1ecc4$324df510$96e9df30$@emc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQHR7LkLGFEJmT1XkU+CYUMnKrzQNqA1rTxg
Content-Language: en-us
X-RSA-Classifications: public
X-Sentrion-Hostname: mailuogwprd01.lss.emc.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Baole Ni
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 40d04ef..7aa1faa 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -92,56 +92,56 @@ static const struct file_operations intel_ntb_debugfs_info;
>  static struct dentry *debugfs_dir;
> 
>  static int b2b_mw_idx = -1;
> -module_param(b2b_mw_idx, int, 0644);
> +module_param(b2b_mw_idx, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

The result of this change should be simplified to S_IWUSR | S_IRUGO.

>  module_param_named(xeon_b2b_usd_bar2_addr64,
> -		   xeon_b2b_usd_addr.bar2_addr64, ullong, 0644);
> +		   xeon_b2b_usd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

This line is 97 columns long.

The result of this change should be simplified to S_IWUSR | S_IRUGO, and that might put it under 80 columns.  There are bound to still be other places where this kind of replacement will require additional changes to code formatting.