From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755318AbdJIQMp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 9 Oct 2017 12:12:45 -0400
Received: from mail-qk0-f194.google.com ([209.85.220.194]:35948 "EHLO
        mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755191AbdJIQMn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Oct 2017 12:12:43 -0400
X-Google-Smtp-Source: AOwi7QB37KdyKnAig2HdgwxzkRrYzaELMBXvnrFNcQ1ZCE3VaMWhzayy+OlpkM6bKaVS6IyTLKEGhw==
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Christos Gkekas'" <chris.gekas@gmail.com>,
        "'Lee Jones'" <lee.jones@linaro.org>,
        "'Daniel Thompson'" <daniel.thompson@linaro.org>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@samsung.com>,
        <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1507499808-12896-1-git-send-email-chris.gekas@gmail.com>
In-Reply-To: <1507499808-12896-1-git-send-email-chris.gekas@gmail.com>
Subject: Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check
Date: Mon, 9 Oct 2017 12:12:40 -0400
Message-ID: <000001d34119$6edc8550$4c958ff0$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AQF03r2uVca6zcUSfms4WDCDl+V7HaOYdR7Q
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, October 8, 2017 5:57 PM, Christos Gkekas wrote:
> 
> Variable val holds the default brightness and is unsigned, therefore
> checking whether it is less than zero is redundant.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>

It looks good.

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han


> ---
>  drivers/video/backlight/tps65217_bl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/tps65217_bl.c
> b/drivers/video/backlight/tps65217_bl.c
> index fd524ad..61ea82d 100644
> --- a/drivers/video/backlight/tps65217_bl.c
> +++ b/drivers/video/backlight/tps65217_bl.c
> @@ -239,8 +239,7 @@ tps65217_bl_parse_dt(struct platform_device *pdev)
>  	}
> 
>  	if (!of_property_read_u32(node, "default-brightness", &val)) {
> -		if (val < 0 ||
> -			val > 100) {
> +		if (val > 100) {
>  			dev_err(&pdev->dev,
>  				"invalid 'default-brightness' value in the
> device tree\n");
>  			err = ERR_PTR(-EINVAL);
> --
> 2.7.4