From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751074AbdKERXo (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Nov 2017 12:23:44 -0500
Received: from mail-qt0-f193.google.com ([209.85.216.193]:46264 "EHLO
        mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750724AbdKERXm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Nov 2017 12:23:42 -0500
X-Google-Smtp-Source: ABhQp+S7Q5L90xzsn0SIHwca/xJ+pdQO3aJ2Iz0k+RZKmOakxKGZxnouBfbuwc0xjESfLpV0ObBhGg==
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Colin King'" <colin.king@canonical.com>,
        "'Lee Jones'" <lee.jones@linaro.org>,
        "'Daniel Thompson'" <daniel.thompson@linaro.org>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@samsung.com>,
        <dri-devel@lists.freedesktop.org>, <linux-fbdev@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20171105115326.5276-1-colin.king@canonical.com>
In-Reply-To: <20171105115326.5276-1-colin.king@canonical.com>
Subject: Re: [PATCH] backlight: ili922x: remove redundant variable len
Date: Sun, 5 Nov 2017 12:23:39 -0500
Message-ID: <000001d3565a$d2ee6300$78cb2900$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQDhkTZBUpdja0ZJElRokbsnJfvpVKTpktOQ
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, November 5, 2017 6:53 AM, Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable len is assigned but never read, therefore it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Thank you for sending the patch.
It looks good.

Best regards,
Jingoo Han

> ---
>  drivers/video/backlight/ili922x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ili922x.c
> b/drivers/video/backlight/ili922x.c
> index a9e9cef..2b6c6aa 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8
> reg, u16 value)
>  	struct spi_transfer xfer_regindex, xfer_regvalue;
>  	unsigned char tbuf[CMD_BUFSIZE];
>  	unsigned char rbuf[CMD_BUFSIZE];
> -	int ret, len = 0;
> +	int ret;
> 
>  	memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
>  	memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
> @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8
> reg, u16 value)
>  	ret = spi_sync(spi, &msg);
> 
>  	spi_message_init(&msg);
> -	len = 0;
>  	tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
>  					 START_RW_WRITE));
>  	tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
> --
> 2.7.4