From: Jingoo Han <jg1.han@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Shuah Khan'" <shuah.kh@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com, rpurdie@rpsys.net, FlorianSchandinat@gmx.de,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
rafael.j.wysocki@intel.com, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops
Date: Fri, 07 Jun 2013 10:29:31 +0900 [thread overview]
Message-ID: <000101ce631e$75f5e120$61e1a360$@samsung.com> (raw)
In-Reply-To: <5441622.ypFXsKluBt@wuerfel>
On Friday, June 07, 2013 6:28 AM, Arnd Bergmann wrote:
> On Monday 03 June 2013 13:10:10 Jingoo Han wrote:
> > On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
> > >
> > > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > > management and remove Legacy PM ops hooks. With this change, backlight
> > > class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> > > instead of Legacy class->suspend/resume. When __device_suspend() runs
> > > call-backs, it will find class->pm ops for the backlight class.
> > >
> > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > > Cc: Shuah Khan <shuahkhan@gmail.com>
> >
> > CC'ed Andrew Morton,
> >
> > It looks good.
> >
> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >
>
> I'm getting this build warning now:
>
> arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
> /git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not
> used [-Wunused-function]
> static int backlight_suspend(struct device *dev)
> ^
> /git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not
> used [-Wunused-function]
> static int backlight_resume(struct device *dev)
Hi Arnd Bergmann,
I see what happens.
This build warning happens when CONFIG_PM is selected and
CONFIG_PM_SLEEP is not selected.
So, I will add '#ifdef CONFIG_PM_SLEEP' to './drivers/video/backlight/backlight.c'
and send it soon.
Thank you.
Best regards,
Jingoo Han
>
> Arnd
prev parent reply other threads:[~2013-06-07 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 23:07 [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops Shuah Khan
2013-06-03 4:10 ` Jingoo Han
2013-06-06 21:27 ` Arnd Bergmann
2013-06-07 1:29 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101ce631e$75f5e120$61e1a360$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rpurdie@rpsys.net \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox