From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752434AbdCNQH4 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Mar 2017 12:07:56 -0400
Received: from cmta20.telus.net ([209.171.16.93]:40565 "EHLO cmta20.telus.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750935AbdCNQHy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Mar 2017 12:07:54 -0400
X-Authority-Analysis: v=2.2 cv=d7Ma8VrE c=1 sm=1 tr=0
 a=zJWegnE7BH9C0Gl4FFgQyA==:117 a=zJWegnE7BH9C0Gl4FFgQyA==:17
 a=Pyq9K9CWowscuQLKlpiwfMBGOR0=:19 a=kj9zAlcOel0A:10 a=NIUr98CBLVBIHgMYyHsA:9
 a=t0PUtF9Jn7_6ezu6:21 a=t23BsuhQJIyJNG4Z:21 a=CjuIK1q_8ugA:10
From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rjw@rjwysocki.net>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
        "'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>,
        "'Linux PM'" <linux-pm@vger.kernel.org>
References: <5656785.7SEhxaGEOz@aspire.rjw.lan> n7P3c1QOAsVy3n7P5cDily
In-Reply-To: n7P3c1QOAsVy3n7P5cDily
Subject: RE: [PATCH 10/14] cpufreq: intel_pstate: Use different utilization update callbacks
Date: Tue, 14 Mar 2017 09:07:48 -0700
Message-ID: <000101d29cdd$214bd8d0$63e38a70$@net>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdKbVw7NLH+VM3xpT1mefXa5FUiLfwBhBDbw
Content-Language: en-ca
X-CMAE-Envelope: MS4wfGP3Nr3j+n5k+3s6cFpjrv0DBgoazg/1qBEHT2JJqezX3ceuqeR9DahNA/9yNy78ICtU8AshTrz128cbUbCcL4VtqeDn5bvl/+gqLvTUHZo9EfZsT6rV
 M/G448Avp87hOAboJ50pEu2gealk0/SGp5wx4Kfu06mZkasA3n/Z0NX81HCiI2unGDU/XJU34aKAkOJBNYbpPXB0JrNoWmmWBkAbEDtYFOZtsfzW17QNSDxp
 +CYb3t8UvF5xaJXF/ZtG5IRhffZlIM4H5a7/Rw5Te/+WM9K7/i9hL9Hd7K3BWsi6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rafael,

I can not get this patch to apply.
My start point is kernel 4.11-rc2, so maybe (probably) it is my problem.

On 2017.03.12 10:22 Rafael J. Wysocki wrote:

... [cut] ...

> drivers/cpufreq/intel_pstate.c |   77 ++++++++++++++++++++++++++++-------------
> 1 file changed, 53 insertions(+), 24 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/intel_pstate.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/intel_pstate.c
> +++ linux-pm/drivers/cpufreq/intel_pstate.c
> @@ -37,6 +37,9 @@
> #include <asm/cpufeature.h>
> #include <asm/intel-family.h>
> 
> +#define INTEL_PSTATE_DEFAULT_SAMPLING_INTERVAL	(10 * NSEC_PER_MSEC)
> +#define INTEL_PSTATE_HWP_SAMPLING_INTERVAL	(50 * NSEC_PER_MSEC)
> +
> #define INTEL_CPUFREQ_TRANSITION_LATENCY	20000
> 
> #define ATOM_RATIOS		0x66a

"git am" is getting upset because the above line is still there.
However it was removed in Len Brown's patch turbostat stuff
patch 15 of 44, which is in kernel 4.11-rc1.
(92134bdbc6272da6e98e9242cc6f1576cedc0735)

... [cut] ...

By the way, scripts/checkpatch.pl also complains about a line
length in the patch.

$ scripts/checkpatch.pl rjw_10_14.txt
WARNING: line over 80 characters
#148: FILE: drivers/cpufreq/intel_pstate.c:2031:
+       cpufreq_add_update_util_hook(cpu_num, &cpu->update_util, update_util_cb);

total: 0 errors, 1 warnings, 130 lines checked