From: Jingoo Han <jg1.han@samsung.com>
To: "'Sachin Kamat'" <sachin.kamat@linaro.org>
Cc: "'Mark Brown'" <broonie@kernel.org>,
"'Liam Girdwood'" <lgirdwood@gmail.com>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Marek Szyprowski'" <m.szyprowski@samsung.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 09/20] regulator: lp3972: use devm_regulator_register()
Date: Thu, 26 Sep 2013 10:17:04 +0900 [thread overview]
Message-ID: <000201ceba56$1ce708e0$56b51aa0$%han@samsung.com> (raw)
In-Reply-To: <CAK9yfHxu3LxaKVSX9WO6J7dd+xtGWF4304pUHwN=oFd_hwy3hQ@mail.gmail.com>
On Wednesday, September 25, 2013 7:18 PM, Sachin Kamat wrote:
> On 25 September 2013 13:32, Jingoo Han <jg1.han@samsung.com> wrote:
> > Use devm_regulator_register() to make cleanup paths simpler.
>
> > static int lp3972_i2c_remove(struct i2c_client *i2c)
> > {
> > struct lp3972 *lp3972 = i2c_get_clientdata(i2c);
> > - int i;
> >
> > - for (i = 0; i < lp3972->num_regulators; i++)
> > - regulator_unregister(lp3972->rdev[i]);
> > kfree(lp3972->rdev);
>
> With devm the unregister would happen after the freeing of the device.
> Wouldn't this re-ordering cause any
> problems?
It seems to make the problem.
I will remove this patch from next V2 patch series.
Thank you.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-09-26 1:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 7:48 [PATCH 01/20] regulator: ab3100: use devm_regulator_register() Jingoo Han
2013-09-25 7:51 ` [PATCH 02/20] regulator: ab8500: " Jingoo Han
2013-09-25 10:20 ` Sachin Kamat
2013-09-26 1:25 ` Jingoo Han
2013-09-25 7:52 ` [PATCH 03/20] regulator: ab8500-ext: " Jingoo Han
2013-09-25 7:55 ` [PATCH 04/20] regulator: da9063: " Jingoo Han
2013-09-25 7:56 ` [PATCH 05/20] regulator: da9210: " Jingoo Han
2013-09-25 7:58 ` [PATCH 06/20] regulator: fixed: " Jingoo Han
2013-09-25 8:00 ` [PATCH 07/20] regulator: gpio-regulator: " Jingoo Han
2013-09-25 8:01 ` [PATCH 08/20] regulator: lp3971: " Jingoo Han
2013-09-25 8:02 ` [PATCH 09/20] regulator: lp3972: " Jingoo Han
2013-09-25 10:17 ` Sachin Kamat
2013-09-26 1:17 ` Jingoo Han [this message]
2013-09-25 8:03 ` [PATCH 10/20] regulator: lp872x: " Jingoo Han
2013-09-25 8:04 ` [PATCH 11/20] regulator: lp8788-buck: " Jingoo Han
2013-09-25 8:05 ` [PATCH 12/20] regulator: lp8788-ldo: " Jingoo Han
2013-09-25 8:06 ` [PATCH 13/20] regulator: max8925: " Jingoo Han
2013-09-25 8:08 ` [PATCH 14/20] regulator: max8952: " Jingoo Han
2013-09-25 8:09 ` [PATCH 15/20] regulator: pcap: " Jingoo Han
2013-09-25 8:11 ` [PATCH 16/20] regulator: pcf50633: " Jingoo Han
2013-09-25 8:12 ` [PATCH 17/20] regulator: tps6105x: " Jingoo Han
2013-09-27 12:42 ` Linus Walleij
2013-09-25 8:13 ` [PATCH 18/20] regulator: tps6524x: " Jingoo Han
2013-09-25 8:15 ` [PATCH 19/20] regulator: twl: " Jingoo Han
2013-09-25 12:59 ` Nishanth Menon
2013-09-25 8:17 ` [PATCH 20/20] regulator: vexpress: " Jingoo Han
2013-09-25 10:56 ` Pawel Moll
2013-09-27 12:41 ` [PATCH 01/20] regulator: ab3100: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201ceba56$1ce708e0$56b51aa0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox