From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932526AbdK0SGh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 13:06:37 -0500
Received: from mail-qk0-f196.google.com ([209.85.220.196]:33114 "EHLO
        mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932225AbdK0SGd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 13:06:33 -0500
X-Google-Smtp-Source: AGs4zMb6eQWtnRPIKQ8b/sjoX0CDyyB/tu7unKV08x6w99tkPRbT6mS97yrTOsQb0WvM3eXeJDhkGw==
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'SF Markus Elfring'" <elfring@users.sourceforge.net>,
        <linux-fbdev@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@samsung.com>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net>
In-Reply-To: <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net>
Subject: Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe()
Date: Mon, 27 Nov 2017 13:06:30 -0500
Message-ID: <000201d367aa$74511b10$5cf35130$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AQKhendjzDbQ5QEsTe4g6SvvMrwpmAJQAVGwoXnfe0A=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 26 Nov 2017 15:00:16 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>  drivers/video/fbdev/s3c-fb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 5f4f696c2ecf..0914c973cbd9 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device
> *pdev)
>  	}
> 
>  	sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
> -	if (!sfb) {
> -		dev_err(dev, "no memory for framebuffers\n");
> +	if (!sfb)
>  		return -ENOMEM;
> -	}
> 
>  	dev_dbg(dev, "allocate new framebuffer %p\n", sfb);
> 
> --
> 2.15.0