From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbdK0SHU (ORCPT ); Mon, 27 Nov 2017 13:07:20 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:38377 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225AbdK0SHS (ORCPT ); Mon, 27 Nov 2017 13:07:18 -0500 X-Google-Smtp-Source: AGs4zMatbdjQpr0DQaDTPkCkbYX/NbXYBsFV6CAUWwA7x3/X06cPQJ+6V2O0okQ7fCf1xtF8ovYGRA== From: "Jingoo Han" To: "'SF Markus Elfring'" , , , "'Bartlomiej Zolnierkiewicz'" Cc: "'LKML'" , References: <2c837da0-6b0f-12e7-4d76-960b660a8911@users.sourceforge.net> <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> In-Reply-To: <3eb68979-60cd-81e2-7a6b-9caf4afc1737@users.sourceforge.net> Subject: Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() Date: Mon, 27 Nov 2017 13:07:15 -0500 Message-ID: <000301d367aa$8efbbc40$acf334c0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQKhendjzDbQ5QEsTe4g6SvvMrwpmAJXCYfNoXmnqXA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:03:03 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 0914c973cbd9..8c7623d63eb1 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev) > return -EINVAL; > } > > - sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL); > + sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL); > if (!sfb) > return -ENOMEM; > > -- > 2.15.0