From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Pankaj Dubey'" <pankaj.dubey@samsung.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: "'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Joao Pinto'" <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH] PCI: dwc: designware: don't sleep in atomic context
Date: Thu, 21 Dec 2017 11:39:38 -0500 [thread overview]
Message-ID: <000301d37a7a$4b9681f0$e2c385d0$@gmail.com> (raw)
In-Reply-To: <1507794889-11148-1-git-send-email-pankaj.dubey@samsung.com>
On Thursday, October 12, 2017 3:55 AM, Pankaj Dubey wrote:
>
> In pcie-designware.c many places we are calling "usleep_range" which
> are in atomic context. This patch fixes these potential BUGs and
> replaces "usleep_range" with mdelay calls.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Sorry for my late response.
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/pci/dwc/pcie-designware.c | 8 ++++----
> drivers/pci/dwc/pcie-designware.h | 3 +--
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-
> designware.c
> index 88abddd..35d19b9 100644
> --- a/drivers/pci/dwc/pcie-designware.c
> +++ b/drivers/pci/dwc/pcie-designware.c
> @@ -138,7 +138,7 @@ static void dw_pcie_prog_outbound_atu_unroll(struct
> dw_pcie *pci, int index,
> if (val & PCIE_ATU_ENABLE)
> return;
>
> - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> + mdelay(LINK_WAIT_IATU_MIN);
> }
> dev_err(pci->dev, "outbound iATU is not being enabled\n");
> }
> @@ -181,7 +181,7 @@ void dw_pcie_prog_outbound_atu(struct dw_pcie *pci,
> int index, int type,
> if (val & PCIE_ATU_ENABLE)
> return;
>
> - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> + mdelay(LINK_WAIT_IATU_MIN);
> }
> dev_err(pci->dev, "outbound iATU is not being enabled\n");
> }
> @@ -239,7 +239,7 @@ static int dw_pcie_prog_inbound_atu_unroll(struct
> dw_pcie *pci, int index,
> if (val & PCIE_ATU_ENABLE)
> return 0;
>
> - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> + mdelay(LINK_WAIT_IATU_MIN);
> }
> dev_err(pci->dev, "inbound iATU is not being enabled\n");
>
> @@ -285,7 +285,7 @@ int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int
> index, int bar,
> if (val & PCIE_ATU_ENABLE)
> return 0;
>
> - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> + mdelay(LINK_WAIT_IATU_MIN);
> }
> dev_err(pci->dev, "inbound iATU is not being enabled\n");
>
> diff --git a/drivers/pci/dwc/pcie-designware.h b/drivers/pci/dwc/pcie-
> designware.h
> index e5d9d77..13c17c9 100644
> --- a/drivers/pci/dwc/pcie-designware.h
> +++ b/drivers/pci/dwc/pcie-designware.h
> @@ -28,8 +28,7 @@
>
> /* Parameters for the waiting for iATU enabled routine */
> #define LINK_WAIT_MAX_IATU_RETRIES 5
> -#define LINK_WAIT_IATU_MIN 9000
> -#define LINK_WAIT_IATU_MAX 10000
> +#define LINK_WAIT_IATU_MIN 9
>
> /* Synopsys-specific PCIe configuration registers */
> #define PCIE_PORT_LINK_CONTROL 0x710
> --
> 2.7.4
next prev parent reply other threads:[~2017-12-21 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171012075438epcas2p32599c2db4ed1512c81d1039bb1ed5607@epcas2p3.samsung.com>
2017-10-12 7:54 ` [PATCH] PCI: dwc: designware: don't sleep in atomic context Pankaj Dubey
2017-10-12 10:39 ` David Laight
2017-10-13 3:40 ` Pankaj Dubey
2017-10-20 18:19 ` Bjorn Helgaas
2017-10-23 9:14 ` David Laight
2017-11-06 19:30 ` Bjorn Helgaas
2017-12-21 16:39 ` Jingoo Han [this message]
2017-12-28 9:53 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301d37a7a$4b9681f0$e2c385d0$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox