From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759551Ab2EVACR (ORCPT ); Mon, 21 May 2012 20:02:17 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:9707 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753638Ab2EVACO (ORCPT ); Mon, 21 May 2012 20:02:14 -0400 X-AuditID: cbfee61b-b7faf6d000001f49-b8-4fbad76d6e4a From: Jingoo Han To: "'Andrew Morton'" , "'LKML'" Cc: "'Richard Purdie'" , "'Johan Hovold'" , "'Jingoo Han'" References: <002d01cd3732$e667d7b0$b3378710$%han@samsung.com> In-reply-to: <002d01cd3732$e667d7b0$b3378710$%han@samsung.com> Subject: [PATCH v2 3/3] backlight: lm3533_bl: use devm_ functions Date: Tue, 22 May 2012 09:01:49 +0900 Message-id: <000501cd37ae$161bf2e0$4253d8a0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac03MuZFAb/avBI5R1CWbY6n/+4MYwAexp+Q Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jQd2867v8DY5NZLK4vGsOmwOjx+dN cgGMUVw2Kak5mWWpRfp2CVwZxxdKFjTwVmy6MoG9gfEZVxcjJ4eEgInE684P7BC2mMSFe+vZ uhi5OIQEpjNKzDi6nBnCmc0kcWPBERaQKjYBNYkvXw6DdYgIREg0z5jFDGIzCxRJrHt0FcwW ErCVWPyvA6yeU8BO4kTPBlYQW1jAUeL82ZlgNSwCqhKb525lA7F5gervPz3PDGELSvyYfI8F YqaWxPqdx5kgbHmJzWveAtVwAF2qLvHory7ECUYSp7aeZIMoEZHY9+Id4wRGoVlIJs1CMmkW kkmzkLQsYGRZxSiaWpBcUJyUnmukV5yYW1yal66XnJ+7iREcxs+kdzCuarA4xCjAwajEwxtw aZe/EGtiWXFl7iFGCQ5mJRHeTW1AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxPluzwFxJITyxJ zU5NLUgtgskycXBKNTCuuVqz52j6kbP8byb9nn2OrUMm7rC1rMWuvVWZ8hd//uAz+Lc88Uj/ uzsTlrNMWlEeIHtn21OVf1VrLSdeW3Ljo/ac2bylj038pc7yfZwWKbx29Rfj6rkudQYJ27u8 fnfpuv4JLV/i13XuVQR/wn5OXYZbmxdP2vKrSzBQWPx2az+nYM6EBH5bJZbijERDLeai4kQA E3VKtV8CAAA= X-TM-AS-MML: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_kzalloc of these functions. Cc: Johan Hovold Cc: Richard Purdie Signed-off-by: Jingoo Han --- drivers/video/backlight/lm3533_bl.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 0148227..d916ffe 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -295,7 +295,7 @@ static int __devinit lm3533_bl_probe(struct platform_device *pdev) return -EINVAL; } - bl = kzalloc(sizeof(*bl), GFP_KERNEL); + bl = devm_kzalloc(&pdev->dev, sizeof(*bl), GFP_KERNEL); if (!bl) { dev_err(&pdev->dev, "failed to allocate memory for backlight\n"); @@ -317,8 +317,7 @@ static int __devinit lm3533_bl_probe(struct platform_device *pdev) &lm3533_bl_ops, &props); if (IS_ERR(bd)) { dev_err(&pdev->dev, "failed to register backlight device\n"); - ret = PTR_ERR(bd); - goto err_free; + return PTR_ERR(bd); } bl->bd = bd; @@ -348,8 +347,6 @@ err_sysfs_remove: sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); err_unregister: backlight_device_unregister(bd); -err_free: - kfree(bl); return ret; } @@ -367,7 +364,6 @@ static int __devexit lm3533_bl_remove(struct platform_device *pdev) lm3533_ctrlbank_disable(&bl->cb); sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); backlight_device_unregister(bd); - kfree(bl); return 0; } -- 1.7.1