public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Trimmer <simont@opensource.cirrus.com>
To: 'Chris Chiu' <chris.chiu@canonical.com>, <tiwai@suse.com>,
	<perex@perex.cz>
Cc: <sbinding@opensource.cirrus.com>, <linux-sound@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] ALSA: hda/realtek: fix micmute LEDs on HP Laptops with ALC3247
Date: Thu, 20 Mar 2025 14:24:35 +0000	[thread overview]
Message-ID: <000501db99a3$ce20d9e0$6a628da0$@opensource.cirrus.com> (raw)
In-Reply-To: <20250320124908.529842-2-chris.chiu@canonical.com>

On Thu, Mar 20, 2025 at 12:49 PM Chris Chiu wrote
> More HP EliteBook with Realtek HDA codec ALC3247 with combined CS35L56
> Amplifiers need quirk ALC236_FIXUP_HP_GPIO_LED to fix the micmute LED.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 30d4cd93dae1..eda406a4b52a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10734,6 +10734,11 @@ static const struct hda_quirk alc269_fixup_tbl[]
> = {
>  	SND_PCI_QUIRK(0x103c, 0x8d92, "HP ZBook Firefly 16 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8de8, "HP Gemtree",
> ALC245_FIXUP_TAS2781_SPI_2),
>  	SND_PCI_QUIRK(0x103c, 0x8de9, "HP Gemtree",
> ALC245_FIXUP_TAS2781_SPI_2),
> +	SND_PCI_QUIRK(0x103c, 0x8dec, "HP EliteBook 640 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dee, "HP EliteBook 660 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8df0, "HP EliteBook 630 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12",

Just the last two are out of sorted order

> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e14, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e15, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e16, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
> --
> 2.34.1
> 

-Simon


      reply	other threads:[~2025-03-20 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 12:49 [PATCH 1/2] ALSA: hda/realtek: fix micmute LEDs on HP Laptops with ALC3315 Chris Chiu
2025-03-20 12:49 ` [PATCH 2/2] ALSA: hda/realtek: fix micmute LEDs on HP Laptops with ALC3247 Chris Chiu
2025-03-20 14:24   ` Simon Trimmer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000501db99a3$ce20d9e0$6a628da0$@opensource.cirrus.com' \
    --to=simont@opensource.cirrus.com \
    --cc=chris.chiu@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox